From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF91DA00C3; Wed, 15 Dec 2021 15:44:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D5D140688; Wed, 15 Dec 2021 15:44:27 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 488B840041; Wed, 15 Dec 2021 15:44:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639579465; x=1671115465; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=SVKJ/+bM3XS9lM/IoBzHWYDSNXx4uibRQCatZTF9qik=; b=dkYbYH5QKVY0PYkyO9zu8PJdmML2zW+vID71hrcD75H/RlGp8xBMUHoa UP9RoDxTR3CCVWZe2al4Jbr8UzgS6RE/81/xF9QoirwlJvLEyjmFw+Yt3 dtB+8wOmuss9vla4cTwgMguv04QqIZwtMBOJdwrVJrFkxO/2v5rEYHRnq rDmhcr7r+iaOsyoWCant9h5Fm3NT5ZOzROHKidC46HIqtIY5eg1q6FCBP Gavly1koSoV8W1zdIll6CEUD/O109kLyFhbVQ7WwxahlNpCWnTcGwBNS5 e/nZfwml7/ExZ5gPfZwSzaaIAc68BELESUtR9LCbTvFFFQTTeJE9Ex8BR w==; X-IronPort-AV: E=McAfee;i="6200,9189,10198"; a="226521790" X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="226521790" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2021 06:44:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="545596963" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 15 Dec 2021 06:44:24 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 15 Dec 2021 06:44:23 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 15 Dec 2021 06:44:23 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 15 Dec 2021 06:44:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M+L6qpyieS2UHXj19DQZUPIqK45awpZO4Hpmf3rcGHTsC+m8DPHScwftCcJ5hq1C//UXMPOhrRPpdeV9Ze+LfcOrnbwBFG7HIgLX1dZVhnwznjR90KaVIKdP7/BWwzc6SQPtzIhnoe0E41X95ORgRtVMBArPqL4plwDA/7O4Kv+NjbSTG7it3+YWEdHu8y6yVcdeKBdrbxK1HSX55QU4Y5JUK/387EQsHP5Rkrl1zSQVRRSawh8YLmOBBdVqAnJGpTUIxk9j/PGLlcy4VWwJY9Zr0z4VRYQ5qmmDrCdyjAuTQRRc4XAoBShuswInfeOai3T81U6+U93d/gyw/sM4zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vNEjUpZGHlVoChVmAsrOra0/Rh8veCKiojRCGUiBtQA=; b=afGGj+b1GoIp8JthblLn9i9QHz8PM/uj6Sx6proj0ypF4W8qSbw4Ipy3yJlhgYEgqPVPLsMLaf42HDlxiky3VzZfTvaTu80hfhpcaSVrr7ZgXRv8pILfAxcbDFQEsIObr9adZJM/B3vW7YP0/DiiAThDBkTX0SoLVWyy1yVAO3JB2fkinm5V9pSWN+cqsv1LR1Xfc+0Dd6y3/1xblE4AoFitaw3eOujwXBP3AytU4rpCi4gtB5HA1yTb3lG5sWVieRr+WNEVJDfJScd59iuqk3YB5q/vw7KGdEHK3PU0VEbfVsKr7iOkUTyQrjwDjnie0nuwn0kdaBHa63gUeciKoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5111.namprd11.prod.outlook.com (2603:10b6:510:3c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Wed, 15 Dec 2021 14:44:13 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%6]) with mapi id 15.20.4801.014; Wed, 15 Dec 2021 14:44:13 +0000 Message-ID: <8a2eafeb-70d3-57ab-c192-2a6c41e183fc@intel.com> Date: Wed, 15 Dec 2021 14:44:04 +0000 Subject: Re: 19.11.11 patches review and test Content-Language: en-US To: Christian Ehrhardt CC: Kalesh Anakkur Purayil , "Abhishek Marathe" , Akhil Goyal , Ali Alnubani , David Christensen , Hariprasad Govindharajan , Hemant Agrawal , Ian Stokes , Jerin Jacob , John McNamara , Ju-Hyoung Lee , Kevin Traynor , Luca Boccassi , Pei Zhang , Raslan Darawsheh , Thomas Monjalon , , dpdk stable , dpdk-dev , , , , References: <20211209144315.3424225-1-christian.ehrhardt@canonical.com> <7bf4583f-c2de-0aa7-fb00-bf3e9ff8d99b@intel.com> <34e0a9a8-327e-0150-b18a-dc3bfdca7d11@intel.com> <43d82514-b3e0-1bbd-1351-f1221bfc53db@intel.com> <5ac74587-4a18-3e0b-f674-73f927a11f95@intel.com> <9f445304-f5d6-49a7-1f0f-65db8725d1ca@intel.com> <04da027a-d9c0-5fe2-ec8c-1e72c66bfcbb@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0048.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::17) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 025d2d51-ba5a-4949-0e79-08d9bfd95c95 X-MS-TrafficTypeDiagnostic: PH0PR11MB5111:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bATTcE7v4TlBK8+JOV6b4jqR3Lz82etprrYPJhSbd6EqMskfiKxei+jKrruWlI9w41zgxSdv870h8R3dWIrFsVKNL9oPXoFdPLsHHkIkI2ChcMhL7hm1JJdVJNGzd6/h/THAaUdUj3qYYogjZ+kUTRhG6WVgG9GYMJ71yn1AqewnfJuR/BvL6vIuhnFQQqp3M1HxvHbithDHYiCnzmcd2lJ+SU6glmOhJcf5wPkDeN78DTURhE1v5a0z4ImajA72M+yDqGzlRjwku/RNP5/7PkP96m17Li753laH1Ut3U/Jh+7TaubCX3zYBBGA8makQCAsR30vP+FIvxbSGRyovcaAraT4k31UvJBUXH2ppI6kvNqWBXbpLRFhA7FEVms55HnoAMkMh57wJJPybNgPQTlrYjP+5DsQB6hOXPrBzBhFXTyFDfMBZb2cudEyu3db/YLRueAL54GKU2CPyC54zbbEHfuUYgEnem30qLMvv61i0k3NzIND+GVjm+2GkXL1LG/V0f4Y2Ooohp5Bn//KVepwG4vyueXZ0XRPGBJV5JAmybqXPnoyF+2prgNoQWrArJ5cK1JAd6p2KaCnAcoXEX0Gw1h82oA5nfQ5XPT/RlIIR9ilPjitlYQaNtWwULaMy3dm0Ys+SvOyipKo6/Q+o1aFT+d/cYiF7/nU85Feqzjl/+hkahUJEkE3Rl0gZ6bKOlWHJbN/Thne6vUTJY5Q77QNBKzjmHfX7GgL9ngELvAOkgJVzT2XuzGGjtEThAMD3Cf/zjfTeXBYq4SavIEHxkfhi0YXARRwYET2s3CNtDtJy5OPHZaPnPad0O/bqu3zZQ/Bf0VtMEkbIY16O1rop0Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(53546011)(5660300002)(7416002)(66476007)(508600001)(44832011)(316002)(107886003)(38100700002)(82960400001)(186003)(6506007)(26005)(6666004)(83380400001)(66556008)(2906002)(8676002)(31686004)(66946007)(8936002)(966005)(6916009)(31696002)(36756003)(4326008)(2616005)(6486002)(6512007)(54906003)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFdSa0RUVXlkZVBHa2NDWDJjVTFWN0ZIOUJxVENybi9TLzNBWTB4TGZjcTBZ?= =?utf-8?B?d1JyWEFxeTFvNTA4a2RpSW84M2JVS0FSTFJlVnFtUmZXUVZjWi9rYnpKQXMx?= =?utf-8?B?NHBxUytTS0ZQbk5CMlpVQkw1M3ZxRjFiczlpWUZjcEpxSXM4NndTYWFTWFdH?= =?utf-8?B?VFFJVnpJaUtTL2tZMWd6bDNsZGsxMHIwT09lS3NRdU40SW4xY1p5MUhqR0hs?= =?utf-8?B?MDhtTE1NNHVncXNiVUE1TldoZ2VJcFpxbUV6Yll3WWpwQzg5N3dKMXE5QmtV?= =?utf-8?B?ekR1MkxNTWx1M0FRbWJxSE1kRXhHMzBuMGpaZHRUNHUwYTg4SWhIWHdkbVF5?= =?utf-8?B?SzZxa05MbUFocFlvQTdLWGlwbjMvT3lrOThnR2NMTm9xMzVCbmttRVRFSlhx?= =?utf-8?B?UUFTbzZKVlhlYXFPTEZzakZiajVraFVsNkFwMTcwNFFTNGp6Qi8zUjMwb0d3?= =?utf-8?B?SHdtbU4rOWQxY0RDQkZtbTQ3SHp6ekRTUG9ubDkwcElEWlErWGovM3pTbk0w?= =?utf-8?B?b1B1aUFtanpIbTRZaWRLR1J5My81dm5yUGw5TFRVWGxtVHBza1NZZDIrTnZz?= =?utf-8?B?RTNHd28rR0dCKy9IMzBhaUlhcTVZYmlkNE1YUXlMNFpNVHhSWGJmSEhaTFF4?= =?utf-8?B?VytPM1BWK0lGS0ZoL0hDb2ZlRXVTWG90ZEF2N21sSVNKM2J4RUg5WCtSOFVm?= =?utf-8?B?cDdyWjlHOS8vUWNVVHo1OEwvNUR5NXJrYmg1R2VKR283OS9aRnIwU3ZJdUdF?= =?utf-8?B?aWszKy9ncEluZ1V5UTQ4bEtobzVkVEpCQWg4eGRGOFYxTTQxb2FLVGNLUU9L?= =?utf-8?B?eWwwaW5mRDhjMzUxaC9QaE1zSFBzNmlabU1XSjljdFN2N1B4MlZWM0JPWS81?= =?utf-8?B?cW1lcUp3N2tiQ0M4WFR6MkEyMUN2QWdSR2RXWHEyYW9waFJBRFdBNnZVMTZB?= =?utf-8?B?Zm9jcDhIR21iakxVNEtCN3ZTRVMxSHExU3dEK3A5b2hYV2JsYmg1anhiZGNr?= =?utf-8?B?cXdEUS8xRTl6UkZIUm9naDdwejBtNjVXcVhIVmJqOVRRSlBqUEVnYXI0VndW?= =?utf-8?B?SzQwUCtkQ3Z5eWM0cTBMNXN6ZldkbWFjcVY2d1dXNG5jc1ZZUkFzS3BPNUFF?= =?utf-8?B?N0VYTmxSemh4N3Uya3hBWEsvOFNBZTZZb1NqL0tFUXd2dXNuR3hLTnNTVlcx?= =?utf-8?B?UXp6ei9EN1hoQllMQnlyZCtwVXI1WGtNcnhuVDlYSFRlWTRhbDZCNEt0ZURw?= =?utf-8?B?eUNyWVNCa1psK2VuVzNaL3ljWHR2RTRBVFBnRGZtWFB0UnNTWForYVl5NnJn?= =?utf-8?B?YVpMdHN1VFNvWUZZVmdJVTdDV0t3Z0VCTXk5akpSSFRuK1gwM1BZTDMrV0pk?= =?utf-8?B?V2ZjSTlRcnA5blllZnpOTGhsaUtsS1g1ODJEKzlCMVpVVmJ2MnNBV1UzQ0NW?= =?utf-8?B?b3N6aG44cHVNQngrV01LWENKRXp1eG5DVEdMRm1hL0ZEUWkyK2EyUUg3L0Zj?= =?utf-8?B?N2V6VlRXTCtpc3FMS0NrUFV2ZjdWY0o1OUdpaEVyRlZzejZkdTgzU2J4eDYx?= =?utf-8?B?emh2dDc3TjRMbjk2dkRuQ3dUdFVxRXV2cklJLzA5eUVhV2F6dUYxZVc3WHpJ?= =?utf-8?B?Z0VTT1ZjUE5RZlpUWkEvbEdVZkVNT2MwR29EU213OTlXVy9QOWJ6alJhTTFw?= =?utf-8?B?S0cvNXo4VUpuOVAwM0s5NU9hRnJDcjhDTUpHcDdZdFRtVzdUaE9aeEJWN1pu?= =?utf-8?B?cStId3d4dmlHQUpqQVZIS0F2VFNqVnFBWU8rbUhPRVM4Nk9vK2ZQbjAvbWhD?= =?utf-8?B?dVo2YnhkYWJuM2ZmOE1qK3AvN0RWUVFBbkJSWE5kMk9IUTFqVmZmRlgrQ3dk?= =?utf-8?B?eThwSGNwZ0U0cEpodzZUVFRaYWRhdTRCWjFvSnJtQ0xVWjVlUXdEVE1qOVdE?= =?utf-8?B?QytDcE0ybUhiSW1ZTkFmWFg3WnNlQm45Z25HQmdwQkRZdXZpRldxZUNvVXd3?= =?utf-8?B?OG0xNmF2SER6dWFRQk1TUU5IS1Uxb0V5MjdLS0dIaUhaa3VGeGZVMHdXaENR?= =?utf-8?B?TGtsV1B2RGZTZE5QN3R1dkdhY0FoS0wyRS82enBESGNTbWo0UnRpcHFzZTFx?= =?utf-8?B?QWRMYzBabXZuTzJVazI5MXdxYXozUkhQUzhLWGdHRUtYek9pRTFSMS9GV0lK?= =?utf-8?Q?sItvtCvyhjS2+x+ztdqpcwY=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 025d2d51-ba5a-4949-0e79-08d9bfd95c95 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 14:44:13.5161 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Qj7PulI0+2tR2WU7wFv9CT/8BuK3/9kpDa37Z6Oy8sxzf3ixjBmEPCVVou22w1vAdf9NI7Dj7mbC6jtNGSb3LQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5111 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/15/2021 1:17 PM, Christian Ehrhardt wrote: > On Tue, Dec 14, 2021 at 3:52 PM Ferruh Yigit wrote: >> >> On 12/14/2021 2:46 PM, Christian Ehrhardt wrote: >>> On Tue, Dec 14, 2021 at 2:58 PM Christian Ehrhardt >>> wrote: >>>> >>>> On Tue, Dec 14, 2021 at 2:10 PM Ferruh Yigit wrote: >>>>> >>>>> On 12/14/2021 11:39 AM, Christian Ehrhardt wrote: >>>>>> On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit wrote: >>>>>>> >>>>>>> On 12/14/2021 7:44 AM, Christian Ehrhardt wrote: >>>>>>>> On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil >>>>>>>> wrote: >>>>>>>> >>>>>>>> [snip] >>>>>>>> >>>>>>>>>>> [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson. >>>>>>>>>>> The back ported commit you mentioned takes care of meson build only I think. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> I see, make build is failing, and yes the fix is only for the meson. >>>>>>>>>> I will check the make build and will send a fix for it. >>>>>>>>> >>>>>>>>> [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors. >>>>>>>>> >>>>>>>>> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile >>>>>>>>> index 595bac2..bf0efab 100644 >>>>>>>>> --- a/kernel/linux/kni/Makefile >>>>>>>>> +++ b/kernel/linux/kni/Makefile >>>>>>>>> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include >>>>>>>>> MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h >>>>>>>>> MODULE_CFLAGS += -Wall -Werror >>>>>>>>> >>>>>>>>> +# >>>>>>>>> +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder. >>>>>>>>> +# >>>>>>>>> +ifdef CONFIG_SUSE_KERNEL >>>>>>>>> + KSRC = /lib/modules/$(shell uname -r)/source >>>>>>>>> + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),) >>>>>>>>> + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE >>>>>>>>> + endif >>>>>>>>> +endif >>>>>>>> >>>>>>>> Back in the day we tried various "is Suse and kernel version x.y" >>>>>>>> approaches, but they failed as there was no clear version throughout >>>>>>>> all of the Suse streams (leap, tumbleweed, sles) that worked well for >>>>>>>> all. >>>>>>>> This change here follows the upstream approach of "just check if it is there". >>>>>>>> >>>>>>>> I've applied this to 19.11 and did test builds across various distributions: >>>>>>>> 1. no non-suse build changed >>>>>>>> 2. suse builds stayed as-is or improved >>>>>>>> Formerly failing: >>>>>>>> openSUSE_Factory_ARM aarch64 >>>>>>>> SLE_15 x86_64 -> now working >>>>>>>> openSUSE_Leap_15.3 x86_64 -> now working >>>>>>>> openSUSE_Tumbleweed x86_64 -> still failing >>>>>>>> Formerly working: >>>>>>>> SLE_12_SP4 x86_64 ppc64le -> still fine >>>>>>>> openSUSE_Factory_ARM armv7l -> still fine >>>>>>>> openSUSE_Leap_15.2 x86_64 -> still fine >>>>>>>> >>>>>>> >>>>>>> Thanks Kalesh for the fix, and thanks Christian for testing. >>>>>>> >>>>>>> I was expecting this approach will fix all builds, after patch only >>>>>>> 'openSUSE_Tumbleweed' is failing, right? I will check it. >>>>>> >>>>>> As just discussed on IRC, yes and the log for that is at >>>>>> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64 >>>>>> >>>>>> It also is affected by an issue around -Werror=implicit-fallthrough, >>>>>> so even with KNI fixed it likely is going to fail. >>>>>> >>>>>>> And I think you need the fix as a patch anyway, @Kalesh are you >>>>>>> planning to send the patch? >>>>>> >>>>>> I don't need it, as I have already grabbed and preliminary added it: >>>>>> https://github.com/cpaelzer/dpdk-stable-queue/commit/d43fa3e198c08a3a76d70f4565b31ad3ab5f29c4 >>>>>> >>>>>> But surely, once/If you come up with a full patch that also includes >>>>>> tumbleweed I can replace it with yours. >>>>>> >>>>> >>>>> 'tumbleweed' error is odd, it complains about macro being redefined, >>>>> not sure why only in this platform we are getting an error. >>>>> >>>>> Macro is only defined in one place, but indeed header file included >>>>> multiple times, one direct and one indirect, so macro defined multiple >>>>> times but without value, so it should be OK and it is OK for other >>>>> platforms, it is defined as: >>>>> #define HAVE_TX_TIMEOUT_TXQUEUE >>>>> >>>>> Another option is that macro is defined in some other header file, >>>>> although I think that is very unlikely, can you please test with >>>>> below change to rule out that option: >>>> >>>> I'm testing that and will let you know in a bit ... >>> >>> Hi Ferruh, >>> with your change the build now works. >>> So indeed the symbol might have been defined elsewhere. >>> >> >> Interesting, this is self note to prefix 'RTE_' future macros. > > While generally an interesting Idea I do not know what I saw yesterday. > I have rebuilt it three times today and must say that other than I > said before - it does not work with RTE_*. > This was more expected result :) Is there a way to debug that environment? > Actually even worse than before, with RTE_.. even opensuse_leap15.3 > and SLES15 fail again :-/ > >>> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64 >>> >>> It still fails later with the "-Werror=implicit-fallthrough=" but that >>> is a different problem >>> => https://bugs.dpdk.org/show_bug.cgi?id=907 >>> >> >> Yep, this is igb_uio error, I assigned the bug to myself and will look at it. >> >>> Ferruh - are you ok if I merge your suggestion with the backport I got >>> from Kalesh? >>> >> >> Sure. >> But would you mind sending the final patch to the stable mail list as record? >> Or I can do the same if you prefer? >> >>>>> diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h >>>>> index 664785674ff1..71846419f437 100644 >>>>> --- a/kernel/linux/kni/compat.h >>>>> +++ b/kernel/linux/kni/compat.h >>>>> @@ -135,7 +135,7 @@ >>>>> (defined(RHEL_RELEASE_CODE) && \ >>>>> RHEL_RELEASE_VERSION(8, 3) <= RHEL_RELEASE_CODE) || \ >>>>> (defined(CONFIG_SUSE_KERNEL) && defined(HAVE_ARG_TX_QUEUE)) >>>>> -#define HAVE_TX_TIMEOUT_TXQUEUE >>>>> +#define RTE_HAVE_TX_TIMEOUT_TXQUEUE >>>>> #endif >>>>> >>>>> #if KERNEL_VERSION(5, 9, 0) > LINUX_VERSION_CODE >>>>> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c >>>>> index c8bad5f197ca..7397de4659b2 100644 >>>>> --- a/kernel/linux/kni/kni_net.c >>>>> +++ b/kernel/linux/kni/kni_net.c >>>>> @@ -623,7 +623,7 @@ kni_net_rx(struct kni_dev *kni) >>>>> /* >>>>> * Deal with a transmit timeout. >>>>> */ >>>>> -#ifdef HAVE_TX_TIMEOUT_TXQUEUE >>>>> +#ifdef RTE_HAVE_TX_TIMEOUT_TXQUEUE >>>>> static void >>>>> kni_net_tx_timeout(struct net_device *dev, unsigned int txqueue) >>>>> #else >>>>> >>>>> >>>>>>>> Past fixes always "inverted" the result, by fixing some but breaking others. >>>>>>>> This new patch works in "not breaking any formerly working build" but >>>>>>>> at the same time fixing a few builds. >>>>>>>> Therefore -> applied & thanks! >>>>>>>> >>>>>>>> I'll likely tag -rc2 before the end of the week. >>>>>>>> The good thing is that (so far) we have: >>>>>>>> 1. a non functional change >>>>>>>> 2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues) >>>>>>>> 3. a change fixing sles15SP3 builds >>>>>>>> >>>>>>>> Due to those, no current ongoing tests will have to be restarted. >>>>>>>> Whoever was able to build, can continue the current tests. >>>>>>>> Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a >>>>>>>> failing build and can work with -rc2 then. >>>>>>>> I'll explain the same in the mail about -rc2. >>>>>>>> >>>>>>>>> -include /etc/lsb-release >>>>>>>>> >>>>>>>>> ifeq ($(DISTRIB_ID),Ubuntu) >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Kalesh >>>>>>>> >>>>>>>> [snip] >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> Christian Ehrhardt >>>> Staff Engineer, Ubuntu Server >>>> Canonical Ltd >>> >>> >>> >> > >