From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 791CFA04DD; Wed, 28 Oct 2020 13:41:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B77DFCA65; Wed, 28 Oct 2020 13:41:50 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 32FA5C9C0 for ; Wed, 28 Oct 2020 13:41:48 +0100 (CET) IronPort-SDR: S0vPy3GiTU8g42m/+VejzF0W/6peWOMuoCwkcx9Tg/KN83vFkFvbxsTaXzfvty6nkXX7ksHfj4 NCIMHPu5smDQ== X-IronPort-AV: E=McAfee;i="6000,8403,9787"; a="164750143" X-IronPort-AV: E=Sophos;i="5.77,426,1596524400"; d="scan'208";a="164750143" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 05:41:47 -0700 IronPort-SDR: RgPbwevkckWU85nxE6cpXH2JRX4pe5L9RjRCoIo7iBPdpnywYem9YLRSC8Xid/ILd//YHsO/Yz 7EBuwBIycQWA== X-IronPort-AV: E=Sophos;i="5.77,426,1596524400"; d="scan'208";a="350982930" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.193.36]) ([10.213.193.36]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 05:41:45 -0700 To: Pallavi Kadam , dev@dpdk.org, thomas@monjalon.net Cc: ranjit.menon@intel.com, dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com, talshn@nvidia.com References: <20201021202616.2732-1-pallavi.kadam@intel.com> <20201026184458.8492-1-pallavi.kadam@intel.com> From: "Burakov, Anatoly" Message-ID: <8a3139b8-3a03-1f98-69c1-e3c38fb5fa4d@intel.com> Date: Wed, 28 Oct 2020 12:41:43 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201026184458.8492-1-pallavi.kadam@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal: enable windows apps to run on non-admin users X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 26-Oct-20 6:44 PM, Pallavi Kadam wrote: > Currently, since there is no runtime directory set, the code tries to > create a file in C:\ which is only writable with administrator > privileges. As a result, if the user is not admin, the application will > fail. > So, forcing no_shconf to 1 to prevent the code having to create files in > the runtime directory. > > Suggested-by: Dmitry Kozlyuk > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > lib/librte_eal/windows/eal.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c > index 6334aca03..105549de1 100644 > --- a/lib/librte_eal/windows/eal.c > +++ b/lib/librte_eal/windows/eal.c > @@ -295,6 +295,7 @@ rte_eal_init(int argc, char **argv) > RTE_LOG(WARNING, EAL, "Multi-process support is requested, " > "but not available.\n"); > internal_conf->in_memory = 1; > + internal_conf->no_shconf = 1; > } > > if (!internal_conf->no_hugetlbfs && (eal_hugepage_info_init() < 0)) { > This is the correct way, as in-memory implies no_shconf. I would like to deprecate noshconf option as it's a subset of what in-memory does. Acked-by: Anatoly Burakov -- Thanks, Anatoly