DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: oulijun <oulijun@huawei.com>
Cc: dev@dpdk.org, linuxarm@huawei.com
Subject: Re: [dpdk-dev] [PATCH 7/8] net/hns3: fix some static check errors by coverity
Date: Tue, 3 Nov 2020 12:18:51 +0000
Message-ID: <8a3669ae-25ad-6cd3-78f2-c84910a26a6f@intel.com> (raw)
In-Reply-To: <a8465995-ea69-7e45-16d4-8d260d341e0a@huawei.com>

On 11/3/2020 12:11 PM, oulijun wrote:
> 
> 
> 在 2020/11/3 19:41, Ferruh Yigit 写道:
>> On 11/2/2020 2:38 PM, Lijun Ou wrote:
>>> From: Hongbo Zheng <zhenghongbo3@huawei.com>
>>>
>>> This patch fixes some warnings.
>>> coverity:function format symbol does not match
>>
>> I think we are not getting these warnings in the public coverity, is there a 
>> specific configuration for it?
>>
> Yes, the coverity scan is configured internally instead of the DPDK CI coverity 
> warning. However, we think it is reasonable.
 >

That is OK, I just wonder if it is enabled explicitly with a config, and what 
that config is (for the record).

>>>
>>> coverity:not_unsigned: Violation: Operand
>>> "hw->hw_tc_map & (1UL << i)",  Right Expression:
>>> "1UL << i" is not an unsigned type
>>>
>>
>> Can you please split this patch into multiple patches, one for each type of 
>> issue?
>>
>>> Coverity issue: 91708127
>>> Coverity issue: 89776953
>>
>> I assume these are internal coverity ids, it has not much value to record them 
>> in the commit log.
>>
>> We record the public coverity [1] ids with this tag.
> Hi, Ferruh
>    The warning is our configuration. As a result, it has no public id.If the ID 
> is not added, the check-git-log check fails.
> 
> Do you have any good advice?
> 

Doesn't mention from coverity at all in the commit log,
like first patch can be:
"
net/hns3: fix logging format symbols
   <more details>
"

etc...

> Thanks
> Lijun Ou
>>
>> [1]
>> https://scan.coverity.com/projects/dpdk-data-plane-development-kit?tab=overview
>>
>>> Fixes: 62e3ccc2b94c ("net/hns3: support flow control")
>>> Fixes: 19a3ca4c99cf ("net/hns3: add start/stop and configure operations")
>>> Fixes: a5475d61fa34 ("net/hns3: support VF")
>>> Fixes: fb94f359481f ("net/hns3: fix adding multicast MAC address")
>>> Fixes: fcba820d9b9e ("net/hns3: support flow director")
>>> Fixes: a951c1ed3ab5 ("net/hns3: support different numbers of Rx and Tx queues")
>>> Fixes: 2790c6464725 ("net/hns3: support device reset")
>>> Fixes: 23d4b61fee5d ("net/hns3: support multiple process")
>>> Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations")
>>> Fixes: e31f123db06b ("net/hns3: support NEON Tx")
>>> Fixes: 8839c5e202f3 ("net/hns3: support device stats")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
>>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>>
>> <...>
>>
>> .
>>


  reply	other threads:[~2020-11-03 12:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02 14:38 [dpdk-dev] [PATCH 0/8] misc fixes for hns3 Lijun Ou
2020-11-02 14:38 ` [dpdk-dev] [PATCH 1/8] net/hns3: add limit promisc mode to VF Lijun Ou
2020-11-02 14:38 ` [dpdk-dev] [PATCH 2/8] net/hns3: fix Tx cksum outer header prepare Lijun Ou
2020-11-02 14:38 ` [dpdk-dev] [PATCH 3/8] net/hns3: fix Tx checksum with fix header length Lijun Ou
2020-11-02 14:38 ` [dpdk-dev] [PATCH 4/8] net/hns3: add VXLAN-GPE packets TSO and checksum support Lijun Ou
2020-11-02 14:38 ` [dpdk-dev] [PATCH 5/8] net/hns3: fix configurations of port-level scheduling rate Lijun Ou
2020-11-02 14:38 ` [dpdk-dev] [PATCH 6/8] net/hns3: fix visit unsupported QL register error Lijun Ou
2020-11-02 14:38 ` [dpdk-dev] [PATCH 7/8] net/hns3: fix some static check errors by coverity Lijun Ou
2020-11-03 11:41   ` Ferruh Yigit
2020-11-03 12:11     ` oulijun
2020-11-03 12:18       ` Ferruh Yigit [this message]
2020-11-02 14:38 ` [dpdk-dev] [PATCH 8/8] net/hns3: adjust some header files location Lijun Ou
2020-11-03 12:15 ` [dpdk-dev] [PATCH 0/8] misc fixes for hns3 Ferruh Yigit
2020-11-04  8:34   ` oulijun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a3669ae-25ad-6cd3-78f2-c84910a26a6f@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=linuxarm@huawei.com \
    --cc=oulijun@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git