From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A03C542636; Mon, 25 Sep 2023 16:21:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0DA940E25; Mon, 25 Sep 2023 16:21:26 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2059.outbound.protection.outlook.com [40.107.101.59]) by mails.dpdk.org (Postfix) with ESMTP id 29E2140285; Mon, 25 Sep 2023 16:21:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S8nj+ncsm+7hhNju0tFt/04yQb+fVw6GiGOXulcQ0929d/u1OpTICfKYNyFmQoUgHbxvb4Oqj8FmU8mKecuuISrfJ+eb18VXd+UdgkNQcF74NzgVi+HZ/IPQELdoJJG0wZrqadgmmDH7VLycNmJPjed2E7A8dN7fRDQ8mXJUgYXEzCdtF+p+zx5+vNE+jO18y4lCb+kZqEShzWVjtdccfgwVwrBtb9wfGg/ZPmQESCbocj2cH1tYNEY5WzLm83vCxLnmL//fJZVrpNdYUj2rmBVv+/q9uZ/oc+xNAcXWdZEujpZzELsgZ4gL/rm1A6WdF8r1zDNjvb/Mc42CTMnXSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E7gpXOTxvemOU2nanPwmyFaNsrcLPi9fAlWH3wi3SRI=; b=a9yMJTDeR/WDiWMERt3Z+/hvF56Ll/bA9U/uGDsZkPBsXawi0w5BLZLp3KMCw3NMtKDlfvSLzJ+aLZ8CLvRrVDbcH4qpdLAZi2vhdwb/rWnBieOmgOLPwwVgOrdQJVPEm3qrHkEOFV2ou+xEhzHMPx8Pg0in+v6S4Mitqw1vsZ7vgVezmXriiJEUHME3k4TXxf0YecUxord+nqG+y/qaIf8A78ZPGmSbykIC5OFcnUgnGhPhxuiOFODFcJ79CZaERi0Kv5Ieju03pkjKqX0839dfADpDGbdZIrTHmagUwJNnVTQvgqRB6fhOF5hON9YAQvx7N4KlzOCWNW/09Z3pgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E7gpXOTxvemOU2nanPwmyFaNsrcLPi9fAlWH3wi3SRI=; b=UvT9kH17JvRpouil+Tw1cq/BVZoRBMxHIhjfFfCOYZ1SJR1FQiep2hzFOp/lX6Sau4yDfuOLkDX6ZGhJ6RWLJZOcLbezjPuYIfuHuPDCyrbzsM3nFlk2uORAMrUJ4Ny7GXzDuoRKrsNrrb340QHu4gskOo2nSKbJx67OxOwAntg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB6693.namprd12.prod.outlook.com (2603:10b6:510:1b0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.23; Mon, 25 Sep 2023 14:21:22 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6813.027; Mon, 25 Sep 2023 14:21:22 +0000 Message-ID: <8a469b5d-6047-4123-ad47-6416385b0de9@amd.com> Date: Mon, 25 Sep 2023 15:21:16 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] net/hns3: optimize free mbuf code for SVE Tx Content-Language: en-US To: Dongdong Liu , dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru Cc: stable@dpdk.org, Honnappa Nagarahalli , Ruifeng Wang References: <20230711102448.11627-1-liudongdong3@huawei.com> <20230711102448.11627-4-liudongdong3@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230711102448.11627-4-liudongdong3@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0030.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::10) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB6693:EE_ X-MS-Office365-Filtering-Correlation-Id: 00db3205-dacd-417e-e6b1-08dbbdd2b17a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cgDtKQPU4wf453HJW4A1215XFZZJY30Zis2N0j9PFEDTDjCHbaUm5q+mXAX9Ajtb45pVWn5G3UvekY6NcfahXwJgwmz4onMnizlZ8e/+ejEOtTs70IFl/bN4TaMbuLoQ5tI6RA3kJoJF/RfyLRYmrzwckDj9mw8ZWTG+fIZbRjF0+y64A1WsRUrVQl+NGBzj7jgZBEBIyPTniGVrXz06Lssu47HK7IL+n0pxRnnZJ9/6bPBPgO69ChAk/5gKmQamQaGNcCvbSB0+BlZSLKJHfhzR1hWh3zjOjllXfxNiXEdli+0MJotqxi9RqzrhXwH04gQ/7ZorOmoDQ02jeYvdGSZdTV20mP18HaCTLxgqwvCIJRpMTr3CYhQpR0HvPmerR95or12ml8cHgK3iJUkNncJkup4wjXs/iJCBuLlT45OIt/NSLxZBUENHu4Ik4btRwRvotfVuenpJ/QIoXgHKm6v3Jvfgtz309Araj2/iG6UeOqkghEY52BvO/Cy61GPz/DYwZti9cycYA0t30e/PbZXJCjPNXUDjzUEYVsdwEiWR6YpiO0r8oBtj2VFNo9Ouu52cRkhtcGn2qJprkl6hCyIUGU09LRPD5u+WpFL8ULlsRWAp2aFJldlLZc6OmJ8HDCmtURaMst/xpCUhxiwdAA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(136003)(39860400002)(396003)(346002)(366004)(230922051799003)(186009)(1800799009)(451199024)(26005)(4744005)(2616005)(2906002)(31696002)(5660300002)(44832011)(86362001)(38100700002)(316002)(31686004)(8936002)(4326008)(478600001)(41300700001)(8676002)(6486002)(66476007)(54906003)(66946007)(6512007)(36756003)(66556008)(6666004)(83380400001)(53546011)(6506007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzlEVk1XaHk0dXBWR2lWUnd6ejM4ajJQYmw2UWRhQmNoS0JaMTNXSVZ0UWJZ?= =?utf-8?B?djAzOHNaOHF3UXJscnh4aXdqZWVBMm0wUGVHTExybVNucEZGb1BSbndlcy9P?= =?utf-8?B?eGlMK3VZaGpCV04xRjI1a2pJejhyV1czT0dkL0hOSDA1dC9kSWU4MklyNTEr?= =?utf-8?B?STRaUmNBbnQ2eHQvd2VQMExGcmlNdWM4dCtQVnhXVVBnNzRseTBUcjMyc1M5?= =?utf-8?B?QklBVEVEcHBONFdFOVNNVW93NGdwTTlXdkN6T0lZQ05pWVRhYTVnSGJ0Vmg0?= =?utf-8?B?ektMSjEzN0VEZEdscXJWSWpDQjNWM1FYeTNlTDJiYVNjWU9GeVRLWjVQaXNF?= =?utf-8?B?NkRzYkVYcnplZ0ZESU1PZjlRNnN4SkZmTit0dElFZG9ZNXVSSFgzNFhCUWZY?= =?utf-8?B?a0F5U2dNUDNYS1hGMmdzMXNka0NtNlo5d2VvdmNaMkF4ZW9VZlZmbGRmbmF3?= =?utf-8?B?RlJOdTlTVVZvZ0o2ZXp5OFVkR3pXR2pHT3NwTUJMWG0rcEtqUDJYWG8xS1pz?= =?utf-8?B?dzJHdm9XQXFNSXNDTDBlK1R4TWdGU3hwVVl6bnU0a0lieGdWVWJVbkNEdjhu?= =?utf-8?B?QUU4eUptZFVVRDd5UVM4ZElHeE9ERnVFWW1vSG5lYVBKRHk5YXZ6ckpEajhy?= =?utf-8?B?c2lqbXBvR0I0ZUNiMlFuMWFiNlk2blVLb2RYNmd2VHNBZnUvR2hJU0s3Uity?= =?utf-8?B?QTJpNllYamYwU2M0QVM5eXl4alVQSlN6akxzVTRXTFg3UlN2RllNdjgxZWJ6?= =?utf-8?B?MzMxTW9jVEJpU3RBNUl3UVpkUDJsMEYwU1hHYmNmcVdLaExGaXFHbzZRbTY3?= =?utf-8?B?N1dsSDNuMFJSbndSbEhnRi8yQThUTnZ0anpXbXhNWUJ4TUs1Z21KK0FhWlow?= =?utf-8?B?UUlJbXhxN1dnMGJsTCtyMFpiNjFBTG1sZzhZbm1NTnkyK21NVlhxZ3hhc0tP?= =?utf-8?B?bXVOb051VE9lcjl6QzNnMmU0OVdKL2Fvc1MzdFdMaXYvUUwwTlV4ZVByb3NU?= =?utf-8?B?N1JDRnR1d3FOVTJOR0xTQ2ZVTFVzVjlhVDZSNDYyT0ZtRDU3b2ZpQWVEOUoy?= =?utf-8?B?Q3Y3emZmVjlHUE40SnM2QlRqMXlkN1hlUll0Qm9uU0xUYWVKZm5pbytKL0Nr?= =?utf-8?B?b3JVajlwcWdwU0dMNHFxTWs5aURvQWxha1hiRlFmTlpCR2sxMVFhMEhjTUpY?= =?utf-8?B?czBsWjNFN2VnTVUyVkV1aTY2MVJhSnRlakJuQi9RUWJEN1R4SWZyTmQxeGtY?= =?utf-8?B?eWNzRHBvM25NTGdTNDEzRTl2QUxoRkc2TEduWmFBWCtoMzcyb0Jsc0JlaEF6?= =?utf-8?B?a0RjNThteG44WnM3REI1VUtUL1hubnpUWEhjQkxCeVVWeWlFd3BsSUQzVE5B?= =?utf-8?B?SEN0ek5YUS9YSDdxbUVMRmtGZDJaMEQvaWFFRHJyMlQ0YXhVRmVLSmNKMUFi?= =?utf-8?B?UU8wNk10VXF2UDFaMk5LSnVhWWJkZ3FtOHU5VkE3NlcyMzhxek1uVXhJSWRv?= =?utf-8?B?YWRWcEFadFVZNkVXeC9VUy9sdG1ycjBCSEFjNVdVMFpqRnBtU3hUR0xGVjFY?= =?utf-8?B?cTl2T0RiQnN5SHJCUzJBenpONDFSaEpuOG5aU1VjYnNBNUQya1BrWG16RXNv?= =?utf-8?B?RjN3dVg5Q0NnUlNCakhGam5lMzVBb0V4MTJpL2ZGaW56R2U2TU5OcmZSanZO?= =?utf-8?B?QytOYit0R1pKZHA1M2E1QXE5MzVRMVRIL0wrbFB6djhuOHFkS2FRWnpabTlU?= =?utf-8?B?anBqUjJrZmVKcmVTcXBzMXp2WnFoZXNjV1ZzNStKZjBwQjZpZXd6c0RLTnQz?= =?utf-8?B?bEw2QVdNS1JVc0t5NTNENHZZaTh3NEUvNDVHVUwyODM4dEFURVdHdGk5SFAz?= =?utf-8?B?K2l3cVFGd0dFbHArUjMzT2JnWHBIVGxHQ2JoQ3NYdDRBbVhXS2VIWWJpZjg2?= =?utf-8?B?Q25CSndsQjB5blJxaWs3K3c4dnpsL29BeS9mU3lqL0tRTnhCZmlZV0tqMVRW?= =?utf-8?B?NW4zWG8zNG1zR1BHTEpBR3VxWUdYWUFOeXlNTVkwbnRKbWxZZ3VDZEZOU0dl?= =?utf-8?B?NlVQTExxSHNsUWw2LzJBNWl5dEpKQlloVythVS9UdXJNQi9EUXlNQ3ZId2Vy?= =?utf-8?Q?5tmxldinYKLcziyNZ1ojmrFSx?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00db3205-dacd-417e-e6b1-08dbbdd2b17a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 14:21:22.3192 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JkqJzEzuyh5w22YkQmvAHELSd0G/pUIOTHxIgnU7LLFJQKG5MiaRJVhQLb46kjrV X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6693 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/11/2023 11:24 AM, Dongdong Liu wrote: > From: Huisong Li > > Currently, hns3 SVE Tx checks the valid bits of all descriptors > in a batch and then determines whether to release the corresponding > mbufs. Actually, once the valid bit of any descriptor in a batch > isn't cleared, driver does not need to scan the rest of descriptors. > > If we optimize SVE codes algorithm about this function, the performance > of a single queue for 64B packet is improved by ~2% on txonly forwarding > mode. And if use C code to scan all descriptors, the performance is > improved by ~8%. > > So this patch selects C code to optimize this code to improve the SVE > Tx performance. > > Signed-off-by: Huisong Li > Signed-off-by: Dongdong Liu > SVE Tx optimized by removing SVE implementation :) Do you have any insight why generic vector implementation is faster?