From: Ferruh Yigit <ferruh.yigit@amd.com>
To: "Niklas Söderlund" <niklas.soderlund@corigine.com>, dev@dpdk.org
Cc: oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>,
louis.peens@corigine.com, stable@dpdk.org,
Chaoyong He <chaoyong.he@corigine.com>
Subject: Re: [PATCH] net/nfp: fix memory leak for receive function
Date: Wed, 5 Oct 2022 16:41:48 +0100 [thread overview]
Message-ID: <8a472501-4228-7d6d-ad2b-3fafd9a4f570@amd.com> (raw)
In-Reply-To: <20220922130944.698880-1-niklas.soderlund@corigine.com>
On 9/22/2022 2:09 PM, Niklas Söderlund wrote:
> From: Long Wu <long.wu@corigine.com>
>
> nfp_net_recv_pkts() should not return a value that less than 0 and the
> inappropriate return value in receive loop also causes the memory leak.
> Modify code to avoid return a value less than 0. Furthermore, When
> nfp_net_recv_pkts() break out from the receive loop because of packet
> problems, a rte_mbuf will not be freed and it will cause memory leak.
> Free the rte_mbuf before break out.
>
> Fixes: b812daadad0d ("nfp: add Rx and Tx")
> Cc: louis.peens@corigine.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> Signed-off-by: Niklas Söderlund <niklas.soderlund@corigine.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2022-10-05 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 13:09 Niklas Söderlund
2022-10-05 15:41 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a472501-4228-7d6d-ad2b-3fafd9a4f570@amd.com \
--to=ferruh.yigit@amd.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=louis.peens@corigine.com \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).