DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Yan, Zhirun" <zhirun.yan@intel.com>
To: "Cao, Yahui" <yahui.cao@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
	"Zhang,  Qi Z" <qi.z.zhang@intel.com>,
	"Wang, Xiao W" <xiao.w.wang@intel.com>,
	"Guo, Junfeng" <junfeng.guo@intel.com>
Cc: "Su, Simei" <simei.su@intel.com>, "Xu, Ting" <ting.xu@intel.com>,
	"Zhang,  Yuying" <yuying.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 3/5] net/ice: add outer input set mask to distinguish outer fields
Date: Thu, 7 Jan 2021 03:11:34 +0000
Message-ID: <8a79bbe9cb9e416cad537f4e941513d2@intel.com> (raw)
In-Reply-To: <b1f6ec4188f2404c98732e98a06ca572@intel.com>



> -----Original Message-----
> From: Cao, Yahui
> Sent: Friday, December 25, 2020 1:28 PM
> To: Yan, Zhirun <zhirun.yan@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>; Guo,
> Junfeng <junfeng.guo@intel.com>
> Cc: Su, Simei <simei.su@intel.com>; Xu, Ting <ting.xu@intel.com>; Zhang,
> Yuying <yuying.zhang@intel.com>
> Subject: RE: [PATCH v1 3/5] net/ice: add outer input set mask to distinguish
> outer fields
> 
> 
> 
> > -----Original Message-----
> > From: Yan, Zhirun <zhirun.yan@intel.com>
> > Sent: Monday, December 21, 2020 2:52 PM
> > To: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Cao, Yahui
> > <yahui.cao@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>; Guo,
> > Junfeng <junfeng.guo@intel.com>
> > Cc: Su, Simei <simei.su@intel.com>; Xu, Ting <ting.xu@intel.com>;
> > Zhang, Yuying <yuying.zhang@intel.com>; Yan, Zhirun
> > <zhirun.yan@intel.com>
> > Subject: [PATCH v1 3/5] net/ice: add outer input set mask to
> > distinguish outer fields
> >
> > Add 64-bit input_set_mask_f for outer input set. input_set_mask_f is
> > used for inner fields or non-tunnel fields. Adjust indentation of
> > ice_pattern_match_item list in switch, RSS and FDIR for easy review.
> > For fields in tunnel layer, like GTPU TEID, put them in outer part.
> >
> > Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
> > ---
> >  drivers/net/ice/ice_fdir_filter.c   | 110 ++++-----
> >  drivers/net/ice/ice_generic_flow.h  |   1 +
> >  drivers/net/ice/ice_hash.c          | 192 ++++++---------
> >  drivers/net/ice/ice_switch_filter.c | 348
> > ++++++++++------------------
> >  4 files changed, 231 insertions(+), 420 deletions(-)
> >
> > diff --git a/drivers/net/ice/ice_fdir_filter.c
> > b/drivers/net/ice/ice_fdir_filter.c
> > index 1f2576a444..76e0a8df38 100644
> > --- a/drivers/net/ice/ice_fdir_filter.c
> > +++ b/drivers/net/ice/ice_fdir_filter.c
> > @@ -55,92 +55,74 @@
> >
> 
> ...
> > +	{pattern_eth_ipv4,				ICE_INSET_NONE,
> 			ICE_FDIR_INSET_ETH_IPV4, 	ICE_INSET_NONE},
> > +	{pattern_eth_ipv4_udp,
> 	ICE_INSET_NONE,	ICE_FDIR_INSET_ETH_IPV4_UDP,
> 	ICE_INSET_NONE},
> > +	{pattern_eth_ipv4_tcp,
> 	ICE_INSET_NONE,
> 	ICE_FDIR_INSET_ETH_IPV4_TCP, 	ICE_INSET_NONE},
> > +	{pattern_eth_ipv4_sctp,
> 	ICE_INSET_NONE, 	ICE_FDIR_INSET_ETH_IPV4_SCTP,
> 	ICE_INSET_NONE},
> > +	{pattern_eth_ipv6,				ICE_INSET_NONE,
> 			ICE_FDIR_INSET_ETH_IPV6, 	ICE_INSET_NONE},
> > +	{pattern_eth_ipv6_udp,
> 	ICE_INSET_NONE, 	ICE_FDIR_INSET_ETH_IPV6_UDP,
> 	ICE_INSET_NONE},
> > +	{pattern_eth_ipv6_tcp,
> 	ICE_INSET_NONE,
> 	ICE_FDIR_INSET_ETH_IPV6_TCP, 	ICE_INSET_NONE},
> > +	{pattern_eth_ipv6_sctp,
> 	ICE_INSET_NONE, 	ICE_FDIR_INSET_ETH_IPV6_SCTP,
> 	ICE_INSET_NONE},
> > +	{pattern_eth_ipv4_udp_vxlan_ipv4,		ICE_INSET_NONE,
> 			ICE_FDIR_INSET_VXLAN_IPV4_L,
> 	ICE_INSET_NONE},
> > +	{pattern_eth_ipv4_udp_vxlan_ipv4_udp,
> 	ICE_INSET_NONE, 	ICE_FDIR_INSET_VXLAN_IPV4_UDP_L,
> 	ICE_INSET_NONE},
> > +	{pattern_eth_ipv4_udp_vxlan_ipv4_tcp,
> 	ICE_INSET_NONE, 	ICE_FDIR_INSET_VXLAN_IPV4_TCP_L,
> 	ICE_INSET_NONE},
> > +	{pattern_eth_ipv4_udp_vxlan_ipv4_sctp,
> 	ICE_INSET_NONE, 	ICE_FDIR_INSET_VXLAN_IPV4_SCTP_L,
> 	ICE_INSET_NONE},
> > +	{pattern_eth_ipv4_udp_vxlan_eth_ipv4,
> 	ICE_INSET_NONE,
> 	ICE_FDIR_INSET_VXLAN_IPV4_L, 		ICE_INSET_NONE},
> > +	{pattern_eth_ipv4_udp_vxlan_eth_ipv4_udp,	ICE_INSET_NONE,
> 			ICE_FDIR_INSET_VXLAN_IPV4_UDP_L,
> 	ICE_INSET_NONE},
> > +	{pattern_eth_ipv4_udp_vxlan_eth_ipv4_tcp,	ICE_INSET_NONE,
> 			ICE_FDIR_INSET_VXLAN_IPV4_TCP_L,
> 	ICE_INSET_NONE},
> > +	{pattern_eth_ipv4_udp_vxlan_eth_ipv4_sctp,	ICE_INSET_NONE,
> 			ICE_FDIR_INSET_VXLAN_IPV4_SCTP_L,
> 	ICE_INSET_NONE},
> >  };
> >
> 
> [Cao, Yahui] Why is the mask put in the 3rd column instead of 2nd column ? I
> prefer the way that 2nd column is for outer field and 3rd column is for inner
> field.

Both are OK. But for my way, the 2nd column is only for tunnel outer. The 3rd
can be reused by non-tunnel and tunnel inner part. I will redefine the macro.

> >
> >  static int
> > --
> > 2.25.1


  reply	other threads:[~2021-01-07  3:11 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-21  6:51 [dpdk-dev] [PATCH v1 0/5] Refactor FDIR pattern parser Zhirun Yan
2020-12-21  6:51 ` [dpdk-dev] [PATCH v1 1/5] net/ice: clean input set macro definition Zhirun Yan
2020-12-21  6:51 ` [dpdk-dev] [PATCH v1 2/5] net/ice: refactor flow pattern parser Zhirun Yan
2020-12-25  5:21   ` Cao, Yahui
2021-01-07  3:07     ` Yan, Zhirun
2020-12-21  6:51 ` [dpdk-dev] [PATCH v1 3/5] net/ice: add outer input set mask to distinguish outer fields Zhirun Yan
2020-12-25  5:27   ` Cao, Yahui
2021-01-07  3:11     ` Yan, Zhirun [this message]
2020-12-21  6:51 ` [dpdk-dev] [PATCH v1 4/5] net/ice: add outer input set mask check Zhirun Yan
2020-12-25  5:28   ` Cao, Yahui
2021-01-07  3:14     ` Yan, Zhirun
2020-12-21  6:51 ` [dpdk-dev] [PATCH v1 5/5] net/ice: enable FDIR outer/inner fields for VXLAN Zhirun Yan
2021-01-27  5:29 ` [dpdk-dev] [PATCH v2 0/3] Refactor FDIR pattern parser Zhirun Yan
2021-01-27  5:29   ` [dpdk-dev] [PATCH v2 1/3] net/ice: clean input set macro definition Zhirun Yan
2021-01-27  5:29   ` [dpdk-dev] [PATCH v2 2/3] net/ice: refactor flow pattern parser Zhirun Yan
2021-01-27  5:29   ` [dpdk-dev] [PATCH v2 3/3] net/ice: add outer input set mask to distinguish outer fields Zhirun Yan
2021-03-02  2:54   ` [dpdk-dev] [PATCH v3 0/6] Refactor FDIR pattern parser Zhirun Yan
2021-03-02  2:54     ` [dpdk-dev] [PATCH v3 1/6] net/ice: clean input set macro definition Zhirun Yan
2021-03-02  2:54     ` [dpdk-dev] [PATCH v3 2/6] net/ice: refactor structure field Zhirun Yan
2021-03-02  2:54     ` [dpdk-dev] [PATCH v3 3/6] net/ice: refactor flow pattern parser Zhirun Yan
2021-03-02  2:54     ` [dpdk-dev] [PATCH v3 4/6] net/ice: refactor input set conf Zhirun Yan
2021-03-02  2:54     ` [dpdk-dev] [PATCH v3 5/6] net/ice: add outer input set mask to distinguish outer fields Zhirun Yan
2021-03-02  2:54     ` [dpdk-dev] [PATCH v3 6/6] net/ice: clean GTPU flow_type for FDIR Zhirun Yan
2021-03-05  8:46     ` [dpdk-dev] [PATCH v3 0/6] Refactor FDIR pattern parser Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a79bbe9cb9e416cad537f4e941513d2@intel.com \
    --to=zhirun.yan@intel.com \
    --cc=dev@dpdk.org \
    --cc=junfeng.guo@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=simei.su@intel.com \
    --cc=ting.xu@intel.com \
    --cc=xiao.w.wang@intel.com \
    --cc=yahui.cao@intel.com \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git