From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE233A09FF; Thu, 7 Jan 2021 04:11:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83C12140E6B; Thu, 7 Jan 2021 04:11:40 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 17004140E63 for ; Thu, 7 Jan 2021 04:11:37 +0100 (CET) IronPort-SDR: tpalKNM5w4xznhTe9ssbx5HoWMVJfF1NGy/5LQgNhF39f2WTdHK1p2p+3NuzumzsUPfUJOXXGC Awe3tQFGcybA== X-IronPort-AV: E=McAfee;i="6000,8403,9856"; a="156555505" X-IronPort-AV: E=Sophos;i="5.79,328,1602572400"; d="scan'208";a="156555505" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2021 19:11:36 -0800 IronPort-SDR: GdXfL3ykyGKXD7oZDxrLWxKEp8qQfvHkA4XD8fB8KqdgabR9kXqZM6Lavghuaid0IcAid/QIUn HRjmuBlw+bGg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,328,1602572400"; d="scan'208";a="343751570" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga007.fm.intel.com with ESMTP; 06 Jan 2021 19:11:36 -0800 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 6 Jan 2021 19:11:36 -0800 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 7 Jan 2021 11:11:34 +0800 Received: from shsmsx605.ccr.corp.intel.com ([10.109.6.215]) by SHSMSX605.ccr.corp.intel.com ([10.109.6.215]) with mapi id 15.01.1713.004; Thu, 7 Jan 2021 11:11:34 +0800 From: "Yan, Zhirun" To: "Cao, Yahui" , "dev@dpdk.org" , "Zhang, Qi Z" , "Wang, Xiao W" , "Guo, Junfeng" CC: "Su, Simei" , "Xu, Ting" , "Zhang, Yuying" Thread-Topic: [PATCH v1 3/5] net/ice: add outer input set mask to distinguish outer fields Thread-Index: AQHW12ZhD3FLideZVEO19k2EdZn1oKoGyH8AgBTNJrA= Date: Thu, 7 Jan 2021 03:11:34 +0000 Message-ID: <8a79bbe9cb9e416cad537f4e941513d2@intel.com> References: <20201221065150.1600719-1-zhirun.yan@intel.com> <20201221065150.1600719-4-zhirun.yan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 3/5] net/ice: add outer input set mask to distinguish outer fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Cao, Yahui > Sent: Friday, December 25, 2020 1:28 PM > To: Yan, Zhirun ; dev@dpdk.org; Zhang, Qi Z > ; Wang, Xiao W ; Guo, > Junfeng > Cc: Su, Simei ; Xu, Ting ; Zhang, > Yuying > Subject: RE: [PATCH v1 3/5] net/ice: add outer input set mask to distingu= ish > outer fields >=20 >=20 >=20 > > -----Original Message----- > > From: Yan, Zhirun > > Sent: Monday, December 21, 2020 2:52 PM > > To: dev@dpdk.org; Zhang, Qi Z ; Cao, Yahui > > ; Wang, Xiao W ; Guo, > > Junfeng > > Cc: Su, Simei ; Xu, Ting ; > > Zhang, Yuying ; Yan, Zhirun > > > > Subject: [PATCH v1 3/5] net/ice: add outer input set mask to > > distinguish outer fields > > > > Add 64-bit input_set_mask_f for outer input set. input_set_mask_f is > > used for inner fields or non-tunnel fields. Adjust indentation of > > ice_pattern_match_item list in switch, RSS and FDIR for easy review. > > For fields in tunnel layer, like GTPU TEID, put them in outer part. > > > > Signed-off-by: Zhirun Yan > > --- > > drivers/net/ice/ice_fdir_filter.c | 110 ++++----- > > drivers/net/ice/ice_generic_flow.h | 1 + > > drivers/net/ice/ice_hash.c | 192 ++++++--------- > > drivers/net/ice/ice_switch_filter.c | 348 > > ++++++++++------------------ > > 4 files changed, 231 insertions(+), 420 deletions(-) > > > > diff --git a/drivers/net/ice/ice_fdir_filter.c > > b/drivers/net/ice/ice_fdir_filter.c > > index 1f2576a444..76e0a8df38 100644 > > --- a/drivers/net/ice/ice_fdir_filter.c > > +++ b/drivers/net/ice/ice_fdir_filter.c > > @@ -55,92 +55,74 @@ > > >=20 > ... > > + {pattern_eth_ipv4, ICE_INSET_NONE, > ICE_FDIR_INSET_ETH_IPV4, ICE_INSET_NONE}, > > + {pattern_eth_ipv4_udp, > ICE_INSET_NONE, ICE_FDIR_INSET_ETH_IPV4_UDP, > ICE_INSET_NONE}, > > + {pattern_eth_ipv4_tcp, > ICE_INSET_NONE, > ICE_FDIR_INSET_ETH_IPV4_TCP, ICE_INSET_NONE}, > > + {pattern_eth_ipv4_sctp, > ICE_INSET_NONE, ICE_FDIR_INSET_ETH_IPV4_SCTP, > ICE_INSET_NONE}, > > + {pattern_eth_ipv6, ICE_INSET_NONE, > ICE_FDIR_INSET_ETH_IPV6, ICE_INSET_NONE}, > > + {pattern_eth_ipv6_udp, > ICE_INSET_NONE, ICE_FDIR_INSET_ETH_IPV6_UDP, > ICE_INSET_NONE}, > > + {pattern_eth_ipv6_tcp, > ICE_INSET_NONE, > ICE_FDIR_INSET_ETH_IPV6_TCP, ICE_INSET_NONE}, > > + {pattern_eth_ipv6_sctp, > ICE_INSET_NONE, ICE_FDIR_INSET_ETH_IPV6_SCTP, > ICE_INSET_NONE}, > > + {pattern_eth_ipv4_udp_vxlan_ipv4, ICE_INSET_NONE, > ICE_FDIR_INSET_VXLAN_IPV4_L, > ICE_INSET_NONE}, > > + {pattern_eth_ipv4_udp_vxlan_ipv4_udp, > ICE_INSET_NONE, ICE_FDIR_INSET_VXLAN_IPV4_UDP_L, > ICE_INSET_NONE}, > > + {pattern_eth_ipv4_udp_vxlan_ipv4_tcp, > ICE_INSET_NONE, ICE_FDIR_INSET_VXLAN_IPV4_TCP_L, > ICE_INSET_NONE}, > > + {pattern_eth_ipv4_udp_vxlan_ipv4_sctp, > ICE_INSET_NONE, ICE_FDIR_INSET_VXLAN_IPV4_SCTP_L, > ICE_INSET_NONE}, > > + {pattern_eth_ipv4_udp_vxlan_eth_ipv4, > ICE_INSET_NONE, > ICE_FDIR_INSET_VXLAN_IPV4_L, ICE_INSET_NONE}, > > + {pattern_eth_ipv4_udp_vxlan_eth_ipv4_udp, ICE_INSET_NONE, > ICE_FDIR_INSET_VXLAN_IPV4_UDP_L, > ICE_INSET_NONE}, > > + {pattern_eth_ipv4_udp_vxlan_eth_ipv4_tcp, ICE_INSET_NONE, > ICE_FDIR_INSET_VXLAN_IPV4_TCP_L, > ICE_INSET_NONE}, > > + {pattern_eth_ipv4_udp_vxlan_eth_ipv4_sctp, ICE_INSET_NONE, > ICE_FDIR_INSET_VXLAN_IPV4_SCTP_L, > ICE_INSET_NONE}, > > }; > > >=20 > [Cao, Yahui] Why is the mask put in the 3rd column instead of 2nd column = ? I > prefer the way that 2nd column is for outer field and 3rd column is for i= nner > field. Both are OK. But for my way, the 2nd column is only for tunnel outer. The 3= rd can be reused by non-tunnel and tunnel inner part. I will redefine the macr= o. > > > > static int > > -- > > 2.25.1