From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E75CA09FF; Tue, 29 Dec 2020 14:29:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 25A392B92; Tue, 29 Dec 2020 14:29:45 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id CF82C2B91 for ; Tue, 29 Dec 2020 14:29:43 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BTDQYXN026248; Tue, 29 Dec 2020 05:29:41 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pfpt0220; bh=6rATCRJlAhsjjhD0g2KxYZOIL4+qH65cyqO1Gjymhms=; b=fB/uzdLEHHdhyaZEXtO7KhPeIKctnpwHDXIY70C732B6+zHUG6rKr7h+QWZ6WvUesqaL EspXZM0oCA47W+hdNOZ6t6EGlZLF7XLvSlk1rzN7a+k0zeasU3RyTvATo4hk//oiDQWc JBYEvlleg3VaHREg60sAQBKM/cCxKdrGsWTD5pV/i3ho210DcN2Uks6AiSsXBy8S7v2J nCEWNImCCDZuHAzJUVutvYuBE0IfrMNqyTY0pZH5DGsDruXXNfcXim/52DehlBBgD24q B1fjEoDhKe46Mm6bVSz9y4F5CFGew30GoS60RDgDO9I5FhWCjFbfcl8eZ4QfWAtS121f AA== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com with ESMTP id 35p5jtnfxp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 29 Dec 2020 05:29:41 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 29 Dec 2020 05:29:39 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 29 Dec 2020 05:29:39 -0800 Received: from [10.193.38.82] (unknown [10.193.38.82]) by maili.marvell.com (Postfix) with ESMTP id 31A0B3F703F; Tue, 29 Dec 2020 05:29:38 -0800 (PST) To: Balazs Nemeth , , Devendra Singh Rawat , Rasesh Mody References: From: Igor Russkikh Message-ID: <8a90fc3e-31dd-2792-0dee-7c86523f2245@marvell.com> Date: Tue, 29 Dec 2020 14:29:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:84.0) Gecko/20100101 Thunderbird/84.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-29_09:2020-12-28, 2020-12-29 signatures=0 Subject: Re: [dpdk-dev] Potential regression introduced by commit b10231aed1edb9 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Balazs, This could be a regression for your specific usecase. The commit itself tried to fix promisc as is. Adding more people to comment/investigate here. Devendra, could it be that we don't consider subsequent calls of promisc_enabled + allmulti_enable ? On 18/12/2020 2:34 pm, Balazs Nemeth wrote: > Hi, > > Commit b10231aed1edb9 introduces a regression on my systems. I have a > "QLogic Corp. FastLinQ QL41000 Series 10/25/40/50GbE Controller" which > relies on the qede driver. Calling rte_eth_promiscuous_enable(portid) > followed by rte_eth_allmulticast_enable(port_id) causes no packets to > arrive from my generator. It's important to add that the generator > doesn't specifically target the mac of the port. I presume that > irrespective of dst mac, if a port is put into promiscuous mode, all > packets should arrive and rte_eth_allmulticast_enable should not cause > *less* packets to arrive. Am I missing something? It seems that > b10231aed1edb9 inadvertently introduced either a bug or a pretty > significant change in semantics (at least for qede)? > > Regards, > Balazs >