From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCC0FA054A; Tue, 25 Oct 2022 11:49:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD71F427FF; Tue, 25 Oct 2022 11:49:55 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 6608241143 for ; Tue, 25 Oct 2022 11:49:54 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 668225E; Tue, 25 Oct 2022 12:49:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 668225E DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1666691393; bh=H9WNTb1zHGSAauXb44oc7teZpOneqOYsOqanUa14kdM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=C09EoFiI7bgOfQWewAwd2Bgdpu3ONe+6iC+cUv1OkL0MhJakULdE1DJNiPCicFPZl gH5pJGHtL+Q9uUvn+TZR4SjblLtomy6a6iv/ppOomvRwSNaw2eQlfgxaquC67RKaqL KGDQ+WREOLjoLPaactIPsx4+g+BFwgWJCrorcvTc= Message-ID: <8a91a821-c40d-24cf-1912-6ba4607c081c@oktetlabs.ru> Date: Tue, 25 Oct 2022 12:49:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v11 05/18] net/idpf: add support for device start and stop Content-Language: en-US To: Junfeng Guo , qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, Xiaoyun Li References: <20221024130134.1046536-2-junfeng.guo@intel.com> <20221024131227.1062446-1-junfeng.guo@intel.com> <20221024131227.1062446-6-junfeng.guo@intel.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20221024131227.1062446-6-junfeng.guo@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/24/22 16:12, Junfeng Guo wrote: > Add dev ops dev_start, dev_stop and link_update. > > Signed-off-by: Beilei Xing > Signed-off-by: Xiaoyun Li > Signed-off-by: Junfeng Guo > --- > drivers/net/idpf/idpf_ethdev.c | 89 ++++++++++++++++++++++++++++++++++ > drivers/net/idpf/idpf_ethdev.h | 5 ++ > 2 files changed, 94 insertions(+) > > diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c > index 1d2075f466..4c7a2d0748 100644 > --- a/drivers/net/idpf/idpf_ethdev.c > +++ b/drivers/net/idpf/idpf_ethdev.c > @@ -29,17 +29,42 @@ static const char * const idpf_valid_args[] = { > }; > > static int idpf_dev_configure(struct rte_eth_dev *dev); > +static int idpf_dev_start(struct rte_eth_dev *dev); > +static int idpf_dev_stop(struct rte_eth_dev *dev); > static int idpf_dev_close(struct rte_eth_dev *dev); > static int idpf_dev_info_get(struct rte_eth_dev *dev, > struct rte_eth_dev_info *dev_info); > static void idpf_adapter_rel(struct idpf_adapter *adapter); > > +int > +idpf_dev_link_update(struct rte_eth_dev *dev, > + __rte_unused int wait_to_complete) Why is it global? IMHO it should be static now and should be made global later if you really need it. > +{ > + struct idpf_vport *vport = dev->data->dev_private; > + struct rte_eth_link new_link; > + > + memset(&new_link, 0, sizeof(new_link)); > + > + new_link.link_speed = RTE_ETH_SPEED_NUM_NONE; > + > + new_link.link_duplex = RTE_ETH_LINK_FULL_DUPLEX; > + new_link.link_status = vport->link_up ? RTE_ETH_LINK_UP : > + RTE_ETH_LINK_DOWN; > + new_link.link_autoneg = !(dev->data->dev_conf.link_speeds & > + RTE_ETH_LINK_SPEED_FIXED); > + > + return rte_eth_linkstatus_set(dev, &new_link); > +} > + > static const struct eth_dev_ops idpf_eth_dev_ops = { > .dev_configure = idpf_dev_configure, > + .dev_start = idpf_dev_start, > + .dev_stop = idpf_dev_stop, > .dev_close = idpf_dev_close, > .rx_queue_setup = idpf_rx_queue_setup, > .tx_queue_setup = idpf_tx_queue_setup, > .dev_infos_get = idpf_dev_info_get, > + .link_update = idpf_dev_link_update, > }; > > static int > @@ -233,6 +258,70 @@ idpf_dev_configure(struct rte_eth_dev *dev) > return 0; > } > > +static int > +idpf_start_queues(struct rte_eth_dev *dev) > +{ > + struct idpf_rx_queue *rxq; > + struct idpf_tx_queue *txq; > + int err = 0; > + int i; > + > + for (i = 0; i < dev->data->nb_tx_queues; i++) { > + txq = dev->data->tx_queues[i]; > + if (txq == NULL || txq->tx_deferred_start) > + continue; > + > + PMD_DRV_LOG(ERR, "Start Tx queues not supported yet"); > + return -ENOTSUP; > + } > + > + for (i = 0; i < dev->data->nb_rx_queues; i++) { > + rxq = dev->data->rx_queues[i]; > + if (rxq == NULL || rxq->rx_deferred_start) > + continue; > + > + PMD_DRV_LOG(ERR, "Start Rx queues not supported yet"); > + return -ENOTSUP; > + } > + > + return err; > +} > + > +static int > +idpf_dev_start(struct rte_eth_dev *dev) > +{ > + struct idpf_vport *vport = dev->data->dev_private; > + > + if (dev->data->mtu > vport->max_mtu) { > + PMD_DRV_LOG(ERR, "MTU should be less than %d", vport->max_mtu); > + return -1; > + } > + > + vport->max_pkt_len = dev->data->mtu + IDPF_ETH_OVERHEAD; > + > + if (idpf_start_queues(dev) != 0) { > + PMD_DRV_LOG(ERR, "Failed to start queues"); > + return -1; > + } > + > + if (idpf_vc_ena_dis_vport(vport, true) != 0) { > + PMD_DRV_LOG(ERR, "Failed to enable vport"); Don't you need to stop queues here? > + return -1; > + } > + > + return 0; > +} > + > +static int > +idpf_dev_stop(struct rte_eth_dev *dev) > +{ > + struct idpf_vport *vport = dev->data->dev_private; Stop queues? > + > + idpf_vc_ena_dis_vport(vport, false); > + > + return 0; > +} > + > static int > idpf_dev_close(struct rte_eth_dev *dev) > { > diff --git a/drivers/net/idpf/idpf_ethdev.h b/drivers/net/idpf/idpf_ethdev.h > index c0ae801fd5..070531cc48 100644 > --- a/drivers/net/idpf/idpf_ethdev.h > +++ b/drivers/net/idpf/idpf_ethdev.h > @@ -105,6 +105,9 @@ struct idpf_vport { > /* Chunk info */ > struct idpf_chunks_info chunks_info; > > + /* Event from ipf */ > + bool link_up; > + It is a dead code. Since it is read, but never written in the patch. > uint16_t devarg_id; > }; > > @@ -195,6 +198,8 @@ atomic_set_cmd(struct idpf_adapter *adapter, enum virtchnl_ops ops) > } > > struct idpf_adapter *idpf_find_adapter(struct rte_pci_device *pci_dev); > +int idpf_dev_link_update(struct rte_eth_dev *dev, > + __rte_unused int wait_to_complete); > void idpf_handle_virtchnl_msg(struct rte_eth_dev *dev); > int idpf_vc_check_api_version(struct idpf_adapter *adapter); > int idpf_vc_get_caps(struct idpf_adapter *adapter);