From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE9C241E2F; Thu, 9 Mar 2023 05:51:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F9A5410EE; Thu, 9 Mar 2023 05:51:57 +0100 (CET) Received: from corp-ob10.yahoo-corp.jp (corp-ob10.yahoo-corp.jp [182.22.125.210]) by mails.dpdk.org (Postfix) with ESMTP id 78E6540ED7 for ; Thu, 9 Mar 2023 05:51:54 +0100 (CET) Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01lp2108.outbound.protection.outlook.com [104.47.23.108]) by corp-ob10.yahoo-corp.jp (Postfix) with ESMTPS id DC9F319FB183; Thu, 9 Mar 2023 13:51:52 +0900 (JST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HJNRUYS4RFMYkg7EuCfwlHTX5L5CFSpQZak8H9lFAGmI51+p3Az74i++fwPHO7AQWdeclQdwSju7aKzQu6lk8Ex//G/Rvr+0+akD+wLD++n+XzoZsTdKHbaEPtoxgSILeSo1yzWZoyPMM2QCjmJnFqtwtIiTm4IuvmCIztjCiALBbj1sWgdH0VI4lCC2VtpUuLZTEgwxAhRyn77KmkyWOMD0s2bYTfTs933RtodHd3aIG0JgvZ7vr6MsBwpP17edo+hgvacfnzaETfkymXK3wfWhvN3tUc2yUILGaJRsHtLirE3xp22hoE35gQwxZD986XD0X151wYcf0k8AF7F4BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/UU+RuEwouQorFfhCNLTfcBsdE6RWGXbP/6L98Q6qUk=; b=OVkTUyEmOVkxdzKBjV9JQqwJzRrrQFB9WabOjGgrVYpqUOgPMSWLQ2YcJB+YYUVg0P++EpQBI0j2BTqLvifroyf8GYUaDQ/aA2b9/0Wb8wIPmV66TfJznJg0fawYIadOeBtdpc3S77TCV3Z09GTU4HpR1GCO/5bmRLisNqjOUyyfxGbddlZxxPa9mtMscyYCUzBdjn9Q85PSYOzLd5i9jMScZFH+BiiflauW4A8kYlYj8Fa84XCWqYBxzNIzS+NFGZcYCscqYz3Eb0JaJaqAwEVz9g3wfTRnqOuqQwwq+SeFAjt8P2EuJjjSQmXAuOytxQmtJ4ncBuY6YZVsHFKtpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=yahoo-corp.jp; dmarc=pass action=none header.from=yahoo-corp.jp; dkim=pass header.d=yahoo-corp.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo-corp.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/UU+RuEwouQorFfhCNLTfcBsdE6RWGXbP/6L98Q6qUk=; b=Ex1aieA9f9TT9s0SOclP0c7G8z0+jpxSoAmhfAeM8T54JTk2Yz1pHdIaU3lPwILCzRpD4zd35BXWMGvQKO0MXB3qLRX21HJSxf7ipt0gb46RzqHoWhUmUoM7FkAjM0SbrrlUEjS55/XZKJeRv5x6ykuTNfklMtez2FCfBeQf8rk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=yahoo-corp.jp; Received: from TY2PR01MB4107.jpnprd01.prod.outlook.com (2603:1096:404:d8::23) by TYCPR01MB9506.jpnprd01.prod.outlook.com (2603:1096:400:192::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.29; Thu, 9 Mar 2023 04:51:51 +0000 Received: from TY2PR01MB4107.jpnprd01.prod.outlook.com ([fe80::61fe:e4c3:a819:6ce6]) by TY2PR01MB4107.jpnprd01.prod.outlook.com ([fe80::61fe:e4c3:a819:6ce6%7]) with mapi id 15.20.6178.019; Thu, 9 Mar 2023 04:51:51 +0000 Message-ID: <8aacfc34-667d-57d5-844f-fc6f0b7268f2@yahoo-corp.jp> Date: Thu, 9 Mar 2023 13:51:49 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/2] vhost: refactor to follow new naming convention To: "Xia, Chenbo" , "maxime.coquelin@redhat.com" Cc: "dev@dpdk.org" References: <20230309020721.22164-1-nmiki@yahoo-corp.jp> <20230309020721.22164-3-nmiki@yahoo-corp.jp> Content-Language: en-US From: Nobuhiro MIKI In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: TYCP286CA0047.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:2b5::18) To TY2PR01MB4107.jpnprd01.prod.outlook.com (2603:1096:404:d8::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY2PR01MB4107:EE_|TYCPR01MB9506:EE_ X-MS-Office365-Filtering-Correlation-Id: 57205abe-1346-4670-447a-08db2059ff29 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vzdzuSGqfX/cr81MryVMBoM6Lgkkz/F1w59ZRniI5Wgy1XfuqV2XUhnqykalXJM+j5NxXVcENhCb/NHw4KtxeLkiQa8Kh+URFSK0kmPyZ6yUv4ku4bMnzK2pwjxNC7RIFGlkZZWTK62veEAyynvQxuDzEOhxn2lhmjMcXP1zKPpF+4i14cAnYxXPE1C2HYrcTCHfZ1DlPGM3UfF3lOrdOlaR99NvKnuaXmqVwP9/aBS5LJPIKoUz0GQCNQJ1yqVy3lyxoH2X8uZqKlVJpgoBs/oRKAVdbe6LH23y09+b5YZfM5J61oSU5ab4vpKFLLwW5qIyoBOUZ71NuQ5z32vVoWZByJL/abGY04XStrfhiJ3eTvZy8LnVLluPL1gJE3BROrosdgl4dmpb8Oj2ZwJK0ueFUkLWeF7gdJ6gasB4PWB2PX8T8JhCyeBjIiWBJA09Nc8Q4ERYzhDWl17JJYUKSwP0Y07diXwV1v7YOS+Y6QTjVU8DFCqBreJdQJNqPmCltGgShWsLnot+9ULYDlFyIf8C2i2hr7aYwL+PHT6w/3eyEO+TZV+/HfkR1/rvSvKCzJ9BnFrVb+3vZ+xts+jje+5HAh0PXaWT52Vt0bg0MLkdon+IIJX91LVDP+AbmuTgDg7YE954l2kbYlWi+LISpmDzTfbcwT9/SZ6IH90aoXzIgYt+RWvmYlRdO8e8UoG7L/XUcvwgDxlL6L4BrRQTdNsYPtQnKeln3UJ5awaUg5Qkb0uzHFfrS45fi2GC+yTIDN5ZKfHqkI0R/N4RLTvVQQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TY2PR01MB4107.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(396003)(346002)(39860400002)(366004)(376002)(451199018)(316002)(66946007)(66476007)(4326008)(66556008)(8676002)(83380400001)(186003)(2616005)(86362001)(31696002)(38100700002)(38350700002)(36756003)(82960400001)(26005)(110136005)(478600001)(6506007)(53546011)(6486002)(52116002)(6512007)(2906002)(8936002)(5660300002)(31686004)(41300700001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tkl0SGxOUlA1UlBhS3JWWWV4TXVnY0tsUC9JcHBTTjJWTTRSY0NsYzNOSEdt?= =?utf-8?B?dHBmR2ROcUdMZ0hrdDYxUEpJRTRVVVFuSXRFL3JQOFE2MG9BbHJwSTU3MFZX?= =?utf-8?B?THN0Um1jWUFPcUcwa0w3NGZhckNDWkxuamhyZTlrdnMya2tVbFcvR0JFV1B0?= =?utf-8?B?T0prS0VmWHVub05OMTBmUGlibWh3cVNEQnJhTEJNNS9ybnhvd1NpeVFXNkVl?= =?utf-8?B?TW1BSWJQT0dFZ3RyZ1JxbXpEckZSd1JQUmJDVTJhWXpIUm1vMWYwQTh2QVlm?= =?utf-8?B?SmFKcmJmQjRDbG1EWVJ3dytnK2ZLbnowaFk1RWVmeDArVEloVkpNSkVYVUFx?= =?utf-8?B?OTRZUFpJVkxvOEYvQTlqTk5wQ25UNkVXRG1FT1Q3U2RBRmFFS3Z5OFV5SmFt?= =?utf-8?B?NDZZOUNtWnZUeHZMV3RKM3VuSTFpSkh6SkhaeVE4MGtPOFhpSDFPbHduVk9K?= =?utf-8?B?dkZzeW0xTkhDdXhQMWg4S3h2NThyb2pVa213Z28wYjNtZVV5eFgyNGxrMG9k?= =?utf-8?B?S0NXSnZhVVFtK1lhRTlUNkxCb1JTa0V0VHZyYjNRV0Q0TzRTUWcvRXpsMW9v?= =?utf-8?B?OUJBMm9FSCtvT01IcHhnMUprUXRTMW1Yd1RPR2dOdVhMcEFkM2JIUHJTTVFJ?= =?utf-8?B?OURxK2pqNlJWeEtqSnR3MG9LTXZ2enZBTU1sdTJjb3RwekMyWmpHbjAwOTNp?= =?utf-8?B?d2FXTzNVUkI3dnNNRDJsZ2ZQYzRRblRKTlV5eGxDbVlmYkJVQWdDMVhnWmNV?= =?utf-8?B?YmxRTXpJb2l3Z1lLcjAyVmszMmcxQ2c2cHVvVUl1OUlkdzY0K3dLdlRxZkhF?= =?utf-8?B?czRLTG9MRGtvb3QzY0g1SU9GUUpLTUhqSDZOZzB4ZTBXNElvaTkrUzlnUUxQ?= =?utf-8?B?QU53NXM0L0dCd0ZoTUVxZnpmS3RUSklpakZWWC85QWtKV3cvUGZXZk0zdlJ0?= =?utf-8?B?UGxiTDRkL1dyVnowMnAvSmg1bWJzV3Y4RzVzNlJ0U0tQMW1MYlIxTzdrM1Y0?= =?utf-8?B?U08rREt4RDFBbkFTbUx1S3lkWVllcUN6WDl6dXR6K1pGZmplaVBPSjlGb1hw?= =?utf-8?B?NU03NmNrSERXSXpiYVBZdFg2S2xWeVQ1UHE1VmxLZTJtdDVkNmNpNThuZlhu?= =?utf-8?B?eEkwZlcwdDlDTEFVRjdHSFV5QkVqa0RBZzhaNWZ0NkduYjl6SUNhaEs0S2Vs?= =?utf-8?B?bENTd014aW04NjgwS3pCNnBxaE95eEcvRTFuY1E5UzR5Tjc3M3dkQkF2WGFz?= =?utf-8?B?QmFNZVlCdHJKMUlzd1lxOEZiNnRjd05yN1pEYkRSc09xZ3ptU1pqMDAwRmc5?= =?utf-8?B?NXhiTk96aXJncm9ZOE8yWThRa0E5ekQ4NnV0VUNGemVqYVZmdHhKWWxHRFFw?= =?utf-8?B?WEZKSlJLbk5kR0w1K21lVWdYOGZ3dDd4WlZvN1dyWmZNcmE1Slc2dGg0SU1m?= =?utf-8?B?SFlqT1l3SFdiSXRKY29LNTQ1N1JmL1FYcHB3YjhIa2Q4MlFVVTdyeEhMUEY3?= =?utf-8?B?eUwxZEltSnFXQkd0Z3UvMWpkMjlxVFk1Q1FlVUM4VlpQRE04bGN2aElIUHls?= =?utf-8?B?Ky9aeEYrWnpvbnRTS0c0U2NUMnVLTE1TUHBHQ2Fzd0tBc2FIQkNDd05WaStw?= =?utf-8?B?eHc0ZWF2TWNqb3U5V3ladE1SV3lZcHFJWVE4Vkc4Q05NSktpdE9kRnNCOHU3?= =?utf-8?B?NHo1TGltWmVFcDdFVHRqNTVsNktSbFA5Z0FlcHdWWFREeWszaTAyWUxlaUxY?= =?utf-8?B?SzBTQjJpTW5nT0lkcUlCRVo1Nm43YUZQa2pDNmdUNXdIbmZuSU5oZlZRaW1i?= =?utf-8?B?S1dMaTNTdlZ2WjVWb0VWbmFYNThnNGZYd09IVFdxUUhhcEUzUFB4QUtHY0hU?= =?utf-8?B?Q1N4eDBYaCs0bC9RWkpqN1FRTXZ3OUFJMmc5U1pjNFFDaU9oTVd6bE1ldzVN?= =?utf-8?B?c0RwcXJ2bVVjc0NBam5BQzZiOG9KcGtLT0MvSTRGNmZpWDRVMlNDOFVlZ2g0?= =?utf-8?B?dExWM0xpR2VPWTRCV1FKemk2Tngyb2FQcGtmVTNTbm1jSmxxU3VIdzZUanlG?= =?utf-8?B?WlZSeCtmeForVmFWdFBFTStneWVVakk4QXVXV3hBMHo4a2NjR04zeklvNkM5?= =?utf-8?Q?G/2UhDrUHT4u1SBBOQzgqqD1t?= X-OriginatorOrg: yahoo-corp.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 57205abe-1346-4670-447a-08db2059ff29 X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB4107.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 04:51:50.9536 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a208d369-cd4e-4f87-b119-98eaf31df2c3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BpHO23msxDd6mym/H6HYRn+9HCYcJqxXzv0Thnx30+vERbc2BMvQKVh2N3kpnxnhCNFhT9leLG14tgzVA4koNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB9506 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/03/09 12:03, Xia, Chenbo wrote: > Hi Nobuhiro, > > Thanks for the work, check comments inline. > >> -----Original Message----- >> From: Nobuhiro MIKI >> Sent: Thursday, March 9, 2023 10:07 AM >> To: maxime.coquelin@redhat.com; Xia, Chenbo >> Cc: dev@dpdk.org; Nobuhiro MIKI >> Subject: [PATCH 2/2] vhost: refactor to follow new naming convention >> >> Simply replace '_slave_' with '_backend_'. >> >> Signed-off-by: Nobuhiro MIKI >> --- >> drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +- >> lib/vhost/rte_vhost.h | 2 +- >> lib/vhost/version.map | 2 +- >> lib/vhost/vhost.c | 4 +-- >> lib/vhost/vhost.h | 4 +-- >> lib/vhost/vhost_user.c | 62 +++++++++++++++++------------------ >> lib/vhost/vhost_user.h | 6 ++-- >> 7 files changed, 41 insertions(+), 41 deletions(-) >> >> diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c >> index fe4d278c5380..e4133568c1aa 100644 >> --- a/drivers/vdpa/ifc/ifcvf_vdpa.c >> +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c >> @@ -605,7 +605,7 @@ virtio_interrupt_handler(struct ifcvf_internal >> *internal) > > ... > >> >> typedef struct VhostUserMemoryRegion { >> uint64_t guest_phys_addr; >> @@ -137,7 +137,7 @@ struct vhost_user_config { >> typedef struct VhostUserMsg { >> union { >> uint32_t master; /* a VhostUserRequest value */ >> - uint32_t slave; /* a VhostUserSlaveRequest value*/ >> + uint32_t backend; /* a VhostUserBackendRequest value*/ > > I think we should rename the master to front-end too (as QEMU spec says) > > If you can also replace all the 'masters' with front-end too, we will appreciate > that much.. > > BTW, I guess this is your first patch, you need to update .mailmap file with your > name and email address. Hi Chenbo, Thanks for your review. I will fix them in v2. Best Regards, Nobuhiro MIKI