From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: matan@mellanox.com, ferruh.yigit@intel.com, gaetan.rivet@6wind.com
Subject: Re: [dpdk-dev] [PATCH v3] bus/vdev: replace device list lock by a recursive one
Date: Tue, 22 May 2018 14:34:49 +0100 [thread overview]
Message-ID: <8ac95032-f1e3-d762-2cf5-803ad78bb2bb@intel.com> (raw)
In-Reply-To: <20180522113727.3116-1-thomas@monjalon.net>
On 22-May-18 12:37 PM, Thomas Monjalon wrote:
> A device like failsafe can manage sub-devices.
> When removing such device, it removes its sub-devices
> and try to take the same vdev_device_list_lock.
> It was causing a deadlock because the lock was not recursive.
>
> Fixes: 35f462839b69 ("bus/vdev: add lock on device list")
>
> Suggested-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v3: try recursive lock
> WARNING: not yet tested!
> ---
LGTM
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-05-22 13:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 16:11 [dpdk-dev] [PATCH] bus/vdev: reduce scope of device list lock Thomas Monjalon
2018-05-21 16:45 ` [dpdk-dev] [PATCH v2] bus/vdev: fix " Thomas Monjalon
2018-05-21 17:28 ` Matan Azrad
2018-05-22 9:11 ` Gaëtan Rivet
2018-05-22 9:05 ` [dpdk-dev] [PATCH] bus/vdev: reduce " Burakov, Anatoly
2018-05-22 9:20 ` Thomas Monjalon
2018-05-22 11:37 ` [dpdk-dev] [PATCH v3] bus/vdev: replace device list lock by a recursive one Thomas Monjalon
2018-05-22 12:08 ` Matan Azrad
2018-05-22 13:34 ` Burakov, Anatoly [this message]
2018-05-22 14:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ac95032-f1e3-d762-2cf5-803ad78bb2bb@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=matan@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).