From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2C2382BD8 for ; Tue, 22 May 2018 15:34:55 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2018 06:34:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,430,1520924400"; d="scan'208";a="226320468" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.101]) ([10.237.220.101]) by orsmga005.jf.intel.com with ESMTP; 22 May 2018 06:34:51 -0700 To: Thomas Monjalon , dev@dpdk.org Cc: matan@mellanox.com, ferruh.yigit@intel.com, gaetan.rivet@6wind.com References: <2833093.uzJjkH71XI@xps> <20180522113727.3116-1-thomas@monjalon.net> From: "Burakov, Anatoly" Message-ID: <8ac95032-f1e3-d762-2cf5-803ad78bb2bb@intel.com> Date: Tue, 22 May 2018 14:34:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180522113727.3116-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] bus/vdev: replace device list lock by a recursive one X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 13:34:55 -0000 On 22-May-18 12:37 PM, Thomas Monjalon wrote: > A device like failsafe can manage sub-devices. > When removing such device, it removes its sub-devices > and try to take the same vdev_device_list_lock. > It was causing a deadlock because the lock was not recursive. > > Fixes: 35f462839b69 ("bus/vdev: add lock on device list") > > Suggested-by: Anatoly Burakov > Signed-off-by: Thomas Monjalon > --- > v3: try recursive lock > WARNING: not yet tested! > --- LGTM Acked-by: Anatoly Burakov -- Thanks, Anatoly