From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 45EF7271 for ; Tue, 19 Dec 2017 00:08:08 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2017 15:08:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,423,1508828400"; d="scan'208";a="12893854" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.254]) ([10.241.224.254]) by FMSMGA003.fm.intel.com with ESMTP; 18 Dec 2017 15:08:07 -0800 To: Stephen Hemminger Cc: Thomas Monjalon , dev@dpdk.org References: <20171218210658.37740-1-ferruh.yigit@intel.com> <20171218141317.502efa2f@xeon-e3> From: Ferruh Yigit Message-ID: <8acb43f9-0399-aacb-2898-b4ec06d546ca@intel.com> Date: Mon, 18 Dec 2017 15:08:06 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171218141317.502efa2f@xeon-e3> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] igb_uio: convert license headers to SPDX tags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 23:08:09 -0000 On 12/18/2017 2:13 PM, Stephen Hemminger wrote: > On Mon, 18 Dec 2017 21:06:58 +0000 > Ferruh Yigit wrote: > >> diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >> index a3a98c173..d0e4fd966 100644 >> --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >> +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >> @@ -1,25 +1,6 @@ >> /*- >> - * GPL LICENSE SUMMARY >> - * >> - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. >> - * >> - * This program is free software; you can redistribute it and/or modify >> - * it under the terms of version 2 of the GNU General Public License as >> - * published by the Free Software Foundation. >> - * >> - * This program is distributed in the hope that it will be useful, but >> - * WITHOUT ANY WARRANTY; without even the implied warranty of >> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> - * General Public License for more details. >> - * >> - * You should have received a copy of the GNU General Public License >> - * along with this program; if not, write to the Free Software >> - * Foundation, Inc., 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA. >> - * The full GNU General Public License is included in this distribution >> - * in the file called LICENSE.GPL. >> - * >> - * Contact Information: >> - * Intel Corporation >> + * SPDX-License-Identifier: GPL-2.0 >> + * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. >> */ >> >> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > SPDX looks better, and since this is a kernel file it should follow > the Linux kernel standard. > > // SPDX-License-Identifier: GPL-2.0 > /* > * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. > */ OK, I will update. Is there any benefit of following Linux kernel standard not only for kernel modules but for all DPDK files? > > You might also want to do the update of year as well. >