From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90C08A0562; Tue, 23 Mar 2021 10:58:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77FD44014D; Tue, 23 Mar 2021 10:58:46 +0100 (CET) Received: from dal3relay210.mxroute.com (dal3relay210.mxroute.com [64.40.27.210]) by mails.dpdk.org (Postfix) with ESMTP id 6441640143 for ; Tue, 23 Mar 2021 10:58:45 +0100 (CET) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by dal3relay210.mxroute.com (ZoneMTA) with ESMTPSA id 1785e85a702000362f.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 23 Mar 2021 09:58:40 +0000 X-Zone-Loop: 65d8412b5a09c0f1442ec0b5d620dbeb0556a8e32f47 X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=W0KeODvYQRhU/NMUBjzhCKm6ihm7lJyBxGI8CMbkJsE=; b=ojJGSzfqSVwy8p0MuYcr7zak6B LIa7vGDbucZHDBZrvSxRNe+k7Ade4iYaGH2GMhjkwHf/7ow/t+Z3cpOBf86I5jHdhjcixhCLnhk+y JT5dqJkFL2TkK8YXCk6vFIox6jWWBSHdXesD0in7bvmLCOJGLfdHeAhrCC4sJ4g34ZDqfreQcpg1D FjsOv6NbjhllYNDk7urQZRF1y0S8xc3qWJYm+D9BzZRMaM7AnGA6O8CDbsX1uokEyh55qUXPkL0kj BBxj7+Ym/wMO8iZ8lwK5lXwLP6kEHX1GE1e+WyxTfG+aiNRNZztf06fnR21xSIN87MOAsFVwdPHsn pebkOsew==; To: Dmitry Kozlyuk Cc: Xueming Li , dev@dpdk.org, Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Neil Horman References: <20210316124520.19726-1-xuemingl@nvidia.com> <20210323023239.2687be4e@sovereign> <2fbc5945-4f00-3104-f490-2d8d87d78fc9@ashroe.eu> <9acf308d-c73f-2063-5b6d-3fb4fc601c76@ashroe.eu> <20210323125735.0e5c243d@sovereign> From: "Kinsella, Ray" Message-ID: <8ae67994-0410-214f-b033-d60b9b681505@ashroe.eu> Date: Tue, 23 Mar 2021 09:58:36 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210323125735.0e5c243d@sovereign> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH] eal: update all buses default scan mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 23/03/2021 09:57, Dmitry Kozlyuk wrote: > 2021-03-23 09:34 (UTC+0000), Kinsella, Ray: >> On 23/03/2021 09:33, Kinsella, Ray wrote: >>> >>> >>> On 22/03/2021 23:32, Dmitry Kozlyuk wrote: >>>> 2021-03-16 20:45 (UTC+0800), Xueming Li: >>>> [...] >> [SNIP] >>>>> rte_mem_page_size; >>>> >>>> New function is private to EAL, so it doesn't need exporting. >>>> >>> >>> Right - it is annotated as INTERNAL. >>> >> >> Sorry, let me be clearer - it is being correctly annotated unless I have missed something. > > This function is purely internal to librte_eal. It doesn't need to be added > to .map or .def. It also doesn't need __rte_internal, like other functions in > eal_private.h don't need it either. > ok - I get you now - agreed.