From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3635DA0A0C; Mon, 28 Jun 2021 16:22:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1BC374069F; Mon, 28 Jun 2021 16:22:19 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 178B540692 for ; Mon, 28 Jun 2021 16:22:17 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10029"; a="188343572" X-IronPort-AV: E=Sophos;i="5.83,306,1616482800"; d="scan'208";a="188343572" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2021 07:22:17 -0700 X-IronPort-AV: E=Sophos;i="5.83,306,1616482800"; d="scan'208";a="446588075" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.249.202]) ([10.213.249.202]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2021 07:22:15 -0700 To: David Marchand , "Lin, Xueqin" Cc: Jerin Jacob , "Peng, ZhihongX" , "Ananyev, Konstantin" , Stephen Hemminger , dpdk-dev References: <20210610051352.48493-1-zhihongx.peng@intel.com> <20210615081205.101071-1-zhihongx.peng@intel.com> From: "Burakov, Anatoly" Message-ID: <8af553e7-29e1-b46d-dc68-32efaa17c9c0@intel.com> Date: Mon, 28 Jun 2021 15:22:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC v2] porting AddressSanitizer feature to DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 18-Jun-21 10:04 AM, David Marchand wrote: > On Fri, Jun 18, 2021 at 9:49 AM Lin, Xueqin wrote: >>>> Suggest listing demo code and tool capture information for user to try if >>> tool works, also add this part into doc. >>>> >>>>> >>>>> # Also, Please update the release note for this feature. >>>> Sure, we can update the release note if code merge. >>> >>> Probably you can send v1 version next i.e change the RFC status to get >>> merged. >> >> Sure, we will send v1 patch if no obvious objection for that, hope patch could receive some ACKs and could success to merge, thanks. > > How did you test this work? > > UNH recently started testing with ASAN and it reveals leaks just in > the unit test. > > Merging these annotations will help catch more issues. > But users will hit the current issues that we must fix first. > As far as i can tell, the regular build is not affected by this patch, so no issues will be hit until someone actually runs the test. IMO it's better to merge it early to catch more issues than to gate the feature on the condition that we fix all bugs unrelated to this feature first. -- Thanks, Anatoly