From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7571C42A59; Thu, 4 May 2023 09:13:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0048C4021F; Thu, 4 May 2023 09:13:33 +0200 (CEST) Received: from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80]) by mails.dpdk.org (Postfix) with ESMTP id 0F66A40141 for ; Thu, 4 May 2023 09:13:33 +0200 (CEST) Received: from [192.168.2.238] (unknown [37.252.90.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by agw.arknetworks.am (Postfix) with ESMTPSA id 2E661E02F1; Thu, 4 May 2023 11:13:32 +0400 (+04) Message-ID: <8b00ea5e-cb12-0f21-61a4-26961dc86ff8@arknetworks.am> Date: Thu, 4 May 2023 11:13:30 +0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC Content-Language: en-GB To: Ferruh Yigit , dev@dpdk.org Cc: Ivan Malov , Viacheslav Galaktionov , Thomas Monjalon , Andrew Rybchenko References: <20230428102728.51956-1-denis.pryazhennikov@arknetworks.am> <20230428102728.51956-4-denis.pryazhennikov@arknetworks.am> From: Denis Pryazhennikov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org I think my patch isn't correct. I would say that - fec_capa is a set of bits produced by 'RTE_ETH_FEC_MODE_TO_CAPA()'; - fec_mode is an element of 'enum rte_eth_fec_mode'. Based on this definition, replacing 'fec_capa' with 'fec_mode' should involve changing the parameter type. Probably I shouldn't change the name, but I should add a more detailed comment. > Independent from being single FEC mode or not, I think both 'rte_eth_fec_get()' & 'rte_eth_fec_set()' should get 'fec_mode' as param, what do you think? Andrew Rybchenko asked to replace 'mode' with 'fec_capa' for 'rte_eth_fec_set()' in https://inbox.dpdk.org/dev/aa745bd1-a564-fa8c-c77b-2d99c97690aa@solarflare.com/ I don't think we need to change it for rte_eth_fec_set(). On 5/2/23 7:02 PM, Ferruh Yigit wrote: > On 4/28/2023 11:27 AM, Denis Pryazhennikov wrote: >> Only one valid FEC mode can be get by rte_eth_fec_get(). >> The previous name implied that more than one FEC mode >> can be obtained. > +1 and patch looks good. > > But isn't this valid for 'rte_eth_fec_set()', it gets 'fec_mode'. FEC > capability has its own type "struct rte_eth_fec_capa". > > Independent from being single FEC mode or not, I think both > 'rte_eth_fec_get()' & 'rte_eth_fec_set()' should get 'fec_mode' as > param, what do you think? > >> Documentation was updated accordingly. >> >> Signed-off-by: Denis Pryazhennikov >> Acked-by: Ivan Malov >> Acked-by: Viacheslav Galaktionov > <...> >