From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Kumara Parameshwaran <kumaraparamesh92@gmail.com>, <dev@dpdk.org>
Cc: Kumara Parameshwaran <kparameshwar@vmware.com>, <stable@dpdk.org>
Subject: Re: [PATCH v2] net/tap: fix to populate fds in secondary process
Date: Mon, 24 Jan 2022 13:06:57 +0000 [thread overview]
Message-ID: <8b0b9d3d-ddc5-be2c-c47d-d184c7dac39d@intel.com> (raw)
In-Reply-To: <20220124123743.70471-1-kumaraparamesh92@gmail.com>
On 1/24/2022 12:37 PM, Kumara Parameshwaran wrote:
> From: Kumara Parameshwaran<kparameshwar@vmware.com>
>
> When a tap device is hotplugged to primary process which in turn
> adds the device to all secondary process, the secondary process
> does a tap_mp_attach_queues, but the fds are not populated in
> the primary during the probe they are populated during the queue_setup,
> added a fix to sync the queues during rte_eth_dev_start
>
> Fixes: 4852aa8f6e21 ("drivers/net: enable hotplug on secondary process")
> Cc:stable@dpdk.org
>
> Signed-off-by: Kumara Parameshwaran<kparameshwar@vmware.com>
Should this be v3?
Can you please accumulate change longs, and increase versions as it progress?
And there were more comments in v2, like splitting the patch, can you please
check them all?
Thanks,
ferruh
next prev parent reply other threads:[~2022-01-24 13:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 4:29 [PATCH] net/tap: Bug " Kumara Parameshwaran
2022-01-24 9:47 ` Ferruh Yigit
2022-01-24 12:12 ` [PATCH v2] net/tap: " Kumara Parameshwaran
2022-01-24 12:35 ` Ferruh Yigit
2022-01-24 12:48 ` Kumara Parameshwaran
2022-01-24 12:54 ` kumaraparameshwaran rathinavel
2022-01-24 13:05 ` Ferruh Yigit
2022-01-28 9:55 ` kumaraparameshwaran rathinavel
2022-01-28 12:55 ` Ferruh Yigit
2022-01-24 12:37 ` Kumara Parameshwaran
2022-01-24 13:06 ` Ferruh Yigit [this message]
2022-01-31 14:21 ` [PATCH v3 1/2] ethdev: define a function to get eth dev structure Kumara Parameshwaran
2022-01-31 14:21 ` [PATCH v3 2/2] net/tap: fix to populate fds in secondary process Kumara Parameshwaran
2022-01-31 14:32 ` [PATCH v3 1/2] ethdev: define a function to get eth dev structure Kumara Parameshwaran
2022-01-31 14:32 ` [PATCH v3 2/2] net/tap: fix to populate fds in secondary process Kumara Parameshwaran
2022-02-01 16:57 ` Ferruh Yigit
2022-02-01 16:56 ` [PATCH v3 1/2] ethdev: define a function to get eth dev structure Ferruh Yigit
2022-02-01 17:12 ` Ferruh Yigit
2022-02-01 17:15 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b0b9d3d-ddc5-be2c-c47d-d184c7dac39d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=kparameshwar@vmware.com \
--cc=kumaraparamesh92@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).