From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4274A04A7; Mon, 24 Jan 2022 14:07:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97627427D3; Mon, 24 Jan 2022 14:07:08 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id AB2A840E0F; Mon, 24 Jan 2022 14:07:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643029627; x=1674565627; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=Y/YGXsq4p49rt8/p9LZAbgp5/xmAqPgW7dBRx4yXjjY=; b=JhnWR/ydtO+QaEM8tcR/vliw7PCZAvMzs5N7KildGjsNDkV2WsUX6feB mgmdyY4D2QrhDMtIM6Tz4cw217hZBTp9kXs7vJsGbgTlDrsURooULrStK 7N95KHZLoARCNQkM2uXGP0OkZD2JeK1Yn1WEER+oRMi7VxPpTR+kbPXjE sYDAXSej2xPLgN0Qpr+RsqembRhNIufUSF0ZokEy7t9YRAdiFPZXp92DT 7sy7bzItMLBqJ72FIBFfyJod3anKgyHmFV9Z6G/irTq69JO1NyC+l+OAo vGJBr7MG3QEMPLjOBHGSUNwjEwjMQGWFJ/kdq1HfTpiadNC8wGcb5lCOI g==; X-IronPort-AV: E=McAfee;i="6200,9189,10236"; a="270474496" X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="270474496" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2022 05:07:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="695414631" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga005.jf.intel.com with ESMTP; 24 Jan 2022 05:07:05 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 24 Jan 2022 05:07:05 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 24 Jan 2022 05:07:04 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 24 Jan 2022 05:07:04 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 24 Jan 2022 05:07:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iYjqVe0xWzNdfbfgwPhBQ9hiRHHv3LgEhQfCl1ewtl0q81vaeggAy2Z4o5qZ3fCrxthIrJx1dc9lnir77OQEItylyipNLzj5L4f/scqningKLsxEvlnFWpeYPkwC4GGSaRvJXvAz3xijoZhwde31jaSmgPlc7TdY+A5DIhwDoYuKNvxwvNMo4s04gQnHNOyoInmVv37RM5hqXVWZ+798COpjP9B4tSn0vBtz089VNqwHu/GBBrn5EOSVX+iZmXwsCBZ0fAx/NXYM4AcTqQLq37YwxWmUwtc16VSTltZ/SY99H98eey8CFwsjaUmOrRiJIjGnMQnzYSf/sesEOREVqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5AA/FyaaPuXQwjaPmyVH2R0zuwaZ17M8QCkrqcyBEtg=; b=XwVKY/v7xbpldXFT+Zc4hECBqSkyrCk3s0zH6LfQy0em/lq8VcdxeUv4WtQJyPC7cNpJIV6u5Q0KvrpazNmbFFq/1i+jZDB0tfdEB1+MGST8kQMloR9dABhV7ftZJqepyF6UXfBPeZiLIQk4Ia+Wh8e8X1Ywi+cipjKY3xKSPQzySrd/lhG+ulE+YO253yjlj7FxG0QyUkHYa99KILypJQfjaDxpoV7MiMOna6+dqahs/lUws3BLWgWAYzOAuu6eBWmNc3oJtZSRKvAaRo76NAerb0LSMThNLju5JO48pod6zCXmGT8Ind2vxJsQMIday8jYvimE/6WuswmLhRLL2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN6PR11MB4131.namprd11.prod.outlook.com (2603:10b6:405:80::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.8; Mon, 24 Jan 2022 13:07:03 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4909.017; Mon, 24 Jan 2022 13:07:03 +0000 Message-ID: <8b0b9d3d-ddc5-be2c-c47d-d184c7dac39d@intel.com> Date: Mon, 24 Jan 2022 13:06:57 +0000 Content-Language: en-US To: Kumara Parameshwaran , CC: Kumara Parameshwaran , References: <20220121042944.23929-1-kumaraparamesh92@gmail.com> <20220124123743.70471-1-kumaraparamesh92@gmail.com> From: Ferruh Yigit Subject: Re: [PATCH v2] net/tap: fix to populate fds in secondary process X-User: ferruhy In-Reply-To: <20220124123743.70471-1-kumaraparamesh92@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0080.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::20) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 193c753b-1f99-4f7b-23e6-08d9df3a69e3 X-MS-TrafficTypeDiagnostic: BN6PR11MB4131:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OmeVsAVYX3puKDVkB3ZroqwgqQRsIapumhjeq8PZpX+9aZkTNueyXb/tLgIC9Flmga9JgG3mCejruxXN+OOtf2UID6vorQ2OqTuo+Ix9yuOFwBIH5pkk9yh5HjKu7G68MmS9k1gIvglOpvL91FM1sMGYd+eFtW5wnHnqFdp1biRlShReV0+spvw1X1/QVH3N2R7Lhf77Ob+QQ+y4AybmRoSgGnZpPqJ7SKFTetMSeodqOeZ0FKRJsuZauOXYe1DnIn5m0xhvBYjOGPVBIdygoX9sIuRPb29nk+0GS2LId6JCuCQxndXmwh7h33PYjGCSXNXqb21tqrRk6jKPbzpbAJyDcIDLpy+i0t74hGpH5PakmMa3mweT5zAZqoJ+FEA0xTcjQGNLT2Aarf1F/WTF8qpj9aHdamhdWaWGON2gKWW9BwBYUCj3byrA2YcvoN7bVkFVpOtIUDA53y1zFer/zNP0gKubmXmaC/kbqgEWgCehRQSZHlnEpgKJF6Luee47t/hKxG4KC5kezCUE4LZzomCIUXwKFIPpYDqrkcY2h7TATo/FWO+rHDTtBBde0qyP+Bk5bRFeGnZBKwR06wIirtv2blEVyfBa5F/HyO9Ip0qIRkaPG9tTOG4Elv55F27Gy2zpfYuxPGU3DmTsPOJYDSRkWiOlfR1O3CsBxUCmIYTlfeGVRj8iK6OmwqNacCsbmZJ1BcHIF1ouSa/kpf/nRA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(316002)(8676002)(86362001)(8936002)(36756003)(186003)(38100700002)(26005)(6512007)(4744005)(82960400001)(2906002)(6506007)(5660300002)(2616005)(31686004)(44832011)(31696002)(6666004)(4326008)(66476007)(66556008)(66946007)(6486002)(53546011)(508600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUdRVUphZFppeithSFMwUkZnTlhTS1ZQU254SlowRVFIcEtLbkcwWXhIVE5u?= =?utf-8?B?N29ZSWljQ0EwaFN4bzNTUDNCRUNES0pEYnhTaGQ2WEZDQVhNSW1SajFvd095?= =?utf-8?B?VGZ3NmVPL2JvOW02NGlucEo4M090d2Z3cDRmK1A4S2NycXU5d1BGdXNxRktr?= =?utf-8?B?Y1dKZldUTnBXck5SWkRyQTlYUFNJMW5NTnBUbzAwdnlsbzFMeTdFNjJNbzRU?= =?utf-8?B?VEFFSXpldVBLSWNURjkraXZoRzFyOVZ1KzBuNjMyaWxNRitVaUtkVThBSy8x?= =?utf-8?B?YXNDN1ZTenFaWG85TWMycjJCeFdCMWdBNHRGVzVEYnNoQmhUeXZxUTdpTEJz?= =?utf-8?B?cEo1WVo1SE5Gc3VwaytBbGtuVWNCUGVYbmJobjFmMVBqSERFTG42VytodlBw?= =?utf-8?B?elNoYVpnVlhDS1ZKbUhZeGIzNE54VGxUL1A1aFhrcU1IaXVUcllhVW03NWI2?= =?utf-8?B?VCtNTTFvQWpINE83TjBVS0Y1MFlJQzJsMUJZOURCZzhsNitRVForNDR0MU5W?= =?utf-8?B?azhLazY5ZXhPMEFRaWZVN2ZpT2h1MWhmSFI4bzhkNHlXeWFPWmVrMDdXbG5U?= =?utf-8?B?VWNGK2VrQkYvcUw0Z2R2aVFhWXB1YkhmOCtRT1FaenBDMXRrczliUnBRSTkz?= =?utf-8?B?Z0JQd1BRVUQzU01uRHlqMm1xclZsM3hrYS9GMlJNYVAwdHJqY28veUJmZ2Zm?= =?utf-8?B?SFlraDVEdGdJRFdQckp5N25MSjZnMFNyL1AxYzJjN3pHaFVPam04SUxBYlBN?= =?utf-8?B?SEVqblF3UUdjbVZQVUFwNFhJMjZOV3J1dWNNZ0l1TWZmeGdSMEllYTJuWEJ1?= =?utf-8?B?aEViWDZEUkNoc05abU1HYWQzTFFONFJNTEFPU3VJYkxJSUFhRGhJNlFNYUdr?= =?utf-8?B?Y2ZOcnM0MS95dmtNRmw0TmNSZUl1Q1Q4bWxKUlNOYkxTbFdZRkJHODBtc2ty?= =?utf-8?B?dEZrMjRnRkpheXZEUFR5aHBmN3lqUzBVM2dTeElvYmxGNEkvUVFDd3FxQWZ0?= =?utf-8?B?eEZtUVlmWW9DamRsZHNGRndhSmhvVC9tYkhMd2RrL1k4UEh1T1RzenFqRUhP?= =?utf-8?B?L1FIQzhvR0xGeEFrYnRQLzlHaHNGQXpPRHNrZ1lTVElhcmZqbmgySFQ3bDBz?= =?utf-8?B?QWdQSWJSTndOZWVTZUx5RTkyT3N2VUt4N050d0svSDVKZy82Mkk3Z1hQWTFm?= =?utf-8?B?S0lvTnhreDNsc0hocFhBdTFJYkQwc2hMYzNhSS9YbUJYUGNRbWQ0MCszdktT?= =?utf-8?B?OVlQcTdobkNUQm5uWFFXVjNjTlErb2RyNkdMTkFML2UxR29xNnhXSlV1R3Q1?= =?utf-8?B?OVR5TnExRkxqcktFUG96aHJGNi9rc2xzampNb0VQN0VHNmR4cGdkZlAwaWlC?= =?utf-8?B?bXl3eTZVV2NRUFl6Qyt0ZldaMGVYeFh6SGZiK2VRZ2ppSTBoYTdMb2YxS1RE?= =?utf-8?B?N0Vrd1hJNXBSNkJzV1JSUUZBbzQrWEllM2MySHZFT2NmalFUQk9mSUtiM0ZD?= =?utf-8?B?Z2tOa3BPekNwREl0ZTNmQmNCSUlRS0xXWnNENVEyaXdwWXppZ0g3Q0prQjU4?= =?utf-8?B?K243WTgvcDVBczdoWGo3VmhXWk9yMlRnMTNaYjFrbklUSGN0aDVMU1RlR2Zq?= =?utf-8?B?cEI3eGxjZmFINnN5bXlWdFF4SzJ1VWFRZHVnNUlUUDNtL0hoMVRjYVVYbUpr?= =?utf-8?B?c01wNHhQZ0hYQXBLbytCVTNVc0UzU3VOZGt1S1pubTMyZFRSMllVdEdPWXhx?= =?utf-8?B?VG0waDZDeUc2Z0ZBNmVxY2tmRFpnSEhSZE03N3hMVTIzZ0dLajZVZXovZzlL?= =?utf-8?B?NWpFTzJOV2w0NTZqRk9QWjRBRy9OVWIvYWNFd3lPVGpyeVhDazBNR1l0bWVJ?= =?utf-8?B?eXZrY1B0WXUvQThhQ0FWcWVxSkVZbTM5N2FnMFRESEJlT0RRb3F4SWxkZFU3?= =?utf-8?B?VGFQSU5DTDhyNzYwMXZreG1ZZHdqYnJWSFdJRnF2eml0WUJkT3ZSZS85QTNt?= =?utf-8?B?UXZ2WTFMTnpiMkdOVXRBeWZqb1BYS1c2UTlZUGkwc3V1ckNWeUdSQ3dBNitp?= =?utf-8?B?M0RGdUtKeG1XakpwbmpDVWJiRThzYml3blA3MXQrTVE1YnlCYlJTaTRKYWRI?= =?utf-8?B?VXpsUWFEeW9SWVV3ZnF5V1haVXpzbk1PZDdSdk1yVVQwYmIyN3A4K0NuOXlq?= =?utf-8?Q?UA/7ykkzxZWXUAPmeOWAN7E=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 193c753b-1f99-4f7b-23e6-08d9df3a69e3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 13:07:02.9882 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D9Fxerg190PhCIMyB2JV1NkFIyAKCia+bcNTM5TtZWFn3qHGYchPihcasCD51DZau+WyKeAxwUi6TwtyhB+SiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4131 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/24/2022 12:37 PM, Kumara Parameshwaran wrote: > From: Kumara Parameshwaran > > When a tap device is hotplugged to primary process which in turn > adds the device to all secondary process, the secondary process > does a tap_mp_attach_queues, but the fds are not populated in > the primary during the probe they are populated during the queue_setup, > added a fix to sync the queues during rte_eth_dev_start > > Fixes: 4852aa8f6e21 ("drivers/net: enable hotplug on secondary process") > Cc:stable@dpdk.org > > Signed-off-by: Kumara Parameshwaran Should this be v3? Can you please accumulate change longs, and increase versions as it progress? And there were more comments in v2, like splitting the patch, can you please check them all? Thanks, ferruh