From: Ranjit Menon <ranjit.menon@intel.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, <dev@dpdk.org>
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Tal Shnaiderman <talshn@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2] eal/windows: detect insufficient privileges for hugepages
Date: Wed, 8 Jul 2020 15:27:28 -0700 [thread overview]
Message-ID: <8b219c6c-7ad2-6987-ce59-13316bc7c223@intel.com> (raw)
In-Reply-To: <20200708214843.3080-1-dmitry.kozliuk@gmail.com>
On 7/8/2020 2:48 PM, Dmitry Kozlyuk wrote:
> AdjustTokenPrivileges() succeeds even if no requested privileges have
> been granted; this behavior is documented. Check last error code in
> addition to return value to detect such case.
>
> Make error messages more specific and add troubleshooting hint.
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
>
> v2:
> Improve error reporting (Tal Shnaiderman).
>
> lib/librte_eal/windows/eal_hugepages.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/windows/eal_hugepages.c b/lib/librte_eal/windows/eal_hugepages.c
> index 5779cd325..7f8a7dfca 100644
> --- a/lib/librte_eal/windows/eal_hugepages.c
> +++ b/lib/librte_eal/windows/eal_hugepages.c
> @@ -41,6 +41,10 @@ hugepage_claim_privilege(void)
> goto exit;
> }
>
> + /* AdjustTokenPrivileges() may succeed with ERROR_NOT_ALL_ASSIGNED. */
> + if (GetLastError() != ERROR_SUCCESS)
> + goto exit;
> +
> ret = 0;
>
> exit:
> @@ -98,12 +102,14 @@ int
> eal_hugepage_info_init(void)
> {
> if (hugepage_claim_privilege() < 0) {
> - RTE_LOG(ERR, EAL, "Cannot claim hugepage privilege\n");
> + RTE_LOG(ERR, EAL, "Cannot claim hugepage privilege\n"
> + "Verify that large-page support privilege "
> + "is assigned to the current user\n");
> return -1;
> }
>
> if (hugepage_info_init() < 0) {
> - RTE_LOG(ERR, EAL, "Cannot get hugepage information\n");
> + RTE_LOG(ERR, EAL, "Cannot discover available hugepages\n");
> return -1;
> }
>
Acked-by: Ranjit Menon <ranjit.menon@intel.com>
next prev parent reply other threads:[~2020-07-08 22:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 20:22 [dpdk-dev] [PATCH] " Dmitry Kozlyuk
2020-07-07 23:45 ` Ranjit Menon
2020-07-08 0:20 ` Dmitry Kozlyuk
2020-07-08 6:43 ` Tal Shnaiderman
2020-07-08 7:49 ` Dmitry Kozlyuk
2020-07-08 21:48 ` [dpdk-dev] [PATCH v2] " Dmitry Kozlyuk
2020-07-08 22:27 ` Ranjit Menon [this message]
2020-07-10 21:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b219c6c-7ad2-6987-ce59-13316bc7c223@intel.com \
--to=ranjit.menon@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=talshn@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).