From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6627142A0F; Thu, 27 Apr 2023 10:51:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F103B42D2D; Thu, 27 Apr 2023 10:51:39 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2087.outbound.protection.outlook.com [40.107.102.87]) by mails.dpdk.org (Postfix) with ESMTP id 3E12142B8C for ; Thu, 27 Apr 2023 10:51:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZAoqvrFNuIcbp4cBmsG3eZsShDSUdRoeNNFdrM4iSBr4EvtYWveT3HReFbQeMXNrdD7J+yhTOXif9+Cc+Xo/airJELllmHPGC53apA2bZ93CNPPk817PQcSyKsnJiDyHyoKT8tEjY1MsNeN//dtmLqfudjpXnQ73llHe09qwDaGyl7fiLtg8qyg6Ar6rQyyo+g1VIk9RFjhyEE/MilC4n8Z6BnBiV56lJjWS2vpHoVm+6m+6m0feC9FfToF5UMMZKNIStcpGwlF6tbRRWAw5xOJ1fy4uNcCYqLzBBLzD1YEcmnAQ0Yns6iQdZEkc1POB9eaKOEzGhSwckcN7qcZVQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k4nSkqF0wXyZcGTFTMtHsmJghJGo4sW4SCLVU9iu8yA=; b=I0p8M6dEmjVKrOpUDe4d7jTUh6ZkZEQX15m1xPecrT/3UFmC6PmowR/cDMm2/rAax9QlDFhqbm3D6YaowfIptbIyWRmP+sLW6zZTFEo1SiJyk859GusVnwKx1p+EwZ7tF9kESGs2+ytrsH/XvLjsWRWZMZubq7qx7jc4psdL/r3S4bjx3zX6gMzhZWSvn6rQ7qQHgHXM1RVESU+Ze3srG7G4JTMvMCWSI2zysJTxA03ZrtzcXO0PRffsBGDB6xIT9980JogUsEkg4VCHnDIjKiFschLfBM7CSqjC4CZweAYLDKEwSxBLL4HB66Z4jOe3X3bmgLraTZhqSbO7yQ7Yng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k4nSkqF0wXyZcGTFTMtHsmJghJGo4sW4SCLVU9iu8yA=; b=LhM9m/1EbeETEoaRITk9ZNhMhtKf/a6iaLM52hT+Z/Om4r7xE1hJ6RBpRYlBhvWbPZXxNob+yFCqwPHNu8HsqEJwyUY15EYMHsWLVJ0VMdjY3Mr4ViDp+hvU43sry9gRHLGRCcxiG8DJYLGkpGpUIgluQXIkmqIEnrDZWQTrsqc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB5723.namprd12.prod.outlook.com (2603:10b6:8:5e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.20; Thu, 27 Apr 2023 08:51:34 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::e818:77ea:75b5:f8cc]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::e818:77ea:75b5:f8cc%5]) with mapi id 15.20.6340.021; Thu, 27 Apr 2023 08:51:33 +0000 Message-ID: <8b65612c-e9db-95b1-4eb0-27f25383ad3a@amd.com> Date: Thu, 27 Apr 2023 09:50:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: Ronak Doshi , Jochen Behrens Cc: "dev@dpdk.org" , "Mcnamara, John" References: <20230412162636.30843-1-doshir@vmware.com> <20230412162636.30843-5-doshir@vmware.com> <900F6434-CE10-4FB7-B370-22D67D0B2F33@vmware.com> From: Ferruh Yigit Subject: Re: [PATCH next 4/7] vmxnet3: add command to set ring buffer sizes In-Reply-To: <900F6434-CE10-4FB7-B370-22D67D0B2F33@vmware.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0132.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::24) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB5723:EE_ X-MS-Office365-Filtering-Correlation-Id: cc67e051-fa34-45ff-6506-08db46fc99f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u6tEzgv2ZcgtU/r6YevNO3hIfl9GLTZawzJD6gxxhdlWANNziVvo4LQHJUabEehOmgQgQqKQZqJFQLaCCy8jGlFsasVJ4mgPYqmnbB/3qnEDRDj/oawsrVrVZVZ6GYnuejCVQUI6gu2mppEKhJhx/kTjogSFHaAHOlDdHycbqB8NVFX7Y5+Jv9yk07O8n1UpD7hs3WTjTKiaaagsgcMsFTYAuOiq3kSCA8YsLyHJcO4AE/FKqqe1Ye/sxmRHkXoqC6hGRvKoHX5CFAf283fPGv47323VLVWDkMfcNiQMeJesy5mweLYf8IUBsnDZaWXCP7L97lZSu/u3/xvFu++JEAlRXgpmiCRPB3HcDCN2RVN79z4b27VBPlSCtbJmq+Chr1h64pvPe0DW4/tgn+tzxtmpDSc00lB7rk1F6y9Zz4XoW+dWpmLzqEWBTXvURUMNjg2VU4pAFuHFkGd+aYiPwaLvhmPqm7l8PQ6ZokZwV4VTmrKadOvinrS+271vH3MSC8ZWq2jFHKs9Bi8/VbnnoRcUGaqm5CDtzZZvRkF8xeTPceb5h+PFZA9CHwnP2ZwKm+zrro4RDKM42k45o8seg40SQPyzLl6a06EEQB0PaQr3zD7W8TVcnipy4JsDsbBB21m58qogqQYCGLdLjQoibw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(136003)(39860400002)(346002)(376002)(366004)(451199021)(31686004)(19627235002)(66946007)(2616005)(316002)(4326008)(110136005)(66556008)(66476007)(478600001)(2906002)(8676002)(86362001)(8936002)(26005)(186003)(54906003)(5660300002)(41300700001)(6506007)(53546011)(6512007)(6486002)(31696002)(38100700002)(36756003)(44832011)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QW1MN1JUcVhFWFhCTzhLYlIyVnlvR04rSnp6ZkRDSDEvaDFYU05JRG9Rb1Js?= =?utf-8?B?VGRKaEUzR1VjVFlwcWQvR0U2cUhaY3Z3cXR6TmpUekgrYkVJSUVESGJvQXMz?= =?utf-8?B?VXJFeldtRkVBaGtNK2ZtSXNPRWRvdi8zNDdLalhaeTV0RGRHakJ4Ym1UOWJM?= =?utf-8?B?SjNkK3FRVVpZMVhyYkNvWFlkMHJQNFJEWnBYTjlWWEYycUR6WndQOHE4d1E5?= =?utf-8?B?djNqVm41c0NqN3ZtdEtpSWR5MlVSdDJNbjBuRCtzaWp2bVBiV2Y5UWZON0hD?= =?utf-8?B?TFhhWjlqM2NnTDZzNFIxQnFnYzBVeVJRQ09XOGNEZTg1eTI4LzhiYlZac3pl?= =?utf-8?B?T3Yrb2pOSU9CRU52T01QVmJMNk1weFhPYmFGakZyTldWVmVpdUhqWjdDbWNE?= =?utf-8?B?M1lGYTgxNk9NN1ZrM0V3R08rVmJQZGF0Nnk0TUdnU1YvK0JYMGQ0RUdub1pY?= =?utf-8?B?bHJuYW9YM3IwVUVrQ2RzNE9XeEExZmg5S2JNeXg2RVh4d1ZHL0MyTy9kVkp5?= =?utf-8?B?aGxTeFZvR0JqL2JXMkZDUzNhYXg2S2hpZE9sNUR5dThjSzhmeVdBc2pZZzVM?= =?utf-8?B?Z1VLM1BXZEQ5Nnk5WTZQRHNQZlp3TjhqWUpPb2N6T3BGVDN2dy96a0RmQUVW?= =?utf-8?B?WG51UExyaCt2SkxCdXpDQkVRRE9UdFRjV0ZyMGF1ZHJMdC8yWWwrc1VjSkll?= =?utf-8?B?cnA1NnFCZXJpNXJ5TlZCNDZVWU1Nb1g2eXdDcnkyR1FmZGNxMityNEVXOE8r?= =?utf-8?B?RlQ2M1pUcW5nYU8zU1dIRlorbjY0K25yRi9EM1QxenVWMldwY3hqOFRkcmVv?= =?utf-8?B?MGVHWGx5U3E4aWdodENSUlU4dHVsai9YWkdqbkVUYXplREV5RXJqTlVGOFpr?= =?utf-8?B?Ump3S09TTWx5dUcwM0YrbGlmVWZ0dmpGU1hhNU44RGNTR0ZlcUFTMUg5NmNI?= =?utf-8?B?b2NtVDJWemNzMElvZHhYcnhQeDFESlR2dWdMa2IzamZRUDN1WFdOOEdWTVY1?= =?utf-8?B?WUJMVE8wK0dNOFQxNGdPcE5oQ1duUnZZWHl3dERTd2IxSlpYakhlWnVrNnZp?= =?utf-8?B?SzI2VzMxYzRFeXRTQ01kL1BQdjBzSXplNWFCczdDWUJlYnlVbXhrelBub3hz?= =?utf-8?B?U3lnaTRCYzUzR0p4Qlk0L3JNVWlIaEpmU1V6NVZCbG9WOTFzMkNRZWlRWHpM?= =?utf-8?B?ci9aa3BUZ0o5K2svYTlkbC9qdHVpTDZCRmNoUnZSR1BvbjJvbjB2NXh2cWp3?= =?utf-8?B?YWY4em8wQ2IvYlBMRk85N0ZOSXZoZmRMeWdJelZPaGlrbUdEcW4yalZWTkZW?= =?utf-8?B?RzJMOU9OOGdROWVHdFVsaEdIWDFNNUlMNEs5RVpMUndzMFkzRHNiV0crNzl6?= =?utf-8?B?L29xRC9id3NsKzFYRlBXeEo5V25YTzRKSElzTzNLWm9XaHpteXNIREs3Ymkv?= =?utf-8?B?TGh1TWtlS280NjExSTNWQkpWUENVbWNLeW5vdWhOSXBJKzFqRGR3VmtBQUJp?= =?utf-8?B?aWZaNDFjaGRHOHV1WmRVL1JUelN5V2hhSGdkd1YyZ0tGVzZCZlE0L2U2ZmE5?= =?utf-8?B?RmJodUJhckErd3I0UmRvYVdnS3REaWZldzQvVlluL0d3Y053WE9yMkhaNGla?= =?utf-8?B?dmRudUFJWHIzclpyS3doVzlZb0Z2RVNza000UGczdnh3MTBOQWVETjVaeW5j?= =?utf-8?B?WEExQWJKanJKaEc3OWZEVndCdWY2TXNpaDJURXZsVlhBbHhKL0tpV0dXSDZ5?= =?utf-8?B?b0tFZkh3R3owazBIVlVjNU03WHV6Tkg3UTVaRzJNa0NOdXBod2M5M3ZaUzUv?= =?utf-8?B?RkZkN2JYRnFScVlOQ2dkU0I2L1VnTE5qdUcvN1JHeUt1aCtvNldiNzVmalVG?= =?utf-8?B?bEJFaEFZenVYbGVkbUl1ZDB1VUErVWVONDJ3eVdkMkYvZkJYS0xCSkQydHkz?= =?utf-8?B?V3lMQzdFY2lMcTFDWE50bEVia0E3NGNFMERVYjFVZHd2T0RjS2VHdGZpSWlK?= =?utf-8?B?NnlMUjB0c0x1NEdUQkJIU3BqVUR3ZFNnQ2duTmlFVTQ4MkMxZjJhRTU1Qmp3?= =?utf-8?B?aE1Qc0dWRnZSRFBlS3Q5OFl6NDZMTHlOWjJqR1JJTWlSekZxUno0RHA4eFlq?= =?utf-8?Q?zc5Bw5JEltDbjmYhal4sXMsJ5?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc67e051-fa34-45ff-6506-08db46fc99f8 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2023 08:51:33.5570 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fYWAwCzI4xh0rHky79i5Qs6G5gZlbHb5NsUSt0E2KuMJWQYZzffJTPgJTEsUGWEz X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5723 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/26/2023 6:27 PM, Ronak Doshi wrote: > > > On 4/26/23, 9:58 AM, "Ferruh Yigit" > wrote: > >> As far as I can see these "vmware_pack_begin.h" & "vmware_pack_end.h" >> has only file license comment, and I can see this is used in a few other >> type declaration. >> >> What is the reasoning behind using these headers? > > This has been the case since driver was added to dpdk. The information is present in README. > I did not want to change the format being used for the declarations in the driver. > README doesn't say much. The usage is not standard, and intention is not clear. Can you please dig this issue more to learn the the intention, may be we can find a better way or get rid of them completely? Just to record, usage is: typedef #include "vmware_pack_begin.h" struct Vmxnet3_RingBufferSize { __le16 ring1BufSizeType0; __le16 ring1BufSizeType1; __le16 ring2BufSizeType1; __le16 pad; } #include "vmware_pack_end.h" Vmxnet3_RingBufferSize; Content of "vmware_pack_begin.h": ``` /* SPDX-License-Identifier: BSD-3-Clause * Copyright(c) 2010-2014 Intel Corporation */ ``` "vmware_pack_end.h": ``` /* SPDX-License-Identifier: BSD-3-Clause * Copyright(c) 2010-2014 Intel Corporation */ ```