From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0913A0547; Thu, 28 Oct 2021 12:33:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 539CD40DF4; Thu, 28 Oct 2021 12:33:37 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id F16234067B for ; Thu, 28 Oct 2021 12:33:34 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10150"; a="227831275" X-IronPort-AV: E=Sophos;i="5.87,189,1631602800"; d="scan'208";a="227831275" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2021 03:29:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,189,1631602800"; d="scan'208";a="725677935" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 28 Oct 2021 03:29:49 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 28 Oct 2021 03:29:49 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 28 Oct 2021 03:29:49 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 28 Oct 2021 03:29:49 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 28 Oct 2021 03:29:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MCtJueicXpIN0JeolgKcR+NUU/E9OTwK+Z8NKM7+p0Nta5Jujj1ZP17J8LAgdJfCS5MWuem0C0x2lQJP2+C3Jykzq5m59fjZiIwhkJSLpaOPhqlyM4EDOva+GpHnzVdeCh2j+rJCQMblDl0cRNYqIW7ftKQmpLFGryJex7rZYUiysDGsLPx8jGdJs4rajQgkBaGdBnGvNkOhPv8K4ilVcqZ3U4G+dQyTHW8Nu5KTVrwT+D7HETSxkCK8S6j+qTKWpUG+E8bLKnqoMHm89wOm1HWTRUeatjM9PaZT46CFGcUbH9cNT4XwYY0BbJezsjkOpSIRjHonL89Rt8HJdBLcww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FOga9DanDAVWzjd7VDPW8XokqLMjtc6fzDWeg72ETJc=; b=WY+/V37/n8QFYC1rOMQUa7KvfemXLoVAz5j0/wpjhZ2dKkIj4QZGwqzkQrxG+5+1D0HlROd9moJ3pveCVhDayATll3N74+5wA2ZXIgu563F+MsMsnjv6Cpsp8rgZGxraek+R3HgPSrUmb5h0ytx99jt3Sa9sqFHYQ3xlo+YOWMPJl1yl3ek2TgbbK2x6s/fTiTMv3uQS9R5YRI4VsLy3NrwifVREfXU7zPRi5Wh9LZGmG/joBpSu+SCGVEubFtikvD25+EINChARdtMZ7kEe3g5OTousSS0cCohJFVtnf/4FpQzVstpmDkvXMsIzrPPap3t68227Cov6C22rcIbHlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FOga9DanDAVWzjd7VDPW8XokqLMjtc6fzDWeg72ETJc=; b=iuJFDfk/s4y9E+pVgEU6MHGv/jeZkeM3xupJR0zId7bbtRGbwL+VCCHh/ll1IGdfOY9YZgY+RXnGdWeQREgwWLpUtEcdXwmPQFuYy28+DTyqUw4+mqEqjvHs8e54A9JWZXHSa/CPp9k3r1XnxbPjlOinbyXiuQ1J0LzVJ1keFKU= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5093.namprd11.prod.outlook.com (2603:10b6:510:3e::23) by PH0PR11MB5128.namprd11.prod.outlook.com (2603:10b6:510:39::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Thu, 28 Oct 2021 10:29:48 +0000 Received: from PH0PR11MB5093.namprd11.prod.outlook.com ([fe80::a80e:d881:3c58:9730]) by PH0PR11MB5093.namprd11.prod.outlook.com ([fe80::a80e:d881:3c58:9730%3]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021 10:29:48 +0000 Message-ID: <8b8fd2e4-e7eb-26cd-ad32-2f284eacc24c@intel.com> Date: Thu, 28 Oct 2021 11:29:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.2.1 Content-Language: en-US To: "Xia, Chenbo" , "dev@dpdk.org" References: <25dd76eca01ec57d64be9c0a78ac2752f602984f.1631788595.git.anatoly.burakov@intel.com> From: "Burakov, Anatoly" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB7PR02CA0006.eurprd02.prod.outlook.com (2603:10a6:10:52::19) To PH0PR11MB5093.namprd11.prod.outlook.com (2603:10b6:510:3e::23) MIME-Version: 1.0 Received: from [192.168.1.10] (212.17.34.161) by DB7PR02CA0006.eurprd02.prod.outlook.com (2603:10a6:10:52::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend Transport; Thu, 28 Oct 2021 10:29:47 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 36aafef5-7279-4e1f-6570-08d999fdddcf X-MS-TrafficTypeDiagnostic: PH0PR11MB5128: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0Noy5U1yAFH5d+MTtsC7JFha1N5vbs1zKE9CqWsC/ANVM3qVZPZ8X7OLoddJdM2ckIA0xZVJwHGlpuf4KKg19vYT9k78N4n2pt1NDgYbi2MlqrjDod5Z3/xIqV860FbfJl+6KdsN0Ec0FYevjb4VZMWCGntJGwwetu3Sc9ckmw+GqSzkF+ZZz1uaH65Nlgmjs4qpsrUlYYl4VZT0P5WSWIDW0kGikcCB1UenPaLfU8JjWxVF5gwWOspYcIu1LLXYGUjw6JUCeSkK2lg516EO73spKWl3mec+OJH3mSpDfKUMfLI3gQkoklKineMDagsyRgffhyqFN4uEQ//GY77ATOUUfUAtAPt6l1rBYkfqoHtKtXECTFHbkc4N2Ltkh4wi36JJBLXUthtFlvYj3FhJb9t3rS9O7+Plw2C3BOxHFMr8NHcijzKxTkEBuktQzcPP6ImkShaVb6VJebjMq/2DWcvC/7QS/CQRwBCuMO5oI407VWlDRsSHGT/wlM7Huu457y101qOMLkAOKHXD6e2+ImU5aPJgA2NRO+kwmuXlu442Z0g5hSSKx5YIcSFwJfz1hdNCQkpiFf5SncY8pKiFKiE5g/qgd5T4jOY/A4t3J9OGOB3s0+Ie/WrMjPcYX2/VNCUQ9QQ968cPyy7LnvHibFRaX6/GDqcPTz4K1DZhQeFHJGz26vFJBlPuPCRAiZ4/252TqcERJKQmh+lC2X95U514gVSbmgDpgdD0pwzPWjQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5093.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(316002)(4744005)(508600001)(956004)(5660300002)(36756003)(8676002)(6486002)(110136005)(16576012)(2616005)(6666004)(38100700002)(86362001)(66476007)(26005)(186003)(2906002)(31696002)(31686004)(82960400001)(8936002)(66556008)(66946007)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUZ0OG9Vb3E1bzZaSHN2N3JUaEdYdWJjc1MyWTJ4d1hwOTRkcUc1RjdhaWFN?= =?utf-8?B?Q3U0ckdmTzNWMWpmbmlFR1haZ0drQzUrTDZ2cUpGcUY1Z2FXaHA3MUVrcFIx?= =?utf-8?B?Z3VibG9NQVhmaXZ0R1NYT1RIREw1UEo4SUJWYm95VE1RSXIxN3lkMnAzMEps?= =?utf-8?B?QlgxOUFQVnVWVHVUY1NxYUJyaGNEY2ZKT1FtejVON1pqMm45aWkwS2tTdnp0?= =?utf-8?B?TFE1RXBOZzZQTFF6TEFLZ2JTM2s2T3FjQXFBNG5DQ1lUeW8yQVV5TEJ4Nlhy?= =?utf-8?B?OWNKSUUxQ1RyM1NyTXJoNEgwVFlnQXF2YlNHdEg0c3BJd0cvSlB5S1p5dlBx?= =?utf-8?B?YnBtM25jQTJNK25Dc3ZJcFdYRmtoMnM5WGR5VGZyRTFsM2lwZHhKL1J2OUpq?= =?utf-8?B?c0dJK0ZWaXlNSWRmWnhVWTZjbnBSZVdwVnJkZXN3ZkloUDZaUGtZdm1jSkJo?= =?utf-8?B?Uml1WkQ5aEJRWXhxRGY4Um56YWIwMjBobHVoNW8yeTE2K0RLMEpTWkNZdGJO?= =?utf-8?B?T290bGN4eHdOSnEzWkM3YytLZkJaRUl4ei9rbE4xbDdpaEdTQjRRMjRPNHVN?= =?utf-8?B?YUdoQXl0cVJGTXplK3cyUlFJSkp3SXI4OXFoYlRxZzlhb3NCYzhSNHdyYnFx?= =?utf-8?B?SStrSnlxamFDMzhiWmJaQ2hvcVZQYWx6Wno1Ly9oNS9vY05yUGJDQXE4bHV1?= =?utf-8?B?TXRYMHlIMHZKWW9zOXRJTk9yMTQ2R3BHcmtUS1pZUUlOVG5pSkUrSi9WZHBz?= =?utf-8?B?amErMlpsN3pWTE43enprcHREQjBWYXA2QWdsb2g1UkpkR3A3ZVkyelplcEtl?= =?utf-8?B?WmlVdGp2WjhFYjRCSXhEVkZMMVIySTdyUFZrZFJRdXM3RkU5bGxhVENXMHlr?= =?utf-8?B?cUk3dC9CaE5uS0xTZEFXS3NGTGdWcnVCR042SFJHa3VPYk1IMlgvOXlERFgr?= =?utf-8?B?TGFoOGVmUGgzblovV0FqSk5hL3ErTGxDdlZHUnVmeGMwOTZEU0p2R1IvL0pq?= =?utf-8?B?RzVsdlhtUUg1TzlZVFpPQ1VPTWpwZDhoQ21Lalhmelp0UkVDMzYzYWVpbUdJ?= =?utf-8?B?NEZrL2Q2T3BhS2xFTEdBRjdnVWY3b0hQN0MxaitXTHhzMVQ0aUpZY1kvTDZk?= =?utf-8?B?U3lKeEJMUWdNWjAxNThtUmFUN05BR3JRMHd6VUtyV3UwSXR4NXFNZHRtaDFK?= =?utf-8?B?SFBLanNBWCt0dDBIV241Y1B5eFo1UndraWZrUEZRc1lWeVpjU0llVURWR1Ax?= =?utf-8?B?UEVMa2xydXVYZmMza0V4RGhCaGY1NlVncGR4MDhieGtMQVliUTZmVEVXb3dv?= =?utf-8?B?dWxzYVhROXlnWGtLVlJrSkJST3ljSU9Hd0FIWGtEWjRWeTdHMW12bzQzYW5J?= =?utf-8?B?bEwyanlWbWJIOEhKSytsLyt5N296cDdxRkZGVGZmUWt6Y2gzMkc3TVdjMkNN?= =?utf-8?B?aFJXNHpLZzFXWXBPVVl5Tlo1d0Z4NllCSFhyVTJHZEJkMUZmT1hNVXZjekdW?= =?utf-8?B?bVN5aFZ1V2dKOElyV2dIV0VDNXNwRXVrWTQ1blZSSWtEYXpTMzM2Q1BEQU5w?= =?utf-8?B?YWJYTzlFcTdjWHAxUVY2NkMxN2pXb1RXdDJMV0FhSWdDKytFbTFYZ0ZCTEJO?= =?utf-8?B?K2xPbjBRdys1L25zWVhOOVBVRlQxT3dQaEs2eHpzUTg2L3dRQVNmL3VZdVB4?= =?utf-8?B?V0VxUHU4RkVKKzZkSzUxRENVVVdQVk1iaDFna2o1dnFtM1V2R09sb3lCUW82?= =?utf-8?B?T0prZmVPT2YrZnllK0JUaFU4eGJueksrYng2cXY3YWJjY2Jvc0Eyd1JVZUFo?= =?utf-8?B?djBRMWJoNnFNTFZIZ2poY1I4TC90OHBrQldqVStkbS90K2dIZzhIWVA2TlhI?= =?utf-8?B?YVdZaU9vMW9VcHBDOUVEK1FRSFBudk85cXhLUmFoMHh0RWN6V1hkQ2JKV3Nj?= =?utf-8?B?RHhSekUyWWVGK2NxNDlOQTg0VDJRampQZHM2blFjUjZnNjdhZk1PSENxU1dP?= =?utf-8?B?MVdaRjEwYkk2aUQ5LzhTU0dRVWxQM3FPS0M3eXRiUjhFeDBVdE9oczZWZEEr?= =?utf-8?B?dFptUG5MYjhyUnFVNjhNVzU4eWtYa0lPOExxYXd5QkhZd0R4K3Y1dHJud0FH?= =?utf-8?B?Mmt4WHFEV0l0bHFaT25mVndxaEVwRFNmVjhsQTFKRE5iOXA0cStMcmhiRWl3?= =?utf-8?B?aFJRd0l6bVJJeUU3VG5VTTgxRWFrdnRKdjE0UEdBVFdvQ0lLSzN4eVAyVnFK?= =?utf-8?B?YXpCYVcraWJaaVBnWFRCVDR2MXhnPT0=?= X-MS-Exchange-CrossTenant-Network-Message-Id: 36aafef5-7279-4e1f-6570-08d999fdddcf X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5093.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 10:29:48.0521 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e4ebK4ASPPyv8tNbocjcyVn0R5ptg0xqxofSaodzxqKb6MYAb/nJuFtX2gf7lMd96uty6Pnya/zOOT7FA7BFGFv4k3+koMpzX7A3/psZ65I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5128 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Chenbo, > And do we need backport? As 'return -1' does not align with the API doxygen. > > Thanks, > Chenbo > Maybe it's the FreeBSD implementation that needs to be adjusted then, because none of those functions are valid on FreeBSD, and the documentation for VFIO functions explicitly mentions that on FreeBSD, they should return an error. I went with adjusting Linux implementation to minimize the amount of changes we have to make (and only change code path that no one uses in the first place), but maybe that was a wrong decision. I'm not sure if changing the API return value to match what was documented counts as an API change, so maybe backport to stable is not advised here. -- Thanks, Anatoly