From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id CD93A160; Sun, 15 Jul 2018 11:38:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jul 2018 02:38:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,356,1526367600"; d="scan'208";a="64814059" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.249.78.130]) ([10.249.78.130]) by FMSMGA003.fm.intel.com with ESMTP; 15 Jul 2018 02:38:26 -0700 To: Andrew Rybchenko , Jerin Jacob Cc: dev@dpdk.org, thomas@monjalon.net, stable@dpdk.org References: <20180629094443.26540-1-jerin.jacob@caviumnetworks.com> <22d74419-6842-044c-9c61-7855925bf41b@intel.com> <47d3c4aa-04f7-110b-f889-cfb07fecdfca@solarflare.com> <20180710062023.GA2600@jerin> <799fe61d-4895-fd84-3d53-862feb1d9ea4@solarflare.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E TS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62 FwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4 jQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB c34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF HmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd fmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1 yC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p msjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg Hiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW ta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu UhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG ZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ zT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU NyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK FYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs tFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC x41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA bLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ qZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3 XphVR5G70mnca1E2vzC77z+XSlTyRA== Message-ID: <8bad57a6-98dd-6299-077d-97497542e0e2@intel.com> Date: Sun, 15 Jul 2018 10:38:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: <799fe61d-4895-fd84-3d53-862feb1d9ea4@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: fix queue mapping documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 09:38:55 -0000 On 7/10/2018 8:06 AM, Andrew Rybchenko wrote: > On 10.07.2018 09:20, Jerin Jacob wrote: >> -----Original Message----- >>> Date: Mon, 2 Jul 2018 16:45:33 +0100 >>> From: Ferruh Yigit >>> To: Andrew Rybchenko , Jerin Jacob >>> , dev@dpdk.org >>> CC: thomas@monjalon.net, stable@dpdk.org >>> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix queue mapping documentation >>> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 >>> Thunderbird/52.8.0 >>> >>> >>> On 7/2/2018 4:32 PM, Andrew Rybchenko wrote: >>>> On 07/02/2018 06:08 PM, Ferruh Yigit wrote: >>>>> On 6/29/2018 10:44 AM, Jerin Jacob wrote: >>>>>> The RTE_MAX_ETHPORT_QUEUE_STATS_MAPS does not exists, change >>>>>> to the correct definition(RTE_ETHDEV_QUEUE_STAT_CNTRS) >>>>>> >>>>>> Fixes: 5de201df8927 ("ethdev: add stats per queue") >>>>>> Cc: stable@dpdk.org >>>>>> >>>>>> Signed-off-by: Jerin Jacob >>>>>> --- >>>>>> lib/librte_ethdev/rte_ethdev.h | 4 ++-- >>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h >>>>>> index 36e3984ea..375ea24ce 100644 >>>>>> --- a/lib/librte_ethdev/rte_ethdev.h >>>>>> +++ b/lib/librte_ethdev/rte_ethdev.h >>>>>> @@ -2144,7 +2144,7 @@ void rte_eth_xstats_reset(uint16_t port_id); >>>>>> * @param stat_idx >>>>>> * The per-queue packet statistics functionality number that the transmit >>>>>> * queue is to be assigned. >>>>>> - * The value must be in the range [0, RTE_MAX_ETHPORT_QUEUE_STATS_MAPS - 1]. >>>>>> + * The value must be in the range [0, RTE_ETHDEV_QUEUE_STAT_CNTRS - 1]. >>>>> Yes RTE_MAX_ETHPORT_QUEUE_STATS_MAPS doesn't exits and comment is wrong, but >>>>> RTE_ETHDEV_QUEUE_STAT_CNTRS also slightly not correct. >>>>> >>>>> I think how testpmd uses it increase the confusion. >>>>> >>>>> In ixgbe there is no stats registers per queue, 128 queues are represented by 16 >>>>> register set. stat_idx here is the index of that 16 registers. You map queue to >>>>> stats requester to get queue stats. >>>>> >>>>> Also there is RTE_ETHDEV_QUEUE_STAT_CNTRS config in the ethdev API, which is the >>>>> hardcoded size of the queue stats, its default value is 16. This limits number >>>>> of the queues we can get stats from but saves allocated space. (Why not dynamic?) >>>>> >>>>> You can increase the RTE_ETHDEV_QUEUE_STAT_CNTRS to the max supported number of >>>>> queue and ethdev code will be all valid. But "stat_idx" can't go beyond 16 (for >>>>> ixgbe) because it is hardware limitation and it may change from hw to hw. >>>>> >>>>> Also technically it should be possible to reduce RTE_ETHDEV_QUEUE_STAT_CNTRS to >>>>> a low number, like 2, but in ixgbe map two queues into stat registers 14 & 15 >>>>> and display those two set as queue stat 0 and 1. It seems current implementation >>>>> prevents this and forces the queues mapped should be less than >>>>> RTE_ETHDEV_QUEUE_STAT_CNTRS. Overall it seems there is a mixed used of >>>>> RTE_ETHDEV_QUEUE_STAT_CNTRS and stats queue index values, I assume because both >>>>> are same values. >>>>> >>>>> I suggest updating it as: >>>>> " >>>>> The value must be in the range: >>>>> [0 - MIN(HW Stat Registers Size, RTE_ETHDEV_QUEUE_STAT_CNTRS) - 1] >>>>> " >>>> Technically I think it is not a problem to specify more than HW supports. >>>> The function should simply return error. RTE_ETHDEV_QUEUE_STAT_CNTRS is >>>> a hard limit which should be checked by ethdev. >>>> The reasonable next question is how to find out what is the maximum for PMD/HW. >>>> I think it deserves entry in dev_info. May be not now. >>> Yes there is not a way to find out that limit by application, setting >>> RTE_ETHDEV_QUEUE_STAT_CNTRS to 16 and using it as limit solving the issue for now :) >> >> If I understand it correctly, in the documentation, we are specify the >> limits to avoid the segfault etc and if the specific PMD does not >> support the range up to RTE_ETHDEV_QUEUE_STAT_CNTRS, It can simply return >> error which makes the documentation semantically correct. >> >> Considering the above point, I think this patch is correct considering >> there is no way currently to detect the limit supported by PMD. So, >> 1) Should we keep the patch as is? >> >> -- >> The value must be in the range [0, RTE_ETHDEV_QUEUE_STAT_CNTRS - 1]. >> -- >> >> OR >> >> 2) Change to >> >> -- >> The value must be in the range: >> [0 - MIN(Device max per Tx queue stats, RTE_ETHDEV_QUEUE_STAT_CNTRS) - 1] >> -- >> >> I prefer option 1. But I am okay send v2 if any ethdev maintainers prefer >> option 2. >> >> Let me know. > > I would prefer option 1 as well since right now we have no way to > advertise/find out "Device max per Tx queue stats". OK, agreed/convinced on option 1, eventually it will be better than current comment, so no new version required, thanks.