From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3E47A2EFC for <public@inbox.dpdk.org>; Mon, 14 Oct 2019 09:57:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B00701C1DB; Mon, 14 Oct 2019 09:57:08 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 106A91C1CE for <dev@dpdk.org>; Mon, 14 Oct 2019 09:57:07 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 8A7FE8005E; Mon, 14 Oct 2019 07:57:05 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 14 Oct 2019 08:57:00 +0100 To: Alfredo Cardigliano <cardigliano@ntop.org>, Stephen Hemminger <stephen@networkplumber.org> CC: <dev@dpdk.org> References: <157083994018.11524.11276616720287263690.stgit@devele> <20191012082813.7abe5f4d@hermes.lan> <F83E31CE-8033-49E4-999B-84DF35DF84B8@ntop.org> From: Andrew Rybchenko <arybchenko@solarflare.com> Message-ID: <8bafa882-3d10-4fd4-0af6-0bbe4452945e@solarflare.com> Date: Mon, 14 Oct 2019 10:56:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <F83E31CE-8033-49E4-999B-84DF35DF84B8@ntop.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24974.003 X-TM-AS-Result: No-9.558000-8.000000-10 X-TMASE-MatchedRID: eVEkOcJu0F7sYbGmK/WYxvZvT2zYoYOwC/ExpXrHizxXXbZeMl1WD0w5 MIk9Zic42UJszGAseMGEQMR4E0/LXTaN5j5R2D8i/ccgt/EtX/0A+JHhu0IR5pGhAvBSa2i/wd0 ua4gmnrQbpFu2LL52JpMsbSdapRzTeKZAID3hHVYYxRF+FCQQstZnNOazoZ6SU20Pec0W1lYqvx HAtLsn3b/ookEkN/h0/2jhsEtuxob8XF85VELdKMkFQf0u+7NqsKi4EXb8AIrm5xVqTV9QwbMea pFjC2iRmgaSd8DqI10KsonrqBnRWa/Bl8s56y+QLIrMljt3adtxWv4UB7dQNX5Isu006IGGw/fb fywPSrpQNgaVBskNlj48erx7ecjev1l2Uvx6idpWdFebWIc3VsRB0bsfrpPIfiAqrjYtFiQTZOT +y/yxf2KVDbGtCuwO40ubmgKWF4eWROhZj4B2kX7cGd19dSFd X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--9.558000-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24974.003 X-MDID: 1571039826-vBkEkdyJ5xjD Subject: Re: [dpdk-dev] [PATCH 00/17] Series short description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 10/14/19 10:16 AM, Alfredo Cardigliano wrote: > Hi Stephen > yes, we were thinking of doing a single post for just that reason, > but Thomas recommended that we split it up. I agree with Thomas that it is better to split it up. What I don't understand from the list below is, for example, why RSS goes before Rx/Tx handling. Ideally, it should be no dead code in patches, the driver should be buildable from patch #1 and subsequent patches should add more and more functionality which is testable. Of course, it is not always doable, for example when a base driver should be added first, but it does not look so in this case. > Thank you > Alfredo > >> On 12 Oct 2019, at 17:28, Stephen Hemminger <stephen@networkplumber.org> wrote: >> >> On Sat, 12 Oct 2019 02:26:26 +0200 >> Alfredo Cardigliano <cardigliano@ntop.org> wrote: >> >>> The patch series provides an initial version of a >>> poll mode driver for Pensando network adapters. >>> The driver name is ionic. >>> >>> --- >>> >>> Alfredo Cardigliano (17): >>> net/ionic: add skeleton >>> net/ionic: add hardware structures definitions >>> net/ionic: add log >>> net/ionic: register and initialize the adapter >>> net/ionic: add port management commands >>> net/ionic: add basic lif support >>> net/ionic: add doorbells >>> net/ionic: add adminq support >>> net/ionic: add notifyq support >>> net/ionic: add basic port operations >>> net/ionic: add RX filters support >>> net/ionic: net-ionic-add-flow-control-support >>> net/ionic: add RSS support >>> net/ionic: add RX and TX handling >>> net/ionic: add stats >>> net/ionic: add TX checksum support >>> net/ionic: read fw version >>> >> When adding a new driver, could you send it as >> one unit, yes it is a big bit of code to review but >> drippling it out in pieces doesn't make review easier. >>