From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BDD0A0A0C; Thu, 1 Jul 2021 11:28:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2AB3940141; Thu, 1 Jul 2021 11:28:48 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 0C8B140040 for ; Thu, 1 Jul 2021 11:28:46 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 8F0407F528; Thu, 1 Jul 2021 12:28:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 8F0407F528 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1625131725; bh=bZ+3ebiePjV+JS6X4jiC8+em1KmHOJ1plDAccJsqYj4=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=i6XN+zCa45zIlCOMAGEBARPr393Bp6hkhpEPhn38qO/q3NQr+ZYmrFh8uNr/hbKju MiTYoBD5N63NsbLuBZU0CcdoJg8VsW3iSe0dJnjzmvaptzShzCY27FCuCndslbRn0w nEia15VIg+aZIzjiuDUYwQJL8un+BIi9vrW70ckY= To: Olivier Matz , dev@dpdk.org Cc: guohongzhi1@huawei.com, keith.wiles@intel.com, mb@smartsharesystems.com, thomas@monjalon.net, ferruh.yigit@intel.com References: <20210427135755.927-1-olivier.matz@6wind.com> <20210630135158.8108-1-olivier.matz@6wind.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <8bb5cf8a-672c-4496-7901-4cf0c9bf735a@oktetlabs.ru> Date: Thu, 1 Jul 2021 12:28:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210630135158.8108-1-olivier.matz@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 0/4] net/tap: fix Rx cksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/30/21 4:51 PM, Olivier Matz wrote: > This patchset fixes the Rx checksum flags in net/tap > driver. The first two patches are the effective fixes. > > The last 2 patches introduce a new checksum API to > verify a L4 checksum and its unt test, in order to > simplify the net/tap code, or any other code that has > the same needs. > > v2: > > * clarify why RTE_PTYPE_L3_IPV4_EXT_UNKNOWN cannot happen in > tap_verify_csum() (patch 1) > * align style of rte_ipv6_udptcp_cksum_verify() to > rte_ipv4_udptcp_cksum_verify() (patch 3) > * clarify comment above rte_ipv4_udptcp_cksum_verify() and > rte_ipv6_udptcp_cksum_verify() (patch 3) > > > Olivier Matz (4): > net/tap: fix Rx cksum flags on IP options packets > net/tap: fix Rx cksum flags on TCP packets > net: introduce functions to verify L4 checksums > test/cksum: new test for L3/L4 checksum API > > MAINTAINERS | 1 + > app/test/autotest_data.py | 6 + > app/test/meson.build | 2 + > app/test/test_cksum.c | 271 ++++++++++++++++++++++++++++++++++ > drivers/net/tap/rte_eth_tap.c | 23 ++- > lib/net/rte_ip.h | 127 +++++++++++++--- > 6 files changed, 398 insertions(+), 32 deletions(-) > create mode 100644 app/test/test_cksum.c > Series-reviewed-by: Andrew Rybchenko Applied, thanks.