From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 761DEA058E;
	Thu, 26 Mar 2020 06:26:09 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id BC3351C028;
	Thu, 26 Mar 2020 06:26:08 +0100 (CET)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 279951BFC3
 for <dev@dpdk.org>; Thu, 26 Mar 2020 06:26:06 +0100 (CET)
IronPort-SDR: NfCvbvovVthJa8XBv8H3nrPfZH5tt/5fAWjld/SFm6TNe4fvUYBHWpXe0gx6FdHgiw44fH+6Iz
 mDlFWhyasdNg==
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 25 Mar 2020 22:26:05 -0700
IronPort-SDR: MCBda1/2iVUtB7cw/b1yIjm+kW79U0n2kK4OD6qHS9g5EmxBRRTj1Qhfcd2HPeJBSaqrKYtOwd
 0qRVrmD/lcGA==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.72,307,1580803200"; d="scan'208";a="393859350"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
 by orsmga004.jf.intel.com with ESMTP; 25 Mar 2020 22:26:05 -0700
Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 25 Mar 2020 22:26:04 -0700
Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by
 SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.1713.5; Thu, 26 Mar 2020 13:26:02 +0800
Received: from shsmsx603.ccr.corp.intel.com ([10.109.6.143]) by
 SHSMSX603.ccr.corp.intel.com ([10.109.6.143]) with mapi id 15.01.1713.004;
 Thu, 26 Mar 2020 13:26:02 +0800
From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: "Ye, Xiaolong" <xiaolong.ye@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Qi Z" <qi.z.zhang@intel.com>,
 "Yang, Qiming" <qiming.yang@intel.com>, "Xing, Beilei"
 <beilei.xing@intel.com>, "Zhao1, Wei" <wei.zhao1@intel.com>
Thread-Topic: [PATCH v4 0/7] add Intel DCF PMD support
Thread-Index: AQHWAxxP1HTfIWdP7Eu2aInp8yiZ26hZzBaAgACLnhA=
Date: Thu, 26 Mar 2020 05:26:02 +0000
Message-ID: <8bb8605a54374d8ba368ccd811ca90e0@intel.com>
References: <20200309141437.11800-1-haiyue.wang@intel.com>
 <20200326030346.32907-1-haiyue.wang@intel.com>
 <20200326050547.GB29805@intel.com>
In-Reply-To: <20200326050547.GB29805@intel.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.2.0.6
x-originating-ip: [10.239.127.36]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v4 0/7] add Intel DCF PMD support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Xiaolong,

Yes, found the root cause. Will fix it next version.

BR,
Haiyue

> -----Original Message-----
> From: Ye, Xiaolong <xiaolong.ye@intel.com>
> Sent: Thursday, March 26, 2020 13:06
> To: Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming <qimin=
g.yang@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: Re: [PATCH v4 0/7] add Intel DCF PMD support
>=20
>=20
> There is build error about this patchset, could you double check?
>=20
>=20
> OS: CENTOS77-64
> Target: x86_64-native-linuxapp-gcc+shared
>   LD librte_pmd_ice.so.20.0.2
>   CC sfc_ev.o
> ice_dcf_parent.o: In function `ice_dcf_handle_pf_event_msg':
> ice_dcf_parent.c:(.text+0x556): undefined reference to `pthread_create'
> collect2: error: ld returned 1 exit status
> make[6]: *** [librte_pmd_ice.so.20.0.2] Error 1
> make[5]: *** [ice] Error 2
> make[5]: *** Waiting for unfinished jobs....
>   CC sfc_port.o
>   CC bnxt_rxtx_vec_sse.o
>   CC sfc_rx.o
>   CC nicvf_hw.o
> --
>   CC medford2_nic.o
>   LD librte_pmd_octeontx2.so.20.0.2
>   INSTALL-LIB librte_pmd_octeontx2.so.20.0.2
>   LD librte_pmd_sfc_efx.so.20.0.2
>   INSTALL-LIB librte_pmd_sfc_efx.so.20.0.2
> make[4]: *** [net] Error 2
> make[3]: *** [drivers] Error 2
> make[2]: *** [all] Error 2
> make[1]: *** [pre_install] Error 2
> make: *** [install] Error 2
>=20
> http://mails.dpdk.org/archives/test-report/2020-March/122145.html
>=20
> On 03/26, Haiyue Wang wrote:
> >A DCF (Device Config Function) based approach is proposed where a device
> >bound to the device's VF0 can act as a sole controlling entity to exerci=
se
> >advance functionality (such as switch, ACL) for rest of the VFs.
> >
> >The DCF works as a standalone PMD to support this function, which shares=
 the
> >ice PMD flow control core function and the iavf virtchnl mailbox core mo=
dule.
> >
> >v4:
> >   Change the alarm handler to thread service, since it will need to do =
more
> >   work.
> >
> >v3:
> >   1. Fixed the error log message format.
> >   2. Fixed some memory allocation check.
> >   3. Fixed some code style issue and commmit message description.
> >
> >v2:
> >   1. update the iavf patchset link.
> >   2. split more patches for making this work be more understandable
> >   3. fix the log function usage, devargs checking from v1.
> >
> >Haiyue Wang (7):
> >  net/iavf: stop the PCI probe in DCF mode
> >  net/ice: add the DCF hardware initialization
> >  net/ice: acquire and disable the DCF capability
> >  net/ice: handle the AdminQ command by DCF
> >  net/ice: export the DDP definition symbols
> >  net/ice: handle the PF initialization by DCF
> >  net/ice: get the VF hardware index in DCF
> >
> > doc/guides/nics/ice.rst                |  47 ++
> > doc/guides/nics/img/ice_dcf.png        | Bin 0 -> 39168 bytes
> > doc/guides/rel_notes/release_20_05.rst |   5 +
> > drivers/common/Makefile                |   1 +
> > drivers/net/iavf/iavf_ethdev.c         |  43 ++
> > drivers/net/ice/Makefile               |   6 +
> > drivers/net/ice/ice_dcf.c              | 658 +++++++++++++++++++++++++
> > drivers/net/ice/ice_dcf.h              |  63 +++
> > drivers/net/ice/ice_dcf_ethdev.c       | 321 ++++++++++++
> > drivers/net/ice/ice_dcf_ethdev.h       |  33 ++
> > drivers/net/ice/ice_dcf_parent.c       | 351 +++++++++++++
> > drivers/net/ice/ice_ethdev.c           |   9 +-
> > drivers/net/ice/ice_ethdev.h           |   8 +
> > drivers/net/ice/meson.build            |   8 +-
> > mk/rte.app.mk                          |   1 +
> > 15 files changed, 1544 insertions(+), 10 deletions(-)
> > create mode 100644 doc/guides/nics/img/ice_dcf.png
> > create mode 100644 drivers/net/ice/ice_dcf.c
> > create mode 100644 drivers/net/ice/ice_dcf.h
> > create mode 100644 drivers/net/ice/ice_dcf_ethdev.c
> > create mode 100644 drivers/net/ice/ice_dcf_ethdev.h
> > create mode 100644 drivers/net/ice/ice_dcf_parent.c
> >
> >--
> >2.26.0
> >