From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F34843329; Tue, 14 Nov 2023 13:57:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B34434027D; Tue, 14 Nov 2023 13:57:24 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2068.outbound.protection.outlook.com [40.107.223.68]) by mails.dpdk.org (Postfix) with ESMTP id 8EA6140279; Tue, 14 Nov 2023 13:57:23 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nzPaph/kN2E6wxpm80GybsCIitLxl9JG5KejEFyxKP+7qiQ04CMrXz01qwNPyxtVjuIfoOpqP3gJIsykw6HZ26YwP19DcguXwp3vVPiyyiUc+wDlPV9nwVX3k7gEypT2ndDtK0xvzficrKibXhHoHTxELMYEKFUJnW3xGR6WOFsAYBmkmnqOyIUTjSFU8CMtdWAK1FhW9+eAx3ZEykazsmearBBfc+4LrWp+fsc5vMeJGIoJiWunUuJ162IjX1HkLCVCQW08y4oq518dy1TW1ZZ5eYMG4EWdf2gq4KrH5ncUR/hpJ+uVyM5bvZSNRjxCPhvciWJ+Htq1YmRC+ll8VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qgAEqYI+moaLefp3O3cgxt5IGXK4fFuQwzW2hGN3zIY=; b=QQcz1W3QULoSvKHFYlvxNP/yVt8l6+RjB3KmSmDlQhqNtdvAZuLR54/3QHB28j4l/tBySOz24hVy9Te5Faen8rEbM8rSRjpgGrurU40zt95jBahQj9LbBsreooAQQZoLEJP2kojd0O+kzShxKMmjRLNmgvABlT5h+GwImMgAC9lvNzqCPWZq6dn69FwSNuW0eZCyjhUDQVBTPWNX0VzGnPP39gg0dIbLpLKs5eBEU1R8C4+rL/9PTrEd9WIOy7HNbaLXDhNP7f5qUNGAQTacjCyAppAg73L5qOnkU9enX/hBovvH0zkX/4QBbUcto5EROF1MeYViJbMIyTr15517Kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qgAEqYI+moaLefp3O3cgxt5IGXK4fFuQwzW2hGN3zIY=; b=O/9yQmBXwPb8JWxgjNCxzYhO0lOnOyDQ6RU7wsj1KcYdyM4blavA4G7ZSm7milHUIq2ofki6qAh7c06QzjNnJI592ssh/v6eDBvXSl8+nN5NVph0GZVYKAqz2/28jtuHWJKff0322MClQoQ/08juG6D6davf+1BekRTyLPtjRzA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB6741.namprd12.prod.outlook.com (2603:10b6:806:26f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.31; Tue, 14 Nov 2023 12:57:20 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7002.015; Tue, 14 Nov 2023 12:57:20 +0000 Message-ID: <8bb91906-50e0-4c2c-a498-1ed56ff56f4f@amd.com> Date: Tue, 14 Nov 2023 12:56:50 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] net/gve: fix RX buffer size alignment Content-Language: en-US To: "Guo, Junfeng" , Joshua Washington , Jeroen de Borst , Rushil Gupta , "Li, Xiaoyun" Cc: "dev@dpdk.org" , "stable@dpdk.org" References: <20231111003410.2950594-1-joshwash@google.com> <20231113231206.376452-1-joshwash@google.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0087.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB6741:EE_ X-MS-Office365-Filtering-Correlation-Id: bbd9d294-8690-4732-68aa-08dbe5113c91 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bZzlGttqZn4pR8tmQalM26UWeMK3Pz5m9fH39FJX4D8At38s6uifFwZ74xg+UaCc+aCIS42lTocz7H2dzh4A4jDO1mLlIVbdkqc4Tuavl6n1r+ET7G01U2/S0ZVA+ItEpMIN6y3dpzgt/P+f7ioB66n/hprXiYD83uEUo1gpa4YAD/VSXuGaypcScxsCsNYNBvQ+PqNB83Tk69vXraULFla+M72796OgEyxrtSf4zA8H8a49O28nKubUiJgzSH8aQOeY8YjmjGFmgnqy2NU+zrTPo2A/7W8GRm42qJvtpR0m6AqFWeymlQfKi1FTMBHXNk6YWVKmjaJWo4KFgT9qKQBxEw7ZD1bKSuphaxmPzV9VnnUY8S7FDtG8Ar1gHuX3kZQvSLCFlUOCbzGMOE0sxs04zTZME/vafDfMAC0YTPCQkAY/gOql/zGy2e5H8LbqLHFnIU7YzPZ5pOJ6H9aGNAIOkGsMUFq99zjJlxKbT7BRuc1GEw7SETrNGgGcsEbw2Y1pBDyEcQIxE0VPusRLiHCnipMyl9aI7TEvFwSjJQ8+F3z+AgA4ckJz2TXh9GzOYfQdmPmtAZKe4+bjhZoOYdotk5K2hzV9U0R1EJqsnPqU+acgcOCnBQ42ddFuJ0ht3VZU95iV0046qiLOWBaH8A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(376002)(396003)(366004)(39860400002)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(53546011)(6506007)(86362001)(44832011)(8676002)(4326008)(8936002)(38100700002)(2906002)(478600001)(6666004)(66476007)(54906003)(6512007)(5660300002)(316002)(66556008)(31696002)(66946007)(2616005)(110136005)(26005)(6486002)(31686004)(41300700001)(83380400001)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmVJQ1JSbm8zTDNhM2dFNTQzSXJhdTBzNEo2U2gzL293QjRrQkQ4akFtMWFC?= =?utf-8?B?YWpCWnBwVHBSdVdmK2RXM2twWngrUVVpd3BXU0JMdGZNbHRRY044SGJoZWRz?= =?utf-8?B?S0RhaEdFcFFBM2gySVFWajdRbTZLVGxMRStjUERRTnd5WWRZMFZzb25mVXlE?= =?utf-8?B?NGMrNThGYkh6ek1WeXNobFBNaU4vZU1BVzRzUVQ3R2Rid3BFVSt6NVN5YTVO?= =?utf-8?B?dlc1SXdRL3RlMzlrdGVoQU4za2ZKeXpvelhJaHY1Ri9WcjFqTVZRUDh3UlVS?= =?utf-8?B?UmJrbk1KVkorN1piVFdDYi9xbGNsQWJhamMzVCt3SlZMZGc2eHpmNTIrQmlz?= =?utf-8?B?VmtJV1M2RTA5bXQ0OUlVeGJoalFKSzNSZzE3dVJqOUJSUytkZUYydm5IcXVH?= =?utf-8?B?bjRReWNwRWc5TWlHVDdtOXRDeEZYT0NrVDJxNFZGaTM2TXg5ZDNEaXA4bCt2?= =?utf-8?B?YUdmcVU1WGFLKzI1RGFBYUY5ektWSlp0MlJvUXMyZ2JYMVhtZTRoS2ZzajZB?= =?utf-8?B?YzdacUloVTJMQTdjMEp3UG43TFc0TmhHRmxqOHBHQnFYSVd1ZGp4WnlTYUVJ?= =?utf-8?B?SkdOUUpkSXF5V2JHdlp6SmdLTDZPWStWTTdzR0VZTHdERHlWSXVRQU5QZHFk?= =?utf-8?B?Y1RITlMxZllxOTRCc0lTTVBqRmtNN0ZYSmVnV1J0Q0tEU0dxWDNyN0o2bzlq?= =?utf-8?B?QlFpQ1lIbmNxMG9zQm4rVWJVcTdOdlkreHEvaE4zVUdIYUk4d2NPd0l0OCtw?= =?utf-8?B?cEE1TmZ1NFhNcXRMRXlHdVpxSHEyeWtlUmtSME9SY2t6VGlnZHZWRDJHWTlN?= =?utf-8?B?YnJHRUg1VEx0UW9xcEU2bnJjd29TQk9vSjJGMGFEb3pqNGJnR2NPc3U0a0Ra?= =?utf-8?B?NksxVTkrSEZ6M0pIV1p3OG0xTTl0NjRJVUNsc1ZFVUpXc1FTZ1puZEtzZGFi?= =?utf-8?B?UGltVUI5UTB2M0tEYmlZd2hoU2hSaEZyUkY1L3BTanNWTVVzV1I4TVhuYXB3?= =?utf-8?B?VWtwVjltTkxha2FUUUp4U29DKys4R2VhTlNUR3pFWFJ4ZE9WcUxEa2Jobk9r?= =?utf-8?B?MHZpMElCcDFiRkJTeXVnM1hPRHYwbnQrUTArNUIycnpJVE1iTU1jWGVBS0xL?= =?utf-8?B?MVJncUlFUE1RYUpDc3hWdFFLOHpEZER3VllqZGlTMG1Ic20rSS9TOTg4Q1Nm?= =?utf-8?B?UXJSWWNGdGlDd3FseG9YekRCN3REeWprZ1hORXJ1MU51WkJOa1d1cnBIWlEz?= =?utf-8?B?MThUdFJtNGhNWXlydXNFTXRyOGplcWhtcUw1UE5MOWVFNElYZlM1cU9XTnJm?= =?utf-8?B?S0M3WnEzT1V6bVpYK2lZRUo0R0o2aCtiOGtRQ25HWC95MkFLUkIrZTB1ZTBu?= =?utf-8?B?eklta2FRR3ZLNk42ZnNyUCt5SUxJb0VCUUhzcWRhUHVLS21Ob0hFSEJkSmto?= =?utf-8?B?NHJEd2hYMXRZcko1Z1RmZ29LLzErWXordjkyQy9HLzU0cUtpTmMxMndKOTVF?= =?utf-8?B?L1N3SUJWR3lwTWJMQnl2UW5lZ1NhSTNqMHQzNWVLKzdwWXpmbWFaMXg1VlhD?= =?utf-8?B?cGJlQU11SzVVaFJ3alRHeGtnWFFnV2dFVFhaWjRqM3luczFrMGwxcWx5UTN4?= =?utf-8?B?TExoMDBiWjZ1M1NiMmlqYVk1Z0tDUklONnBaYTZ3L0hMY3Z4WWFFT200OHF2?= =?utf-8?B?Q2cyMFE3NFh5U2xSZ3VPNTdueGVrTXVxTVgrVTNmMnpCbnNmeGIveGpseU9o?= =?utf-8?B?elZTWVFVbyt6RkVCc2t1QzhkdTI0TWZEQTRidjg3bjdZQ3EveDZiQTFhblZM?= =?utf-8?B?UVVHYWRyRjNSdWxFTGlZQi94WHpHL2VWcXNCY216QisxWGM3UUpNT2k3TWpR?= =?utf-8?B?TG5BcWNjU3Q5SHQrL0tzMFhBaUZRclFINnpCdzNYeUxjMzJ0bXNnbloycW9K?= =?utf-8?B?S0ZiazVGN0xGWmxuSnZ4RGhhc0preFQxanBId3VhL3hsUVdXZ3hmSHhibU8w?= =?utf-8?B?VXd3YVRqNFdwc2lXbkJqQWVYV2IwN0NuL0ovY0tIYU13QnRZckxjOXlzYndo?= =?utf-8?B?SEppVFEzRElQQTllWTY0VHNXK0pINERwbnZlMFNOdzJzSnhZYk1qZm5JSlF2?= =?utf-8?Q?kWks=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbd9d294-8690-4732-68aa-08dbe5113c91 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2023 12:57:19.8870 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EWijChEkvsPwti6q1H9p2zBaIEC/dAwK/9QKlwN2zSVh3VEzgJC5SwN4a3olM+bM X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6741 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/14/2023 2:41 AM, Guo, Junfeng wrote: > > >> -----Original Message----- >> From: Joshua Washington >> Sent: Tuesday, November 14, 2023 07:12 >> To: Guo, Junfeng ; Jeroen de Borst >> ; Rushil Gupta ; Joshua >> Washington ; Li, Xiaoyun >> Cc: dev@dpdk.org; stable@dpdk.org; Ferruh Yigit >> Subject: [PATCH v2] net/gve: fix RX buffer size alignment >> >> In GVE, both queue formats have RX buffer size alignment requirements >> which will not always be respected when a user specifies an mbuf size. >> Assuming that an mbuf size is greater than the DPDK recommended default >> (2048 + 128), if the buffer size is not properly aligned with what the >> device expects, the device will silently fail to create any transmit or >> receive queues. >> >> Because no queues are created, there is no network traffic for the DPDK >> program, and errors like the following are returned when attempting to >> destroy queues: >> >> gve_adminq_parse_err(): AQ command failed with status -11 >> gve_stop_tx_queues(): failed to destroy txqs >> gve_adminq_parse_err(): AQ command failed with status -11 >> gve_stop_rx_queues(): failed to destroy rxqs >> >> This change aims to remedy this by restricting the RX receive buffer >> sizes to valid sizes for their respective queue formats, including both >> alignment and minimum and maximum supported buffer sizes. >> >> Fixes: 4bec2d0b5572 ("net/gve: support queue operations") >> Fixes: 1dc00f4fc74b ("net/gve: add Rx queue setup for DQO") >> Cc: junfeng.guo@intel.com >> Cc: stable@dpdk.org >> >> Signed-off-by: Joshua Washington >> Reviewed-by: Rushil Gupta > > Acked-by: Junfeng Guo > Applied to dpdk-next-net/main, thanks.