From: Ferruh Yigit <ferruh.yigit@intel.com> To: Ori Kam <orika@nvidia.com>, Gregory Etelson <getelson@nvidia.com> Cc: "ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>, "andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>, "dev@dpdk.org" <dev@dpdk.org>, "jerinj@marvell.com" <jerinj@marvell.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, NBU-Contact-Thomas Monjalon <thomas@monjalon.net>, Slava Ovsiienko <viacheslavo@nvidia.com>, Xiaoyun Li <xiaoyun.li@intel.com> Subject: Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add support for integrity item Date: Tue, 13 Apr 2021 09:14:11 +0100 Message-ID: <8bcfa23e-e7bc-09fc-eb83-f5637e41110d@intel.com> (raw) In-Reply-To: <BYAPR12MB4983B47B45FAE3AB534F2C0FD64F9@BYAPR12MB4983.namprd12.prod.outlook.com> On 4/13/2021 8:53 AM, Ori Kam wrote: > Hi Ferruh, > >> -----Original Message----- >> From: Ferruh Yigit <ferruh.yigit@intel.com> >> >> On 4/11/2021 6:34 PM, Gregory Etelson wrote: >>> From: Ori Kam <orika@nvidia.com> >>> >>> The integrity item allows the application to match >>> on the integrity of a packet. >>> >>> use example: >>> match that packet integrity checks are ok. The checks depend on >>> packet layers. For example ICMP packet will not check L4 level. >>> flow create 0 ingress pattern integrity value mask 0x01 value spec 0x01 >>> match that L4 packet is ok - check L2 & L3 & L4 layers: >>> flow create 0 ingress pattern integrity value mask 0xfe value spec 0xfe >>> >>> Signed-off-by: Ori Kam <orika@nvidia.com> >>> Signed-off-by: Gregory Etelson <getelson@nvidia.com> >>> --- >>> v2 add testpmd patch >>> --- >>> app/test-pmd/cmdline_flow.c | 39 >> +++++++++++++++++++++++++++++++++++++ >> >> Hi Gregory, Ori, >> >> Can you add some samples to "testpmd_funcs.rst#flow-rules-management"? >> >> I asked in some other thread but did not get any response, what do you think to >> make 'testpmd_funcs.rst' sample update mandatory when testpmd flow added? >> > I fully agree that each new function should be mandatory, What is new function here, new flow API? That should go to flow API documentation, 'rte_flow.rst'. > The question is do we want that each new item / action (they use existing function) > I think it is a bit of overhead but I don't have strong opinion. > Since the documentation is for the testpmd usage sample, I was thinking to add sample for each new item & action indeed. Same of the flow rules not widely used, and it is not always clear how to use them, that is why I believe documenting samples can help. >> >>> 1 file changed, 39 insertions(+) >>> >>> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c >>> index fb7a3a8bd3..b5dec34325 100644 >>> --- a/app/test-pmd/cmdline_flow.c >>> +++ b/app/test-pmd/cmdline_flow.c >>> @@ -289,6 +289,9 @@ enum index { >>> ITEM_GENEVE_OPT_TYPE, >>> ITEM_GENEVE_OPT_LENGTH, >>> ITEM_GENEVE_OPT_DATA, >>> + ITEM_INTEGRITY, >>> + ITEM_INTEGRITY_LEVEL, >>> + ITEM_INTEGRITY_VALUE, >>> >>> /* Validate/create actions. */ >>> ACTIONS, >>> @@ -956,6 +959,7 @@ static const enum index next_item[] = { >>> ITEM_PFCP, >>> ITEM_ECPRI, >>> ITEM_GENEVE_OPT, >>> + ITEM_INTEGRITY, >>> END_SET, >>> ZERO, >>> }; >>> @@ -1307,6 +1311,19 @@ static const enum index item_geneve_opt[] = { >>> ZERO, >>> }; >>> >>> +static const enum index item_integrity[] = { >>> + ITEM_INTEGRITY_LEVEL, >>> + ITEM_INTEGRITY_VALUE, >>> + ZERO, >>> +}; >>> + >>> +static const enum index item_integrity_lv[] = { >>> + ITEM_INTEGRITY_LEVEL, >>> + ITEM_INTEGRITY_VALUE, >>> + ITEM_NEXT, >>> + ZERO, >>> +}; >>> + >>> static const enum index next_action[] = { >>> ACTION_END, >>> ACTION_VOID, >>> @@ -3373,6 +3390,28 @@ static const struct token token_list[] = { >>> (sizeof(struct rte_flow_item_geneve_opt), >>> ITEM_GENEVE_OPT_DATA_SIZE)), >>> }, >>> + [ITEM_INTEGRITY] = { >>> + .name = "integrity", >>> + .help = "match packet integrity", >>> + .priv = PRIV_ITEM(INTEGRITY, >>> + sizeof(struct rte_flow_item_integrity)), >>> + .next = NEXT(item_integrity), >>> + .call = parse_vc, >>> + }, >>> + [ITEM_INTEGRITY_LEVEL] = { >>> + .name = "level", >>> + .help = "integrity level", >>> + .next = NEXT(item_integrity_lv, NEXT_ENTRY(UNSIGNED), >>> + item_param), >>> + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_integrity, >> level)), >>> + }, >>> + [ITEM_INTEGRITY_VALUE] = { >>> + .name = "value", >>> + .help = "integrity value", >>> + .next = NEXT(item_integrity_lv, NEXT_ENTRY(UNSIGNED), >>> + item_param), >>> + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_integrity, >> value)), >>> + }, >>> /* Validate/create actions. */ >>> [ACTIONS] = { >>> .name = "actions", >>> >
next prev parent reply other threads:[~2021-04-13 8:14 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-05 18:04 [dpdk-dev] [PATCH] ethdev: add packet integrity checks Ori Kam 2021-04-06 7:39 ` Jerin Jacob 2021-04-07 10:32 ` Ori Kam 2021-04-07 11:01 ` Jerin Jacob 2021-04-07 22:15 ` Ori Kam 2021-04-08 7:44 ` Jerin Jacob 2021-04-11 4:12 ` Ajit Khaparde 2021-04-11 6:03 ` Ori Kam 2021-04-13 15:16 ` [dpdk-dev] [PATCH v3 0/2] " Gregory Etelson 2021-04-13 15:16 ` [dpdk-dev] [PATCH v3 1/2] ethdev: " Gregory Etelson 2021-04-13 15:16 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add support for integrity item Gregory Etelson 2021-04-13 17:15 ` Ferruh Yigit 2021-04-14 12:56 ` [dpdk-dev] [PATCH v4 0/2] add packet integrity checks Gregory Etelson 2021-04-14 12:56 ` [dpdk-dev] [PATCH v4 1/2] ethdev: " Gregory Etelson 2021-04-14 13:27 ` Ferruh Yigit 2021-04-14 13:31 ` Ferruh Yigit 2021-04-14 12:57 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: add support for integrity item Gregory Etelson 2021-04-14 16:09 ` [dpdk-dev] [PATCH v5 0/2] add packet integrity checks Gregory Etelson 2021-04-14 16:09 ` [dpdk-dev] [PATCH v5 1/2] ethdev: " Gregory Etelson 2021-04-14 17:24 ` Ajit Khaparde 2021-04-15 15:10 ` Ori Kam 2021-04-15 15:25 ` Ajit Khaparde 2021-04-15 16:46 ` Thomas Monjalon 2021-04-16 7:43 ` Ori Kam 2021-04-18 8:15 ` Gregory Etelson 2021-04-18 18:00 ` Thomas Monjalon 2021-04-14 16:09 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: add support for integrity item Gregory Etelson 2021-04-14 16:26 ` [dpdk-dev] [PATCH v5 0/2] add packet integrity checks Ferruh Yigit 2021-04-18 15:51 ` [dpdk-dev] [PATCH v6 " Gregory Etelson 2021-04-18 15:51 ` [dpdk-dev] [PATCH v6 1/2] ethdev: " Gregory Etelson 2021-04-18 18:11 ` Thomas Monjalon 2021-04-18 19:24 ` Gregory Etelson 2021-04-18 21:30 ` Thomas Monjalon 2021-04-18 15:51 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: add support for integrity item Gregory Etelson 2021-04-19 8:29 ` [dpdk-dev] [PATCH v7 0/2] add packet integrity checks Gregory Etelson 2021-04-19 8:29 ` [dpdk-dev] [PATCH v7 1/2] ethdev: " Gregory Etelson 2021-04-19 8:47 ` Thomas Monjalon 2021-04-19 8:29 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: add support for integrity item Gregory Etelson 2021-04-19 11:20 ` [dpdk-dev] [PATCH v7 0/2] add packet integrity checks Ferruh Yigit 2021-04-19 12:08 ` Gregory Etelson 2021-04-19 12:44 ` [dpdk-dev] [PATCH v8 " Gregory Etelson 2021-04-19 12:44 ` [dpdk-dev] [PATCH v8 1/2] ethdev: " Gregory Etelson 2021-04-19 14:09 ` Ajit Khaparde 2021-04-19 16:34 ` Thomas Monjalon 2021-04-19 17:06 ` Ferruh Yigit 2021-04-19 12:44 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: add support for integrity item Gregory Etelson 2021-04-19 14:09 ` Ajit Khaparde 2021-04-08 8:04 ` [dpdk-dev] [PATCH] ethdev: add packet integrity checks Andrew Rybchenko 2021-04-08 11:39 ` Ori Kam 2021-04-09 8:08 ` Andrew Rybchenko 2021-04-11 6:42 ` Ori Kam 2021-04-11 17:30 ` Ori Kam 2021-04-11 17:34 ` [dpdk-dev] [PATCH v2 0/2] " Gregory Etelson 2021-04-11 17:34 ` [dpdk-dev] [PATCH v2 1/2] ethdev: " Gregory Etelson 2021-04-12 17:36 ` Ferruh Yigit 2021-04-12 19:26 ` Ori Kam 2021-04-12 23:31 ` Ferruh Yigit 2021-04-13 7:12 ` Ori Kam 2021-04-13 8:03 ` Ferruh Yigit 2021-04-13 8:18 ` Ori Kam 2021-04-13 8:30 ` Ferruh Yigit 2021-04-13 10:21 ` Ori Kam 2021-04-13 17:28 ` Ferruh Yigit 2021-04-11 17:34 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add support for integrity item Gregory Etelson 2021-04-12 17:49 ` Ferruh Yigit 2021-04-13 7:53 ` Ori Kam 2021-04-13 8:14 ` Ferruh Yigit [this message] 2021-04-13 11:36 ` Ori Kam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8bcfa23e-e7bc-09fc-eb83-f5637e41110d@intel.com \ --to=ferruh.yigit@intel.com \ --cc=ajit.khaparde@broadcom.com \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=dev@dpdk.org \ --cc=getelson@nvidia.com \ --cc=jerinj@marvell.com \ --cc=olivier.matz@6wind.com \ --cc=orika@nvidia.com \ --cc=thomas@monjalon.net \ --cc=viacheslavo@nvidia.com \ --cc=xiaoyun.li@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git