From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B784BA0471 for ; Thu, 20 Jun 2019 11:44:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4455A1D07A; Thu, 20 Jun 2019 11:44:15 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D29461D057; Thu, 20 Jun 2019 11:44:13 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 59BACC05B1CD; Thu, 20 Jun 2019 09:44:05 +0000 (UTC) Received: from [10.36.112.46] (ovpn-112-46.ams2.redhat.com [10.36.112.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7A4461001DE7; Thu, 20 Jun 2019 09:44:01 +0000 (UTC) To: Fan Zhang , dev@dpdk.org Cc: stable@dpdk.org References: <20190515162548.71498-1-roy.fan.zhang@intel.com> From: Maxime Coquelin Message-ID: <8bd6f9c1-b788-b569-ec9b-1bececa2bf5f@redhat.com> Date: Thu, 20 Jun 2019 11:43:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190515162548.71498-1-roy.fan.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 20 Jun 2019 09:44:13 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/15/19 6:25 PM, Fan Zhang wrote: > This patch tries to fix the coverity issue of unchecked > return value. Since the function that causes the problem > is unused, it is removed completely. > > Coverity issue: 336816 > Fixes: f5188211c721 ("examples/vhost_crypto: add sample application") > Cc: stable@dpdk.org > > Signed-off-by: Fan Zhang > --- > examples/vhost_crypto/main.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c > index ac7118e7e..cfb9dfda2 100644 > --- a/examples/vhost_crypto/main.c > +++ b/examples/vhost_crypto/main.c > @@ -354,12 +354,6 @@ static const struct vhost_device_ops virtio_crypto_device_ops = { > .destroy_device = destroy_device, > }; > > -__attribute__((unused)) > -static void clrscr(void) > -{ > - system("@cls||clear"); > -} > - > static int > vhost_crypto_worker(void *arg) > { > Reviewed-by: Maxime Coquelin I'll change the title to: examples/vhost_crypto: remove unused function