From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4265842CC4; Thu, 15 Jun 2023 11:36:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C72BE40DDA; Thu, 15 Jun 2023 11:36:10 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2055.outbound.protection.outlook.com [40.107.93.55]) by mails.dpdk.org (Postfix) with ESMTP id AE3BB40A84 for ; Thu, 15 Jun 2023 11:36:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K6/2fEkdJVyDZViTcyDzB6X+kTd6Zhvh+VlFJJUhFuv49dbSHENtOVimpbFRjP5xYwSpTr7nZYr6bPHwAahwyegtQTkFbEjGjSMJxxRvs9fhqHmlpOQYkOk6vDDuZ6bDQ3Yoxi/M6m9IHxcrxTBrDzOkfZQ8ZMoojwYvVxHVLnLpsO0s2zlVJtTbEf0z34HM1fB2lDTaDdPK+bilbElT503pfUMDz0h/Go8HKTHTVwWYTLOrhe9Z3jp4qtWYCURmJLqtPCRb3yvVwQ0L8rAaPiNetDnX2oVktSSytXtBcWq1FJBGdlTe1OWkutETX4UU6iOQXsYKyzQ6vU32BrpegQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qUl6n2Ews7bkG0GOsd1HsvA8dT430s41mRV4rcMcQW0=; b=LmGJh0720BM+AnXdJbr15NrEmUxWn/4cYUXXJVhNqo6WxNjU4gOV4VF4WCNhnQ0181DN3QQlciLMY5jDpxA0YxiMpN4x0rNbYDfD4tCYhiWeFK4Idx3LWxkdmfJcO67Mync6uYnil+5kPEdopmATSN/vgBApQu67lxk2eDebtA0rV/VG5Pgg51Odn8gfRnhDb9LCKAxRZm1j2s738DXt/N5I+bpVJuTi1jXN5WNgTQmFH/6F+kVBmxrK53sYvPJfw1QB+0040NKkOC+IXQwC2fNkgAtzQqtMJJDJDHkgfXXS8LUKCKAkqg39a/4zSgSkB5dBznUB+54j/j+4+bBT/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qUl6n2Ews7bkG0GOsd1HsvA8dT430s41mRV4rcMcQW0=; b=A5Oaf8ZEdm95yU59PRd6zwrS5jA4ONmIk8QL86PkbdErDR7j6Yrhv87Fpy0tpBbRazBnJhYIFU4KEsxUkA5CXX+ymoYTcVR6PwGrPh2lFt5yYarG6bxCEJcF9fTl1ggZ1MlOeHNqncZy4GYEyMc38+6IpEg6bYj15qfkCTJwWlE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB8308.namprd12.prod.outlook.com (2603:10b6:610:131::8) by PH7PR12MB7939.namprd12.prod.outlook.com (2603:10b6:510:278::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Thu, 15 Jun 2023 09:36:06 +0000 Received: from CH3PR12MB8308.namprd12.prod.outlook.com ([fe80::e452:1914:1054:de79]) by CH3PR12MB8308.namprd12.prod.outlook.com ([fe80::e452:1914:1054:de79%7]) with mapi id 15.20.6477.028; Thu, 15 Jun 2023 09:36:05 +0000 Message-ID: <8bea71ab-1929-7ff1-07c2-5f51ab04df75@amd.com> Date: Thu, 15 Jun 2023 15:05:52 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] bus/cdx: Remove ineffective code statement Content-Language: en-US To: Abhijit Gangurde , nikhil.agarwal@amd.com Cc: dev@dpdk.org, david.marchand@redhat.com, ferruh.yigit@amd.com References: <20230614102201.224495-1-abhijit.gangurde@amd.com> From: Nipun Gupta In-Reply-To: <20230614102201.224495-1-abhijit.gangurde@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PR01CA0144.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:6::29) To CH3PR12MB8308.namprd12.prod.outlook.com (2603:10b6:610:131::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB8308:EE_|PH7PR12MB7939:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ab97de0-30e0-4748-b98f-08db6d83f107 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jk19umXII9kI+Hn6fizaXi2wXvnZwiGkq+mSZIuGKpkds2GtRLdk2y0SpzHqXnFqDegI26Wfj+j4rh97TB6ad4P9qeI1HUSXwpPY955SS8FNQR2jHq6LL6a2Jl1B3VCMPeCgjYQ11EsOMY5BSL0skxWtVxlnYn5GlXs0F0UsrRtHGK321EKkR3G8uuz75kznLUjyj7mwVFtPi2Cm7VpsSG6UmUY2gZrXl/+gR0S2bUPxZ658BCKn5u55PZWahhtrTSY35GVkqrnTBhw6VIapsqgGGlpDXr/rB8e3vUoLEJnSH1wfLkQjNxv0bLyidaRUWkyva5NaS2VXY0XlP2CQCkw7D+p1BGeatR0SRJnlCz5nOrGy6ocTTsj3/BIWVzoiIFGmp1qmtE/mujqDn9tPvNDS/yLGVJnGlhiZEMp8HVh5Vahm3Ey3OsLLqONYkFNwo0+/bG7uDNJSbOXiI+i7Fz9WZoBCPMW/qASCPX1vTqSXD/y7ByO/gPznjohlAGLSLEup935bIeDr8dF37I+vR4aYK+fOCcsIWJ52PqM1sSS28ec5Tfr6oeTKtiUZHrNqzhiKfuvNUSdYftGNJhMAfHkBafZV8Tsv4kYKyA85V4oDt8EVOQUKNgMhjPFl82sjryLxdpBhhyWOj0QzbbQ6uw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8308.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(39860400002)(396003)(366004)(376002)(136003)(451199021)(8676002)(4744005)(8936002)(2906002)(5660300002)(66556008)(316002)(66946007)(31686004)(6636002)(66476007)(4326008)(38100700002)(41300700001)(2616005)(36756003)(83380400001)(186003)(478600001)(53546011)(6512007)(26005)(6666004)(6506007)(6486002)(44832011)(31696002)(86362001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2NJQXowaWZJVWNyVStMaGlZenBPQUtPYTMvNlJNSmpZSS9KWVZMZEhFV2JQ?= =?utf-8?B?TlRxekF2SDZNMHhqandtVmxKam55Z3NRbmFJQWlHSTRuMDVEdGR3WTZHdmxo?= =?utf-8?B?am01T0p3Z3Z4NVliRXlhS3J6Sis1dTh0MVVuWVdCTHFiRTVhN3l6Slp4SWpN?= =?utf-8?B?V2hEeHJiWHBhV3V6anVGdXh3d1VyRUFYVVhZUmZPTktOeUM5eGRFUkFPUUds?= =?utf-8?B?eEszSTVGenBBTUVBVzBJMW9mVmsyRWpHSVBIeTM5WGkwWnZmaG12QnozLy9i?= =?utf-8?B?S0FNSUpMdzZsN0J1UEgxbkcwdmZQcnhjUHBlYXBuYm9WUXRYSWhaT0x2WUNo?= =?utf-8?B?OTlITzlrN3ZSUHNRRkVyQU9wOWhYcWpsT0dkbjRUcVBZaDgvblpHN0FnRlQv?= =?utf-8?B?QTdzc3lNS2ZBOW5wYTkwWGd4RWg1MWRkZEZXODRDeG52SUxMdkpDWVQ2eWdX?= =?utf-8?B?UE51TzJueis3OFZQT1FPY3dyN2hLNWw0L1FxdDM0UEw3cjkrclVyQ0VJTGVC?= =?utf-8?B?RTEvamhsQU5zNTRVRC95MGJ6cThjZm9QRXlBTFYxZVVGVFJ3aCtWOThLSkts?= =?utf-8?B?REpxam9YZ1Fxa2w4emNzeFpkeEMzYUdBdXBWZVlqK3BGWDRJWGtpVHZjTzU5?= =?utf-8?B?cnNtcWJCK0hEbWgweU9oVUU0WHI3VkJvc0xnQXZQRnNHc3JOMUZlOUNUQ20z?= =?utf-8?B?V0pxemcwTXhxRWg1YkdjK016NjZoMlFMU3orZURZZkc3UzNIRENYcnhta3cx?= =?utf-8?B?dlJrTHVqRSs2UmxZWUJzNi9iMitJekRnSmhtQk55cW05QmJjQ2Nld1VMNWx5?= =?utf-8?B?eXBBNE5OWWNERHZzeEU2YXc0NE9nNkdWUlF3Ny9hS1pubnJic3ZramxrSzNh?= =?utf-8?B?VWpvSHdiL3kyK3RsbzJLKzVZdENwRGpLK3RHeEdjM0VxTm52MzA2RW5oeWQz?= =?utf-8?B?ZmdKUWlGVS9FUGh5bS9BYkZ3d0syaGY5bTR2RUFBbXNwbWhoaEdjUmt1WnJi?= =?utf-8?B?Tkk3T003MWIrMUVTUHpJRFhVSzJ3MkFhUGptWlNveGlRYXVhTTF6ZXFERmNI?= =?utf-8?B?WDBweEdYSmxTSnFuT3NQOGZSbGVWNHVVOWJGLzJHUHNpYUJxMzVLdWZhejNB?= =?utf-8?B?ZHVzZlRxMVM0K2NDVFhBWWxDWlJkVjcydE1rN1Nlb2Z1TURHbXdXQ2VXck5k?= =?utf-8?B?VHFlSmRTRjN6ODZWcUJUQkgrWTZLVkMvNHFRZmFGTHcxWmtsZlFrYUI0ZkxW?= =?utf-8?B?VlRQM1k1YUFnaVNaMEdxbE04MFZzdU11ZTRGdVdjN1J1TWV6Y2ZuMHcyZXFk?= =?utf-8?B?ZGh3TndDSWtqalhHOFVJK1N3aTlmMk0rZ1l1eG16Zm9PNFZMMXU5bElvT1VQ?= =?utf-8?B?cEZtTFh4THhEMWRBN1dmb2gwY2wyNzBkZHA0aHJyeDgxK2tMeWNicnEzMFpa?= =?utf-8?B?SnMwOXJNY2FnTkpXWk9jYW5SK0FiSTRIdUdORVhTZUJEYVpOaExqdnN3azND?= =?utf-8?B?TVpYMVA3Nnl4UEt0emxWc0Z4S2lDNzl2REpVWVJTOHY1enlQbUQ3SGZ5b1V0?= =?utf-8?B?NmtpODFhWW1IeTdxaGtnS3RDSU9XSkxSbkxmUWZCQmJyeEgydTc3S3lQSms0?= =?utf-8?B?ek0zNHM2UlpydEVLV25kTnpvWHFENndCQ0sycXVOVDVpemtlQlFJc1BPWlNY?= =?utf-8?B?ekFNMHUvUnZjMno3YTQ2em8zMEdjVWZ5b1ovcm1ENktZMzBROEFOVGxVTjdw?= =?utf-8?B?MHJoTTQ3TzI4TjBUdW43bkpnSStLYU42OHVRTlJUMzVMdFdLQmJyNTBGeUQ3?= =?utf-8?B?OHVrS29IK2YvVDkyN3lTUmhOcm8wbzkraUd4cy9lM0h2ZDJRK21GcGk3WTR2?= =?utf-8?B?ejArR05BZHRiRHdTR0VoSWdiWThGSFAzeUl5NVBabE1FekhCUllGY1lCMHFN?= =?utf-8?B?N0ozdSs5eUo2UENCeUZMUFZvSW83bUF1ZUUrUGNVYUhibDR0ejcvU2JVMisr?= =?utf-8?B?RzJISjdEclhoYU01ZEhtemdQcU1jK3l0NWx6MWVKZ1daTkFENVdCcXAySFhr?= =?utf-8?B?Rlc5Nm5KcnhrMHdxMzIyeGlxSHVKT2tTSzh5N1V5TDVlVFlpa29LM2dBcFRy?= =?utf-8?Q?1juY7BFsg1bfcguKqjiNtsOm1?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ab97de0-30e0-4748-b98f-08db6d83f107 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8308.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 09:36:05.8536 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H6gM/ExVK+yYHEo2ujc7dbc8WgXz+elPtvZIDt/hDsQBcZQW0ri+P03xZ7gbj8x8 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7939 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Nipun Gupta On 6/14/2023 3:52 PM, Abhijit Gangurde wrote: > ret = 0 statement is ineffective since it is overwritten in a loop. > > Coverity issue: 385379 > Fixes: 45ef232af515 ("bus/cdx: introduce AMD CDX bus") > Signed-off-by: Abhijit Gangurde > --- > drivers/bus/cdx/cdx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c > index 28bbf92ed5..9130c30515 100644 > --- a/drivers/bus/cdx/cdx.c > +++ b/drivers/bus/cdx/cdx.c > @@ -452,7 +452,6 @@ cdx_probe(void) > dev->name); > rte_errno = errno; > failed++; > - ret = 0; > } > } >