From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E499D4282E; Fri, 24 Mar 2023 10:40:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BED63406B8; Fri, 24 Mar 2023 10:40:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 708F24021F for ; Fri, 24 Mar 2023 10:40:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679650821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L+LjObSPQKgu4YnXUA/wW2Al6rCVxwmYxUJ9MzwGang=; b=F5FheA/v6wbrZ2Sf4MESJpaxCmHdQ3Zc5x+9fF3ONvHTgfkHt4Exy2+C4IvJpMQdE2lU+J qlPh7dkkP0AxaslSeZeaJj3w1wFAsMZYjI/9PclOjnS4M9btgSSMI0M1quA5sYWPS4zVBT qB2sd0uAivcXPZaprpLYdEu1XglUW6U= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-216-o2U-itzBOu6q3XK26uscUg-1; Fri, 24 Mar 2023 05:40:20 -0400 X-MC-Unique: o2U-itzBOu6q3XK26uscUg-1 Received: by mail-wm1-f72.google.com with SMTP id bg7-20020a05600c3c8700b003ee86f5a756so2324824wmb.6 for ; Fri, 24 Mar 2023 02:40:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679650819; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L+LjObSPQKgu4YnXUA/wW2Al6rCVxwmYxUJ9MzwGang=; b=l3GIQrGpD08APO3ewDP3+XBZW9M6/OCk8goElZ3cwDRBBKX+w78kGC9pJN1JbXzzJH tvxjkZMRMdXYAFejVqbTNepaZMp3Qk1xF9ztSCBQW3GjAPyVuNHZiQwLNi+EzByQK2sM IxUhCcaio60SmETe6KHpOeZ3RK2GSXB00w3fxXAjdAoy595hqylBuPVQ+GDlGh07JetF TCn31DPfhPEpgcz+lR66Gt5HUti3opqZgrHFQ97cElMhZmq0g3nhah7GF36uTnjmZg1u kiZT6r95nzDiId+2XcWQduZ2nazBFs4+2mTa12bpAECCCt2VboTy9IiQKhfsl5GgTX82 q2VQ== X-Gm-Message-State: AAQBX9e3zX8ziYiaIjhe+e6G7NRbg9h/V5LY1amkldsVxbj+qIL17kyp vWtpMQ9U/oWXjrB0qDUHp3qTlmPVvtdOSiWcXjW67u1G4/Qxu2G7Z5WzriCf5jzXFZjZQJNAg3X KO/Y= X-Received: by 2002:a5d:5257:0:b0:2dc:c45:faf6 with SMTP id k23-20020a5d5257000000b002dc0c45faf6mr1541282wrc.51.1679650819550; Fri, 24 Mar 2023 02:40:19 -0700 (PDT) X-Google-Smtp-Source: AKy350YEjxKb9rWzZBbjrR2JLiLcMcXJ2/Iu2ovyc59dQGh9nzQTOVJWN7JZUg00GtpigCYk6AinUA== X-Received: by 2002:a5d:5257:0:b0:2dc:c45:faf6 with SMTP id k23-20020a5d5257000000b002dc0c45faf6mr1541258wrc.51.1679650819296; Fri, 24 Mar 2023 02:40:19 -0700 (PDT) Received: from [192.168.0.36] ([78.19.103.115]) by smtp.gmail.com with ESMTPSA id t14-20020a05600001ce00b002da76acfee1sm5673178wrx.28.2023.03.24.02.40.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 02:40:18 -0700 (PDT) Message-ID: <8c07a9b9-033e-8069-dcd2-52b41d4b036a@redhat.com> Date: Fri, 24 Mar 2023 09:40:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: "Jiang, YuX" , "Zhang, Qi Z" , "Su, Simei" , "Xing, Beilei" , "Zhang, Yuying" , "david.marchand@redhat.com" Cc: "dev@dpdk.org" , "Yang, Qiming" , "stable@dpdk.org" , Luca Boccassi , "Mcnamara, John" References: <20230202123632.56730-1-simei.su@intel.com> <20230220075952.444153-1-simei.su@intel.com> <8fecda8e-15b4-63e0-f319-6e4a4a5edf83@redhat.com> <9aa3b88a-5e2f-d857-b554-d88a572b46b2@redhat.com> From: Kevin Traynor Subject: Re: [PATCH v6] net/i40e: rework maximum frame size configuration In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 24/03/2023 06:32, Jiang, YuX wrote: >> -----Original Message----- >> From: Kevin Traynor >> Sent: Thursday, March 23, 2023 10:51 PM >> To: Zhang, Qi Z ; Su, Simei ; Xing, >> Beilei ; Zhang, Yuying ; >> david.marchand@redhat.com; Jiang, YuX >> Cc: dev@dpdk.org; Yang, Qiming ; stable@dpdk.org; >> Luca Boccassi ; Mcnamara, John >> >> Subject: Re: [PATCH v6] net/i40e: rework maximum frame size configuration >> >> On 22/03/2023 16:50, Kevin Traynor wrote: >>> On 27/02/2023 00:35, Zhang, Qi Z wrote: >>>> >>> >>> Hi Simei/Qi/Yu >>> >> >> Hi Yu, >> >>>> >>>>> -----Original Message----- >>>>> From: Su, Simei >>>>> Sent: Monday, February 20, 2023 4:00 PM >>>>> To: Xing, Beilei ; Zhang, Yuying >>>>> ; Zhang, Qi Z ; >>>>> david.marchand@redhat.com >>>>> Cc: dev@dpdk.org; Yang, Qiming ; Su, Simei >>>>> ; stable@dpdk.org >>>>> Subject: [PATCH v6] net/i40e: rework maximum frame size >>>>> configuration >>>>> >>>>> One issue is reported by David Marchand that error occurs in OVS due >>>>> to the fix patch in mentioned changes below. The detailed reproduce >>>>> step and result are in >>>>> https://patchwork.dpdk.org/project/dpdk/patch/ >>>>> 20211207085946.121032-1-dapengx.yu@intel.com/. >>>>> >>>>> This patch removes unnecessary link status check and directly sets >>>>> mac config in dev_start. Also, it sets the parameter "wait to >>>>> complete" true to wait for more time to make sure adminq command >> execute completed. >>>>> >>> >>>>> Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port >>>>> level") >>>>> Fixes: 2184f7cdeeaa ("net/i40e: fix max frame size config at port >>>>> level") >>>>> Fixes: 719469f13b11 ("net/i40e: fix jumbo frame Rx with X722") >>>>> Cc: stable@dpdk.org >>> >>> These patches caused an observable regression in multiple 20.11 and >>> 21.11 LTS releases that was only caught a long time after releases. >>> >>> Is there anything being added to LTS validation for regression testing >>> this issue, so we don't get caught again? >>> >> >> This is the issue I was talking about earlier during the release meeting. Not sure >> if we were talking about the same patch. >> >> I was asking if there are some regression tests added/can be added to LTS >> validation that will be run during each LTS validation cycle so we don't have any >> more regressions on it. >> > Hi Kevin, > Thanks for your comments. > Yes. We are adding additional case to cover more testing. For main branch, we have done the regression testing (including the additional case testing), they both work well. That's good to hear. Will the additional regression tests also be added to the LTS validation tests when they are run? > We hope the two related patches can be backported to LTS branch, and the second patch just reworks for previous bug's fix. > Patch1: https://patchwork.dpdk.org/project/dpdk/patch/20221213091837.87953-1-david.marchand@redhat.com/ a8ca8ed net/i40e: revert link status check on device start I have already reverted those 3 backports on 21.11 branch so this is not needed. > Pathc2: https://patchwork.dpdk.org/project/dpdk/patch/20230306121853.27547-1-simei.su@intel.com/ 82fcf20 net/i40e: fix maximum frame size configuration > That is the v7 of this v6 with revert and fix split, so same one being discussed above. > Best regards, > Yu Jiang > >> thanks, >> Kevin. >> >>> After reverting the original patch and 2 fixes, I'm a bit reluctant to >>> take more fixes without some form of regression testing in place. >>> >>> thanks, >>> Kevin. >>> >>>>> >>>>> Reported-by: David Marchand >>>>> Signed-off-by: Simei Su >>>> >>>> Acked-by: Qi Zhang >>>> >>>> Applied to dpdk-next-net-intel. >>>> >>>> Thanks >>>> Qi >>>> >>> >