From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AEAEA0613 for ; Thu, 26 Sep 2019 14:47:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D922E2C6A; Thu, 26 Sep 2019 14:47:03 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 41D8D2C52 for ; Thu, 26 Sep 2019 14:47:02 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id B5288140082; Thu, 26 Sep 2019 12:47:00 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 26 Sep 2019 13:46:56 +0100 To: Stephen Hemminger , References: <20190811160607.16441-1-stephen@networkplumber.org> <20190919131729.28681-1-stephen@networkplumber.org> <20190919131729.28681-2-stephen@networkplumber.org> From: Andrew Rybchenko Message-ID: <8c2d6a91-f5f1-57e0-61f7-8d07542ae305@solarflare.com> Date: Thu, 26 Sep 2019 15:46:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20190919131729.28681-2-stephen@networkplumber.org> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24934.003 X-TM-AS-Result: No-10.633600-8.000000-10 X-TMASE-MatchedRID: VfovoVrt/obmLzc6AOD8DfHkpkyUphL9FSZQHXjjSNzdEZKQ2x9p3j5Q FsH1QNsOZwIwfmervitD0wfWXDoBOlPnI9A/227jA9lly13c/gHUk/02d006RVIxScKXZnK0o4i sov7KdCQov19Y/AcXlqmTdNOW2mzxuY1NuNzmU+fBtFDYGmaWKjcy5Kr1d07TDC/Vm90If4UVcJ R4XudE5kXMeswpFkgKHcN4x+ltYL1zySdTkJm1SnEFgt4Wa1LtLZWWNVgH0Y3ZhqPLU/1bVd0pR IFbsjfbb7mJ6HbhlhGRk6XtYogiau9c69BWUTGwVnRXm1iHN1bZs3HUcS/scLyah9aCYUCHPhJc oM5JoaXElHbO6DVrkEXdmYeWYXMBzONq3CitPVcJ4cRFh/TuefVt5hgJDqRnUIoBRurFkLquGE/ XQCRdgc6hIOanHZpS X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--10.633600-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24934.003 X-MDID: 1569502021-hVeRlCsvlXq2 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v5 1/2] ethdev: expose basic xstats for driver use X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/19/19 4:17 PM, Stephen Hemminger wrote: > Avoid duplication by having generic basic xstats available > for use by drivers. A later patch uses this for failsafe > driver. > > Signed-off-by: Stephen Hemminger > Acked-by: Gaetan Rivet Acked-by: Andrew Rybchenko > diff --git a/lib/librte_ethdev/rte_ethdev_driver.h b/lib/librte_ethdev/rte_ethdev_driver.h > index 936ff8c98651..489889a72203 100644 > --- a/lib/librte_ethdev/rte_ethdev_driver.h > +++ b/lib/librte_ethdev/rte_ethdev_driver.h > @@ -208,6 +208,71 @@ rte_eth_linkstatus_get(const struct rte_eth_dev *dev, > #endif > } > > +/** > + * @internal > + * Get basic stats part of xstats for an ethernet device. > + * > + * @param dev > + * Pointer to struct rte_eth_dev. > + */ > +__rte_experimental Does it make sense to mark internal API as experimental? I thought that @internal is not a part of API/ABI. [snip]