From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9EDEDA09EA; Wed, 9 Dec 2020 13:03:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F3795BE73; Wed, 9 Dec 2020 13:03:20 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D60072B8B for ; Wed, 9 Dec 2020 13:03:18 +0100 (CET) IronPort-SDR: 8O/vB+nsCnfn270PhKUsFmAJqzV5Es9J3gEOqZm3jpG8iflBxuMo3oMxYHSg+4zMWnTUJ/vPaA mBN3L3rkRzrQ== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="171492451" X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="171492451" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 04:03:17 -0800 IronPort-SDR: 6j4Psdc737l3zbGtbxbc6cI/mQDHTSgPqLGjRaXBwm1EURMWULncFv3r/D5m2zLRIuCocLJmJC KgrC582n66rg== X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="437763972" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.215.89]) ([10.213.215.89]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 04:03:16 -0800 To: Andrew Boyer , dev@dpdk.org Cc: Alfredo Cardigliano References: <20201203203418.15064-1-aboyer@pensando.io> <20201204201646.51746-4-aboyer@pensando.io> From: Ferruh Yigit Message-ID: <8c32bc91-6583-cd3d-a1e6-979bda122eb3@intel.com> Date: Wed, 9 Dec 2020 12:03:13 +0000 MIME-Version: 1.0 In-Reply-To: <20201204201646.51746-4-aboyer@pensando.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 3/9] net/ionic: update documentation and MAINTAINERS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/4/2020 8:16 PM, Andrew Boyer wrote: > The UNMAINTAINED flag will be removed in a future patch. > > Signed-off-by: Andrew Boyer > --- > MAINTAINERS | 3 ++- > doc/guides/nics/features/ionic.ini | 2 ++ > doc/guides/nics/ionic.rst | 13 +++++++------ > 3 files changed, 11 insertions(+), 7 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index eafe9f8c4..6534983c1 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -841,7 +841,8 @@ F: drivers/net/pfe/ > F: doc/guides/nics/features/pfe.ini > > Pensando ionic - UNMAINTAINED > -M: Alfredo Cardigliano > +M: Andrew Boyer > +M: Pensando Drivers Same comment from previous version, please don't add group as maintainer, only actual people. > F: drivers/net/ionic/ > F: doc/guides/nics/ionic.rst > F: doc/guides/nics/features/ionic.ini > diff --git a/doc/guides/nics/features/ionic.ini b/doc/guides/nics/features/ionic.ini > index 083c7bd99..dd29dbed6 100644 > --- a/doc/guides/nics/features/ionic.ini > +++ b/doc/guides/nics/features/ionic.ini > @@ -8,6 +8,7 @@ Speed capabilities = Y > Link status = Y > Link status event = Y > Queue start/stop = Y > +Lock-free Tx queue = Y Are you sure this is supported? Since it is not advertised as capability, I think this can't be claimed as supported, but still even after this is added as capability, can you please confirm your device supports multiple core enqueue to same queue without locks? > MTU update = Y > Jumbo frame = Y > Scattered Rx = Y > @@ -19,6 +20,7 @@ Unicast MAC filter = Y > RSS hash = Y > RSS key update = Y > RSS reta update = Y > +SR-IOV = Y Can you please explain what is exactly supported? Like can DPDK drive both PF & VF? <...> > @@ -7,15 +7,16 @@ IONIC Driver > The ionic driver provides support for Pensando server adapters. > It currently supports the below models: > > -- `Naples DSC-25 `_ > -- `Naples DSC-100 `_ > +- DSC-25 dual-port 25G Distributed Services Card > +- DSC-100 dual-port 100G Distributed Services Card > Same comment from previous version, can you provide link for these devices, it is hard to find the devices from the main site.