From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8E67A0524; Wed, 14 Apr 2021 10:23:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBD001617F9; Wed, 14 Apr 2021 10:23:53 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 10CC11617E1 for ; Wed, 14 Apr 2021 10:23:51 +0200 (CEST) IronPort-SDR: yn36/u2Cd2TUPkhoVdtNkupm7zSEgCyOuVHf/Pp1SOudpRFizWsOaM2kTUjjelIMOgUFKps2he CZbvwKggfmQw== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="194159501" X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="scan'208";a="194159501" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 01:23:50 -0700 IronPort-SDR: HQusyHLhnHiNi1kgs44Bmbnvsd+u964Cv9IPh62RZc3W+pmwImLlSrMk8sCoadZI+j72LWirXG irl7xuy557WQ== X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="scan'208";a="461101105" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.205.34]) ([10.213.205.34]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 01:23:48 -0700 To: Haifei Luo , dev@dpdk.org Cc: orika@nvidia.com, viacheslavo@nvidia.com, rasland@nvidia.com, xuemingl@nvidia.com, ajit.khaparde@broadcom.com, Matan Azrad , Shahaf Shuler References: <1615277716-64404-1-git-send-email-haifeil@nvidia.com> <1618380791-166428-1-git-send-email-haifeil@nvidia.com> <1618380791-166428-4-git-send-email-haifeil@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <8c469bc2-cc85-15b0-c039-abf519683c2a@intel.com> Date: Wed, 14 Apr 2021 09:23:45 +0100 MIME-Version: 1.0 In-Reply-To: <1618380791-166428-4-git-send-email-haifeil@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 3/3] doc: add single flow dump to guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/14/2021 7:13 AM, Haifei Luo wrote: > Add "Flow dump" in features/default.ini and features/mlx5.ini. > Add testpmd CLI and API changes in release_notes. > > Signed-off-by: Haifei Luo > --- > doc/guides/nics/features/default.ini | 1 + > doc/guides/nics/features/mlx5.ini | 1 + > doc/guides/rel_notes/release_21_05.rst | 5 +++++ > 3 files changed, 7 insertions(+) > > diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini > index 8046bd1..49aaf17 100644 > --- a/doc/guides/nics/features/default.ini > +++ b/doc/guides/nics/features/default.ini > @@ -39,6 +39,7 @@ DCB = > VLAN filter = > Flow control = > Flow API = > +Flow dump = Hi Haifei, I don't think "flow dump" is important enough to be listed in the feature list, I am for not adding it. Comparing the one line above item, "Flow API", this one is small and indeed subset of it. > Rate limitation = > Traffic mirroring = > Inline crypto = > diff --git a/doc/guides/nics/features/mlx5.ini b/doc/guides/nics/features/mlx5.ini > index ddd131d..3c5fcff 100644 > --- a/doc/guides/nics/features/mlx5.ini > +++ b/doc/guides/nics/features/mlx5.ini > @@ -29,6 +29,7 @@ SR-IOV = Y > VLAN filter = Y > Flow control = Y > Flow API = Y > +Flow dump = Y > CRC offload = Y > VLAN offload = Y > L3 checksum offload = Y > diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst > index a0b9079..e3ae470 100644 > --- a/doc/guides/rel_notes/release_21_05.rst > +++ b/doc/guides/rel_notes/release_21_05.rst > @@ -174,6 +174,8 @@ New Features > ``dpdk-testpmd -- --eth-link-speed N`` > * Added command to display Rx queue used descriptor count. > ``show port (port_id) rxq (queue_id) desc used count`` > + * Added command to dump internal representation information of single flow. > + ``flow dump (port_id) rule (rule_id)`` > > > Removed Items > @@ -207,6 +209,9 @@ API Changes > Also, make sure to start the actual text at the margin. > ======================================================= > > +* ethdev: Added a rte_flow pointer parameter to the function > + ``rte_flow_dev_dump()`` allowing dump for single flow. > + > * eal: The experimental TLS API added in ``rte_thread.h`` has been renamed > from ``rte_thread_tls_*`` to ``rte_thread_*`` to avoid naming redundancy > and confusion with the transport layer security term. > Can you please distribute the release notes updates to the patches that introduces the change? So there should be a separate release notes update patch. Thanks.