From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id ED940375B; Fri, 5 Oct 2018 08:45:33 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 4E7D3280057; Fri, 5 Oct 2018 06:45:32 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 5 Oct 2018 07:45:25 +0100 To: Jerin Jacob , John McNamara , Marko Kovacevic CC: , , , , References: <20181005044606.27026-1-jerin.jacob@caviumnetworks.com> From: Andrew Rybchenko Message-ID: <8c49c8fe-db03-8d2c-bce0-eb6998544f30@solarflare.com> Date: Fri, 5 Oct 2018 09:44:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20181005044606.27026-1-jerin.jacob@caviumnetworks.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24136.003 X-TM-AS-Result: No-9.545000-8.000000-10 X-TMASE-MatchedRID: hls5oAVArl8OwH4pD14DsPHkpkyUphL9kKAa/khZ3iQJW4Re2U2py0DX 7bvuwV8AoaOYcO7MxF/1C2y2L6c9MAeK3sUEdcSOAFhQPeH80f8GAD6h6FZmEdVTZaI6TuNoMHJ TJRxaAHGQrDMYz76xx+h3RGIqLiirn5B0lnk08rTBtFDYGmaWKpkShYcLpGH9H06W6rwtvNXN2W jbpqXgofa8+G6VxpdYgWg8WzvAdS0FrDF4OCzISWY0Io4Kxb86x22bBvE+WY47LF3pX3rdVLjxa 5EVBV1q4vM1YF6AJbZFi+KwZZttL4KB06bJjVb8/W9MYGK5mu3gfCfWlnNb/+YW23/lu+cl0o9W BDNMdRjiLXmkbHpvRVcFO/GkxzHHVpma+oNxVGNT6uYX6Vko4hEGikvJZla9h7CEZ5VgizuUJpB nQHf1RyliYeQy2F/IHDn+/ormN7t3KQXg+XM124BzWAeLv1vmYtizlfwRDJhKqV1xWKu6bu53Vg Z94BQg+IQh8yYjjCziux1YkpcnG7BTtnXEUH+HftwZ3X11IV0= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--9.545000-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24136.003 X-MDID: 1538721933-8whTXkwywZ7F Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 06:45:34 -0000 On 10/5/18 7:46 AM, Jerin Jacob wrote: > Based on PKT_TX_IP_CKSUM definition the user needs > to fill l2_len and l3_len mbuf fields before issuing > HW Tx checksum request. > > Fixes: dad1ec72a377 ("doc: document NIC features") > Cc: stable@dpdk.org > > Signed-off-by: Jerin Jacob Acked-by: Andrew Rybchenko plus one question below > --- > > See PKT_TX_IP_CKSUM at > https://git.dpdk.org/dpdk/tree/lib/librte_mbuf/rte_mbuf.h#n283 > > --- > doc/guides/nics/features.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst > index b085bda86..e726a6bb8 100644 > --- a/doc/guides/nics/features.rst > +++ b/doc/guides/nics/features.rst > @@ -562,6 +562,7 @@ Supports L3 checksum offload. > * **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_IPV4_CKSUM``. > * **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_IP_CKSUM``, > ``mbuf.ol_flags:PKT_TX_IPV4`` | ``PKT_TX_IPV6``. Shouldn't PKT_TX_IPV6 be removed above since L3 checksum offload is not applicable for IPv6? > +* **[uses] mbuf**: ``mbuf.l2_len``, ``mbuf.l3_len``. > * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_IP_CKSUM_UNKNOWN`` | > ``PKT_RX_IP_CKSUM_BAD`` | ``PKT_RX_IP_CKSUM_GOOD`` | > ``PKT_RX_IP_CKSUM_NONE``.