From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com,
david.marchand@redhat.com, ferruh.yigit@intel.com,
michaelba@nvidia.com, viacheslavo@nvidia.com
Cc: stable@dpdk.org, nelio.laranjeiro@6wind.com
Subject: Re: [dpdk-dev] [PATCH 1/3] net/virtio: add initial RSS support
Date: Fri, 10 Sep 2021 15:10:20 +0200 [thread overview]
Message-ID: <8c5b37ef-2fd1-117c-3dfa-c47375528ce4@redhat.com> (raw)
In-Reply-To: <9af789b9-78a8-19ff-fc3a-f64dd653b901@oktetlabs.ru>
On 9/10/21 2:58 PM, Andrew Rybchenko wrote:
> On 9/10/21 2:44 PM, Maxime Coquelin wrote:
>> Thanks for the review!
>>
>> On 9/10/21 12:06 PM, Andrew Rybchenko wrote:
>>> On 9/10/21 12:17 PM, Maxime Coquelin wrote:
>>>>
>>> I've failed to find F_RSS definion in virtio spec.
>>> Could you share the reference, please.
>>>
>>> Without the sepc it is almost impossible to review the code.
>>
>> Sorry, I forgot to add the link, you can find it on the Virtio-spec
>> github master branch:
>>
>> https://github.com/oasis-tcs/virtio-spec/blob/master/content.tex
>>
>> For readability, I would suggest you to clone it and build the HTML or
>> PDF versions.
>
> Many thanks.
>
>>>> diff --git a/doc/guides/nics/features/virtio.ini b/doc/guides/nics/features/virtio.ini
>>>> index 48f6f393b1..883dd1426c 100644
>>>> --- a/doc/guides/nics/features/virtio.ini
>>>> +++ b/doc/guides/nics/features/virtio.ini
>>>> @@ -14,6 +14,8 @@ Promiscuous mode = Y
>>>> Allmulticast mode = Y
>>>> Unicast MAC filter = Y
>>>> Multicast MAC filter = Y
>>>
>>> I'd say that
>>> RSS has = P
>>> should be added here.
>>
>> OK, as I mentionned in the cover letter, I was not sure becasue the doc
>> says "RSS hash" uses DEV_RX_OFFLOAD_RSS_HASH and provides mbuf.rss,
>> which this patch does not since it does not support (yet)
>> VIRTIO_NET_F_HASH_REPORT.
>> http://doc.dpdk.org/guides/nics/features.html#rss-hash
>
> Yes, I've seen question in cover letter. It is some kind of gap
> in features to claim overall RSS support - just hashing and
> distribution across queues without hash forwarding to user.
> The item definition covers both generic support and offload to
> deliver RSS hash. That's why I suggest P (partial).
Ok, got it!
Thanks,
Maxime
>> I can try to add VIRTIO_NET_F_HASH_REPORT in v2, so that we can set RSS
>> hash = Y without any doubts :)
>>
>> Regards,
>> Maxime
>>
>
next prev parent reply other threads:[~2021-09-10 13:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 9:17 [dpdk-dev] [PATCH 0/3] Virtio PMD RSS support & RSS fixes Maxime Coquelin
2021-09-10 9:17 ` [dpdk-dev] [PATCH 1/3] net/virtio: add initial RSS support Maxime Coquelin
2021-09-10 10:06 ` Andrew Rybchenko
2021-09-10 11:44 ` Maxime Coquelin
2021-09-10 12:58 ` Andrew Rybchenko
2021-09-10 13:10 ` Maxime Coquelin [this message]
2021-09-10 9:17 ` [dpdk-dev] [PATCH 2/3] app/testpmd: fix RSS hash type update Maxime Coquelin
2021-09-10 9:51 ` Andrew Rybchenko
2021-09-10 9:57 ` Maxime Coquelin
2021-09-10 10:06 ` Andrew Rybchenko
2021-09-10 14:16 ` Nélio Laranjeiro
2021-09-13 9:41 ` Maxime Coquelin
2021-09-14 7:20 ` Nélio Laranjeiro
2021-09-16 3:03 ` [dpdk-dev] [dpdk-stable] " Li, Xiaoyun
2021-09-16 7:33 ` Maxime Coquelin
2021-09-16 7:41 ` Li, Xiaoyun
2021-09-16 8:08 ` Maxime Coquelin
2021-09-16 8:30 ` Li, Xiaoyun
2021-09-10 9:17 ` [dpdk-dev] [PATCH 3/3] net/mlx5: Fix RSS RETA update Maxime Coquelin
2021-09-21 9:55 ` Slava Ovsiienko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c5b37ef-2fd1-117c-3dfa-c47375528ce4@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=amorenoz@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=michaelba@nvidia.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).