From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id 04A621B53 for ; Fri, 21 Sep 2018 13:37:37 +0200 (CEST) Received: by mail-lj1-f193.google.com with SMTP id j19-v6so11320481ljc.7 for ; Fri, 21 Sep 2018 04:37:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=V8gx/+makdAz3ImolMfb5+RaDlNnPHqUNt5zswG6E0g=; b=FQHasVawXCOxShc/n0CFeftKL8Cy0JS4I5yicUBWldp/tL2rU+Q0gNhvdydHNJhtk4 i53JoOHt0yZomi7XDBr2KBR6Ojn5WHINv+duXtj8+4vjXutFARE6EQt8m077wy4DXCnk 6dzaN0BU4c9U3dg4D9d3y3a+ZJsT8CHhxYD51iPPKintpjh85mYL2UvLOd1BSeF2zf2U TrHeONtFq9wRYA9+YFbTw3tBRTq8b2hIHJONbaoV3UKSWCyerTWgpCdhnygEuzVUpszW owtImqmfgDz1hS75KUaZ0hV4tcYmcn8ZES7dUEXD8iuUk6HFwXygpeyJhcfT0fkTmkfA NXnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=V8gx/+makdAz3ImolMfb5+RaDlNnPHqUNt5zswG6E0g=; b=ZAIkIyk1zlOz8q7m08dKX+ButRqafDaPZ8bKJUytkoS9th+QrBBQnWrHje2UafZKeJ mgER9YWp6fchzmqPyuzcYHlpasArrIKqbTDXv/rskT7h6aFHC7Ow7w6hgU4UXGvnBLN1 d1MzqXrYyb+axKfEQLa1qI2dT/09S6xIWba5eixuq9ZXskm4YSMFEOupbjM1ijSUw0z7 MDBK/dNTYBdy7LMHmxfxAn9ZKYfX+J2c8lefJkI/qJ4jSlM4fadtRybFi6WY7wN5rd39 Z2ZZFTOYBDKNNQTWXbbqTEPY3Z1fz4TLpXsr+pXvE0K0Q5NRZypcdAxEDoH9/ByiE3Bz XVDQ== X-Gm-Message-State: APzg51A0O5MqkyPz9awmuv0L5vDxBo1RbYFQ+SgcJn6YPBUf+nUahD6b 5yvHrfWSyaRPflynX/eAR23KLlxaxvQ= X-Google-Smtp-Source: ANB0VdY8X97bMu9x/ToMqa87opvIHHgfq7eeSsb1vk041KXHrykuizPvJta3Nh+BOkLr4Lj/D8R6AA== X-Received: by 2002:a2e:9057:: with SMTP id n23-v6mr1608126ljg.44.1537529857198; Fri, 21 Sep 2018 04:37:37 -0700 (PDT) Received: from [10.0.0.72] (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id q15-v6sm4842139ljh.34.2018.09.21.04.37.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 04:37:36 -0700 (PDT) To: Arnon Warshavsky , i.maximets@samsung.com, thomas@monjalon.net, stephen@networkplumber.org, david.marchand@6wind.com Cc: dev@dpdk.org References: <1537477900-32682-1-git-send-email-arnon@qwilt.com> From: Andrzej Ostruszka Message-ID: <8c7b1bea-526d-65cd-cdd9-6fa135c891a1@semihalf.com> Date: Fri, 21 Sep 2018 13:37:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1537477900-32682-1-git-send-email-arnon@qwilt.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] devtools: move forbidden tokens awk script to a separate file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 11:37:39 -0000 Acked-by: Andrzej Ostruszka However you might consider keeping this comment in the awk script. On 20.09.2018 23:11, Arnon Warshavsky wrote: [...] > @@ -44,85 +44,12 @@ print_usage () { > } > > check_forbidden_additions() { > - # This awk script receives a list of expressions to monitor > - # and a list of folders to search these expressions in > - # - No search is done inside comments > - # - Both additions and removals of the expressions are checked > - # A positive balance of additions fails the check Best regards Andrzej