From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1296E43BEB; Sun, 3 Mar 2024 07:30:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF73B42E2F; Sun, 3 Mar 2024 07:30:26 +0100 (CET) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id 696B04028C for ; Sun, 3 Mar 2024 07:30:25 +0100 (CET) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 141963FFD for ; Sun, 3 Mar 2024 07:30:25 +0100 (CET) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 0762F3FFC; Sun, 3 Mar 2024 07:30:25 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=ALL_TRUSTED,AWL, T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0 X-Spam-Score: -1.4 Received: from [192.168.1.59] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 2CAF14070; Sun, 3 Mar 2024 07:30:23 +0100 (CET) Message-ID: <8c93e10c-d6e6-4e97-95c7-2a6395fcb4c7@lysator.liu.se> Date: Sun, 3 Mar 2024 07:30:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 7/7] eal: deprecate relaxed family of bit operations Content-Language: en-US To: Stephen Hemminger , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: dev@dpdk.org, Heng Wang References: <20240302135328.531940-1-mattias.ronnblom@ericsson.com> <20240302135328.531940-8-mattias.ronnblom@ericsson.com> <20240302090721.2cbad00f@hermes.local> From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: <20240302090721.2cbad00f@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024-03-02 18:07, Stephen Hemminger wrote: > On Sat, 2 Mar 2024 14:53:28 +0100 > Mattias Rönnblom wrote: > >> diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h >> index b5a9df5930..783dd0e1ee 100644 >> --- a/lib/eal/include/rte_bitops.h >> +++ b/lib/eal/include/rte_bitops.h >> @@ -1179,6 +1179,10 @@ __RTE_GEN_BIT_ATOMIC_OPS(64) >> * The address holding the bit. >> * @return >> * The target bit. >> + * @note >> + * This function is deprecated. Use rte_bit_test32(), >> + * rte_bit_once_test32(), or rte_bit_atomic_test32() instead, >> + * depending on exactly what guarantees are required. >> */ >> static inline uint32_t >> rte_bit_relaxed_get32(unsigned int nr, volatile uint32_t *addr) > > The DPDK process is: > - mark these as deprecated in release notes of release N. > - mark these as deprecated using __rte_deprecated in next LTS > - drop these in LTS release after that. > > Don't use notes for this. Don't use notes to replace the above process, or don't use notes at all? A note seems useful to me, especially considering there is a choice to be made (not just mindlessly replacing one call with another). Anyway, release notes updates have to wait so I'll just drop this patch for now.