From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Yu, DapengX" <dapengx.yu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix data path corrupt on secondary process
Date: Mon, 21 Jun 2021 03:07:57 +0000 [thread overview]
Message-ID: <8cafbee3b1504094a88a309f5302f1d8@intel.com> (raw)
In-Reply-To: <20210609070537.2714889-1-dapengx.yu@intel.com>
> -----Original Message-----
> From: Yu, DapengX <dapengx.yu@intel.com>
> Sent: Wednesday, June 9, 2021 3:06 PM
> To: Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Yu, DapengX
> <dapengx.yu@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/i40e: fix data path corrupt on secondary process
>
> From: Dapeng Yu <dapengx.yu@intel.com>
>
> The rte_eth_devices array is not in share memory, it should not be referenced
> by i40e_adapter which is shared by primary and secondary.
> Any process set i40e_adapter->eth_dev will corrupt another process'
> context.
>
> The patch removed the field "eth_dev" from i40e_adapter.
> Now, when the data paths try to access the rte_eth_dev_data instance, they
> should replace adapter->eth_dev->data with adapter->pf.dev_data.
>
> Fixes: 2bedd7277a10 ("net/i40e: print real global changes")
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
> Fixes: be6c228d4da3 ("i40e: support Rx interrupt")
> Fixes: 8e109464c022 ("i40e: allow vector Rx and Tx usage")
> Fixes: 1d169e9dafb8 ("net/i40e: support cloud filter with L4 port")
> Fixes: a778a1fa2e4e ("i40e: set up and initialize flow director")
> Fixes: 460d1679586e ("drivers/net: delete HW rings while freeing queues")
> Fixes: b0ea2716e05b ("net/i40e: add flow flush function")
> Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
> Fixes: 819a5c14d1dd ("net/i40e: fix null checks")
> Fixes: e0cb96204b71 ("net/i40e: add support for representor ports")
Just need to list the patch that bring the issue (in this case it is the one that add a non-shared point into a structure that will be shared)
, all following up patches are not guilty.
> Cc: stable@dpdk.org
>
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
next prev parent reply other threads:[~2021-06-21 3:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 7:05 dapengx.yu
2021-06-21 3:07 ` Zhang, Qi Z [this message]
2021-06-21 7:23 ` [dpdk-dev] [PATCH v2] " dapengx.yu
2021-07-01 12:37 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cafbee3b1504094a88a309f5302f1d8@intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dapengx.yu@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).