Re: [PATCH v2 1/1] app/testpmd: support different input color method

[Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>]

On 5/25/22 17:41, Dumitrescu, Cristian wrote:
> 
> 
>> -----Original Message-----
>> From: skori@marvell.com <skori@marvell.com>
>> Sent: Wednesday, May 25, 2022 3:37 PM
>> To: Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Aman Deep
>> <aman.deep.singh@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>;
>> Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
>> Cc: dev@dpdk.org; Sunil Kumar Kori <skori@marvell.com>
>> Subject: [PATCH v2 1/1] app/testpmd: support different input color method
>>
>> From: Sunil Kumar Kori <skori@marvell.com>
>>
>> To enable input coloring, based on VLAN or DSCP, patch adds
>> command line interface to configure the following:
>>
>>   - configuring input coloring using VLAN or DSCP while creating
>>     meter i.e. during rte_mtr_create()
>>
>>   - Update VLAN input coloring table at runtime.
>>
>>   - configures protocol priorities.
>>
>>   - retrieve protocol and priority information
>>
>> Depends-on: patch-22751 ("ethdev: mtr: support protocol based input color
>> selection")
>>
>> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
>> ---
>> v1..v2:
>>   - Rebased to branch dpdk-next-net
>>   - add CLIs for input coloring mechanism
>>
>>   app/test-pmd/cmdline.c     |   4 +
>>   app/test-pmd/cmdline_mtr.c | 558
>> ++++++++++++++++++++++++++++++++++++-
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 

The patch breaks build as reported by CI [1].
Please, fix and send v4 (since since one should be v3 in fact).

[1] 
https://patches.dpdk.org/project/dpdk/patch/20220525143716.996398-1-skori@marvell.com/

Note that you need to rebase on top of dpdk-next-net/main since
nearby lines change due to static keyword addition. Don't forget
to add to newly added cmdline_parse_* structs which are used in
the file only.