From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68147A054F; Tue, 31 May 2022 17:41:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A99C4067B; Tue, 31 May 2022 17:41:49 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id AD41F40143 for ; Tue, 31 May 2022 17:41:47 +0200 (CEST) Received: from [192.168.1.38] (unknown [188.170.81.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id CC52A86; Tue, 31 May 2022 18:41:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru CC52A86 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1654011707; bh=+F80blNJmdbjM3tdFJBuGZbcAdlxq9+5GTL5/cXNmgU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Ct2kSz4+HdtTOdYGJci6ImJHLMbIrsTvTjCC7PEysgB9XObs/6/+aOal9D57DODoO U+c6X29rdNnihU3gq3OD9kx6CyPoC/X0q2TTuO9yPeU/ArM77sFhzHJHxsNmyXqdlO BaI+xWmx09FWZI29DHUBlpZbBwiqvkjx9nl1bpNU= Message-ID: <8cc3a0f3-e450-e3b9-b837-7c5bc8a738b5@oktetlabs.ru> Date: Tue, 31 May 2022 18:41:46 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 1/1] app/testpmd: support different input color method Content-Language: en-US To: "Dumitrescu, Cristian" , "skori@marvell.com" , "Li, Xiaoyun" , "Singh, Aman Deep" , "Zhang, Yuying" Cc: "dev@dpdk.org" References: <20220524073554.824162-1-skori@marvell.com> <20220525143716.996398-1-skori@marvell.com> From: Andrew Rybchenko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/25/22 17:41, Dumitrescu, Cristian wrote: > > >> -----Original Message----- >> From: skori@marvell.com >> Sent: Wednesday, May 25, 2022 3:37 PM >> To: Li, Xiaoyun ; Singh, Aman Deep >> ; Zhang, Yuying ; >> Dumitrescu, Cristian >> Cc: dev@dpdk.org; Sunil Kumar Kori >> Subject: [PATCH v2 1/1] app/testpmd: support different input color method >> >> From: Sunil Kumar Kori >> >> To enable input coloring, based on VLAN or DSCP, patch adds >> command line interface to configure the following: >> >> - configuring input coloring using VLAN or DSCP while creating >> meter i.e. during rte_mtr_create() >> >> - Update VLAN input coloring table at runtime. >> >> - configures protocol priorities. >> >> - retrieve protocol and priority information >> >> Depends-on: patch-22751 ("ethdev: mtr: support protocol based input color >> selection") >> >> Signed-off-by: Sunil Kumar Kori >> --- >> v1..v2: >> - Rebased to branch dpdk-next-net >> - add CLIs for input coloring mechanism >> >> app/test-pmd/cmdline.c | 4 + >> app/test-pmd/cmdline_mtr.c | 558 >> ++++++++++++++++++++++++++++++++++++- > > Acked-by: Cristian Dumitrescu > The patch breaks build as reported by CI [1]. Please, fix and send v4 (since since one should be v3 in fact). [1] https://patches.dpdk.org/project/dpdk/patch/20220525143716.996398-1-skori@marvell.com/ Note that you need to rebase on top of dpdk-next-net/main since nearby lines change due to static keyword addition. Don't forget to add to newly added cmdline_parse_* structs which are used in the file only.