From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0086.outbound.protection.outlook.com [104.47.37.86]) by dpdk.org (Postfix) with ESMTP id 506981B6E7 for ; Mon, 16 Oct 2017 15:47:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hrONSkCwuYoqAGnJzmBaeLCtKFnyq3HL66Y1+Fuw8Ho=; b=lni0n8Mp6asETFQTlodHnCgj/Yih6j6cCprk/bkG4cZmefnJkWPbg9wumLDMt0/WT+qY4y0yP0Kqk7Gc6CN0iaTW2XfRvX8eY9sSkLDKYXquVbUaYClT+RrPe0zYe+IAQswVXD5DRua66/H5W6blc/ZnmIH5Tg4BKNKpsEF+Os8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [10.160.0.38] (111.93.218.67) by MWHPR07MB3101.namprd07.prod.outlook.com (10.172.95.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 16 Oct 2017 13:47:27 +0000 To: Hemant Agrawal , "olivier.matz@6wind.com" , "dev@dpdk.org" References: <3e228854-d5d4-7dc1-6c25-29de7f6c37c7@caviumnetworks.com> <6bda52aa-6084-0db9-d78e-57019c2f1f7b@nxp.com> Cc: "thomas@monjalon.net" , "jerin.jacob@caviumnetworks.com" From: santosh Message-ID: <8ce497d0-e91a-d18c-0524-5bb48bcc1087@caviumnetworks.com> Date: Mon, 16 Oct 2017 19:17:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0095.INDPRD01.PROD.OUTLOOK.COM (10.174.208.11) To MWHPR07MB3101.namprd07.prod.outlook.com (10.172.95.7) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eab1f505-2502-42bc-644f-08d5149c71aa X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:MWHPR07MB3101; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3101; 3:PtcgOkqWOqFlwSoThORF00W+RXyJeSkbh+MPtjXbhdD3EMW2XtICkelviCpmtV+lzJxULxFvTC0qLtDxJ4db1uzmVWPUD01S8hziTtqZXPegK952C8+g5pnZh67xJClkwx4wzdC4FLtlXg+wfXrh5PtWZhkyLl4aywQY5s2wmLwHMb4dMrikZZI8rKw4DXkE3Ki6odi5Qwpuq/Z64s13oLn60eEspFPAppgiKLw9v0badXa3/GQANRkqVv8/ZCaf; 25:HEdSceVzHHpK3SrYh1AlzOVLYUBme/2CCX3my2c02etdU6SDmFWbZ7Wxy7l60npZNjADhkOx9ChspcXIX30SyXRpAbPHzr1yOX8xssr2mEV4sEv84pGVgMJUO/P8kuH5YqPtrBCXfHk2d/2o2sSN0CPCj4mUe3uvbTdIJz1OJI9X2doZysCM6l2Jv63Ch6BnZCrHo2XDPi3b23D7fRda9z8od7sCRnzVgpESDLLQYBWQqylaUqonnFUj4MTdxP1y0zaINSqnE+r7Td0f2uoA1fuI3aUU1GfwOPG1UT4vpNBFV6+oR2Ymzmfk9pfql0xQD7eGJyYKn9PB6udCDzoOqw==; 31:+Q/+ewDGsZDHKQ5RRw1OITJUKFl/zTwYMY0deFYgmyREdBbzZecGwHC6d/wXTJVvrnOxcBKHBxHX62ESV+Z/IC51rL6BcthMaOTV5iIz2/MMjfwJZsNtzZv23Spyd3Sz8iH1BkUICtR+ZGxcEp1PX8oZu0OAdBK8nJxN5kF7S9fZHT0Sk/c2uGmo9QLqpETvCu86WJ5cg0WzYPXNW7TUREMtPNRpQHZvhpHjuHOa9AE= X-MS-TrafficTypeDiagnostic: MWHPR07MB3101: X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3101; 20:XiTahqhFYaZDmqeYbVXBUAq7CR3M3zgcLruk3+p8VUfxp9ceLPv8d70+VFZyEQedMQKJqxVDEnRr2kIJocuGZX4sPBU1mypX0u7DWp7ftfP7Sg1e1BD3O7I/n32Uc+bU4y++vBZPFUiqx9NwKsiOyT9+Md714y81c2gET+GvluD4jbIx3VGCuZADWgvlAlLquUXYeNaHsUj5ir5bFffiN7ZK3b8DuqiEDmwAquoaS/t2UWuaERLmF7c5N2UI8T73cpnMCO4fzmMAz1buyai9wP0Sn5MIcUIkeKqKUbzSTWR2fa2k1Haf+X+JryAZ68n5clJwWHZkTXlRaiMMyOu9x6kato4ixrr2MvufnHsERehdn5QCj+HJMXb9LD4gxTO2d7yk2kqq3umoFFlPFM/kQaHLAoL3Tgc+HmmYD7bJiuc/b/8o3n6CsCeVwaYcS1sckzzTlM6ysRRR39iXs5tJWGDwOrQwmCcUEgDiORx721H3ZYQ0T1iiKuFJCinIHYmYzmJOuT5v2q6Xcdtb3jQ6ZNeMG2Bz9Jg3+4uDq5CGWfBILimc3lp1HZ9qWiejS1fViAtae2VMjr6YPDxDK8T1HDNNYa23+I7JwmRfoAeZ5kc=; 4:lP+U77hQ72eWMOUrthgqd09bWL8k+uVivq/RJhKTv+15zjG0F/NecpR+BBeLwPWecginRdPrqcKtUBxENqum1QbOhdZs75pp5Cr6bt2zLQr6c8vXwnmUruKkiJARdnEoSHW5AR+hXswwEeiYPHsLeHPGXvAq//9pDaUGt+5s8iXcm0z+VLRu4uzIQ6UeoI2ka32XzT5doHx/Si7cgkqOLp8IUL1atEpFaHQ9yvwreT16cVZofxk1n7pUCpgyLh1H X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(3002001)(10201501046)(100000703101)(100105400095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR07MB3101; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR07MB3101; X-Forefront-PRVS: 0462918D61 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(6009001)(346002)(376002)(189002)(24454002)(377454003)(199003)(53936002)(2906002)(966005)(2201001)(76176999)(6246003)(101416001)(81166006)(54356999)(81156014)(189998001)(72206003)(36756003)(8676002)(50986999)(8936002)(31686004)(107886003)(53376002)(53546010)(64126003)(4326008)(7736002)(97736004)(305945005)(31696002)(2501003)(6666003)(110136005)(47776003)(54906003)(16576012)(5009440100003)(23746002)(6306002)(86152003)(16526018)(105586002)(316002)(3846002)(230700001)(90366009)(33646002)(77096006)(5660300001)(6486002)(58126008)(6116002)(66066001)(65956001)(65806001)(478600001)(229853002)(83506001)(50466002)(25786009)(65826007)(68736007)(106356001)(8656003)(93886005)(2950100002)(42882006); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3101; H:[10.160.0.38]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; MWHPR07MB3101; 23:cA8oGJu4C0pHJymwFkorYTAVgtbrMt2kosuSI?= =?Windows-1252?Q?Tga88dUYJh3Eq5VnmQjdAoTCVjOKuMj59DEJ/dax9GPW5KCSnjtbruvO?= =?Windows-1252?Q?RP9Y/ZFVShVWLhGprVpzSbcWVhiq7PXy0h/tgV4AvmPL/FPHJebWZtk7?= =?Windows-1252?Q?VfgsJEo8IPqOJk5ocof6LnUsj4rIJHD4NXaKp6Hw6Sfkn1ogsqdJHbor?= =?Windows-1252?Q?rYkZFgJc3X7+eYrnl0F1BW2P3INxF2hzqSkfaJBOu9DYr0BY+v6R/Dy6?= =?Windows-1252?Q?nhTMiM8v1sAQZ1A+i9u+7blHX7o+oXvynwaoKvcIgJlhSHsyPbNLLpg3?= =?Windows-1252?Q?iOiHDfjddfLMbZG1kK867Yv4aYamvyLx3yY1Xeei6efEHZCa5J/ufsYD?= =?Windows-1252?Q?OKNy9L8+2dih0ReNuxCrP/tC+hfeMWHqEVyOwrTeSkeMqokZ3LqWdB+X?= =?Windows-1252?Q?feaRbOA3cLMrfBTXx+G3T4n88fUjsshhLKoX/6O3sGiAu2pyqnhXjQ88?= =?Windows-1252?Q?QmpgntGELlDHn0Y7t59dU4ebHn/0N6Dpw9tZUf0sKQnb1rXjaMoffzEd?= =?Windows-1252?Q?/TTuCUeSwe64EUPiG8SD+Z8SyBaOYF4G2JXDNr8vlkcv0RHJ2YQbJ4B9?= =?Windows-1252?Q?/K60Jdcyw/mxCydOtnevwSHbFNI7URRgTkACuPLMYwdu7Bja6Wk1xwLW?= =?Windows-1252?Q?BChu7uMV8RjmDB5fg3CKFs45EH7vqL0KKCuto0QTL7Naoj/pVT0QUPav?= =?Windows-1252?Q?vTJVhGhkOvDD0C7XtdXBQYkYCpgDCHO1TQynfnusDni5+Jse7FWK9nkU?= =?Windows-1252?Q?P6sWll9hqadKzXclnOuA4W+eqoiLnl91jNInn2iQNKWnfh2fF5vOsksa?= =?Windows-1252?Q?SvbDChJ9QFy2OV7SNYJowApqygA54PaLoT9KJy1ICXBVqm3sZaCY1g90?= =?Windows-1252?Q?7ZlLCK7mOVu6gJRJ904FyBXHjY3p9BN0atrgIsFsFwTDz74YIxSbPemS?= =?Windows-1252?Q?9mWttyAgRhIKHR6F7PbatQT7DbRi8K58IcuwEf9QTVd+autMVGkwiejY?= =?Windows-1252?Q?mhZmJJCbv4kDm2QYTqvPEBQwfyvuRg1pHXe1eLB2STVo39gLTFG5EoSc?= =?Windows-1252?Q?iDojBJrzjoNCsq98dQKJxspjGfCcDxvH/Cqazf8PAv8THONHAJQqCh32?= =?Windows-1252?Q?/j5o3dJkAgGRUY95UjNBxq5JhZISpfjkM07ZJjA1HsRw6vGk9Mz9kDWG?= =?Windows-1252?Q?Rt+fotsb7bEJREheqbgAl5i5ZzYc4s48D+N/B6PZFXV8OoVFa6/6iX3q?= =?Windows-1252?Q?ZtHKlXrAyYuUci4QWpEjU17c8rCA1LJBHgImSQxl1xcqnbnWI2F/w3/y?= =?Windows-1252?Q?pdfJScuMijyZFJzdaYUz8nuyRu1PtWcDFKJ8Wqw8xhszbKrF3K3x1LiZ?= =?Windows-1252?Q?NDO/hCG4mjuJIdmymsI9fPa1+IeBy8NTqJO21xUvyJX9Pk07Yzz1wyNi?= =?Windows-1252?Q?ucthDAi/uyqI4X+Zd/SLD6gCAK9U01N8zcGpik52OvcTLSH3APLuh857?= =?Windows-1252?Q?Ic94mQzVPj5TX2ZtrxX1KggiXeUyqJPvBUWZjIG+HEDW9r+jK2g7rmZ2?= =?Windows-1252?Q?TIiIa4vNom+5zBnLZdppHOv/bEI5+CRmLbk52vYEbSZ9AFZN2DHAXQQv?= =?Windows-1252?Q?z97z3lOjzuFGvF439JLBmsyYCYfA8k8T+99rRZmfUf6OHsO1qzFT+ArE?= =?Windows-1252?Q?qJc7pxXfsXw4AU9CQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3101; 6:g+F6PgLO1ZOs3dhpZ5ENZntXi/JWWePVbSuhhphB7HjPiJDZhvE+G3CFPILBEX5yx+8U9wMxVTZX7f6xTQY3L+QFFI2DehSZkcq1xEXy+t0YHmddwdfIZsUB2dgZ8ridtkR3Re2kFKHNauT+21Rl3tMnVCoff5NRC7N8wPLAqFK16mjO2UNV9OBYo+fv4hBiwF9edZ07tgyP7NoAHi9mVN1YObmH8KC/4upohYls4O6Amz6HDD3q6iDZSOCE1bsHGucT3UzaTFnUxCbFNqIARuR2OP44/4V73IfavjGQs9rm4tAIjkjXK0cfZvlnj2Fk0PkCYV4WWen9m3rOifrUPQ==; 5:IrnxCbyhiYX+6m8MT70z4TtylWSjmIh0Meb0tZcDiKCe+Ewvc3ik0FLGdibTE0kTTbCDGgSNkCYsv1d53C3n+y5oNV5wKvgbrsVRqFAu37YhrCbTyaylMWFuD28UurovweCxN5TZJ3OkNNvlRJc6BJWk2cQJDtuuUa8YGNqOHBw=; 24:CGpw941fJ/Vw/prtuuGNRegCp4GoVI6jaH0LYlWkXv4aNXDakPn0E2HaOUuOXhY6ojXykb2BjoAiQ+2S0d/wIzMbL7MrmNhc8FIOlAkvuVo=; 7:Nupd79WufL8EIJ6t+s2qv4wMii6lXsUmBgP/QBAqlSntKiWRLOFT2OoM+E3bZ+TV3qLxF9fq2l4PcxRDmTf/0zCQuml/nXRieSvlfDNx/ZcQfEXA3Tbff32VbxQ2qM5MafCsH0Lxivqu4vCxqdJah11FuY13NOVMsjtdayGdFe90eHIbcXpUarze/yGvBzO6ymF6MerSFgaYf3zQ5WgLb5iFwdX1K7kAWRN8gwkOX3c= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2017 13:47:27.6926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3101 Subject: Re: [dpdk-dev] Shared compilation issue - mempool/octeontx: add build and log infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 13:47:32 -0000 Hi Hemant, On Monday 16 October 2017 12:20 PM, santosh wrote: > On Monday 16 October 2017 12:18 PM, Hemant Agrawal wrote: >> Hi Santosh, >> >> On 10/14/2017 8:57 PM, santosh wrote: >>> On Saturday 14 October 2017 11:37 AM, Hemant Agrawal wrote: >>>> Santosh/jerin, >>>> Your patch "mempool/octeontx: add build and log infrastructure" is causing shared build failure for NXP's patch "event/dpaa2: support event eth adapter", which is still under review. >>>> http://dpdk.org/dev/patchwork/patch/30248/ >>>> >>>> In your patch, you have added mempool to be dependent on event, which is not correct. >>>> >>>> "+DEPDIRS-mempool := bus event" >>> Yes, Octeontx needed mbox definitions and it was defined at event area. >>> >>> But You are right that adding event dependency in mempool may create issues >>> for future feature like you mentioned. >>> >>>> Ideally, if you have common code, you should put that in bus or mempool . This way you can make event, net or sec etc dependent on bus or mempool and not the otherway around. >>> Right. >>> Proposed change for makefile will be: >>> >>> diff --git a/drivers/Makefile b/drivers/Makefile >>> index 3a5b22342..0467250aa 100644 >>> --- a/drivers/Makefile >>> +++ b/drivers/Makefile >>> @@ -32,13 +32,13 @@ >>> include $(RTE_SDK)/mk/rte.vars.mk >>> >>> DIRS-y += bus >>> -DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event >>> -DEPDIRS-event := bus >>> DIRS-y += mempool >>> -DEPDIRS-mempool := bus event >>> +DEPDIRS-mempool := bus >>> DIRS-y += net >>> DEPDIRS-net := bus mempool >>> DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto >>> DEPDIRS-crypto := bus mempool >>> +DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event >>> +DEPDIRS-event := bus mempool >>> >>> include $(RTE_SDK)/mk/rte.subdir.mk >>> >>> Can you give it a try and let me know your feedback. >>> >> This change breaks the octonetx compilation. >> You may also have to move the the common code from event to mempool. >> > Yes, I missed mentioning that part in earlier mail. > > We'll post series soon. > > Thanks. Sent fix [1] and [2]. Pl. test with your series. Thanks. [1] http://dpdk.org/dev/patchwork/patch/30430/ [2] http://dpdk.org/dev/patchwork/patch/30431/