From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82CC2A04AC; Tue, 1 Sep 2020 09:20:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E579EE07; Tue, 1 Sep 2020 09:20:09 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id C4F03DE0 for ; Tue, 1 Sep 2020 09:20:07 +0200 (CEST) IronPort-SDR: rq3vewoqnvVQKJHz+v3O6m4Ps5OChLKe4W+7juIdys/g/NOP91exX7BLJr+l4xFTaGzcGrWBFF S5XK3X2lSA6g== X-IronPort-AV: E=McAfee;i="6000,8403,9730"; a="144808843" X-IronPort-AV: E=Sophos;i="5.76,378,1592895600"; d="scan'208";a="144808843" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2020 00:20:06 -0700 IronPort-SDR: JCHsWROR/hX/OuR39qCxJhjgK+Uk8L2blyB9mlPJvBEZzdRXcZquB8B8ZnXFKVFAuc4LJQcEp2 fqqL42EkvJzQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,378,1592895600"; d="scan'208";a="338480395" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 01 Sep 2020 00:20:06 -0700 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 1 Sep 2020 00:19:27 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 1 Sep 2020 15:19:25 +0800 Received: from shsmsx602.ccr.corp.intel.com ([10.109.6.142]) by SHSMSX602.ccr.corp.intel.com ([10.109.6.142]) with mapi id 15.01.1713.004; Tue, 1 Sep 2020 15:19:25 +0800 From: "Sun, GuinanX" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Yang, Qiming" Thread-Topic: [PATCH] net/ice: fix flow validation for unsupported patterns Thread-Index: AQHWfOXwNZpgMKIdDEe+r6VSYZahwqlRHMYAgAJHxQA= Date: Tue, 1 Sep 2020 07:19:24 +0000 Message-ID: <8ceef2d3cea2414184f85f52d4c3311d@intel.com> References: <20200828023328.62492-1-guinanx.sun@intel.com> <039ED4275CED7440929022BC67E706115522E204@SHSMSX107.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E706115522E204@SHSMSX107.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ice: fix flow validation for unsupported patterns X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi qi > -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, August 31, 2020 12:23 PM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Yang, Qiming ; stable@dpdk.org > Subject: RE: [PATCH] net/ice: fix flow validation for unsupported pattern= s >=20 >=20 >=20 > > -----Original Message----- > > From: Sun, GuinanX > > Sent: Friday, August 28, 2020 10:33 AM > > To: dev@dpdk.org > > Cc: Zhang, Qi Z ; Yang, Qiming > > ; Sun, GuinanX ; > > stable@dpdk.org > > Subject: [PATCH] net/ice: fix flow validation for unsupported patterns > > > > When loading the OS default package and the pipeline mode is enabled > > by the "pipeline-mode-support=3D1" operation. In this case, the wrong > > parser is selected for processing and it will cause the unsupported > > patterns(pppoes/pfcp/l2tpv3/esp/ah) to be validated successfully. > > This patch corrects the parser selection issue. > > > > Fixes: 47d460d63233 ("net/ice: rework switch filter") > > Cc: stable@dpdk.org > > > > Signed-off-by: Guinan Sun > > --- > > drivers/net/ice/ice_switch_filter.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ice/ice_switch_filter.c > > b/drivers/net/ice/ice_switch_filter.c > > index c4b00b6a2..884fbaae2 100644 > > --- a/drivers/net/ice/ice_switch_filter.c > > +++ b/drivers/net/ice/ice_switch_filter.c > > @@ -1806,7 +1806,8 @@ ice_switch_init(struct ice_adapter *ad) > > else > > return -EINVAL; > > > > - if (ad->devargs.pipe_mode_support) > > + if (ad->devargs.pipe_mode_support && > > + ad->active_pkg_type !=3D ICE_PKG_TYPE_OS_DEFAULT) > > ret =3D ice_register_parser(perm_parser, ad); >=20 > This is not correct, package type should not related with pipe line mode. Under the premise of pipe-mode support, the choice of parser for different = package types will be added. Patch v2 will fix it. >=20 >=20 > > else > > ret =3D ice_register_parser(dist_parser, ad); @@ -1824,7 > +1825,8 @@ > > ice_switch_uninit(struct ice_adapter *ad) > > else > > dist_parser =3D &ice_switch_dist_parser_os; > > > > - if (ad->devargs.pipe_mode_support) > > + if (ad->devargs.pipe_mode_support && > > + ad->active_pkg_type !=3D ICE_PKG_TYPE_OS_DEFAULT) > > ice_unregister_parser(perm_parser, ad); > > else > > ice_unregister_parser(dist_parser, ad); > > -- > > 2.17.1