From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2ABB5A0526; Tue, 10 Nov 2020 13:45:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0CB6FF64; Tue, 10 Nov 2020 13:45:06 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 6EAF5DED for ; Tue, 10 Nov 2020 13:45:02 +0100 (CET) IronPort-SDR: swh55qxCflbYl2pDXkuZeYt1ex6SJh/z2ewxix2EwxMPYRpU9Mw9jGUJHDCH40kYWQxv6QRx2Y Y143ko/iwHBw== X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="149814503" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="149814503" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 04:45:00 -0800 IronPort-SDR: uubIjNPbcVMfCnVGcokazibzIcQQsGzykE0I4dAgri8K1kOHQwACs1Xh+vZbhJ9/FKIW1X6oMt ijCLZdPzsmLA== X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="541309637" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.0.179]) ([10.252.0.179]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 04:44:59 -0800 From: Ferruh Yigit To: "Zhang, Qi Z" , "Guo, Jia" , Prateek Agarwal Cc: "dev@dpdk.org" References: <3f94d598668b4279a2f5fb834124f3e2@intel.com> <0ed1c11c-095b-4f98-9074-a82e3abba900@intel.com> Message-ID: <8cf5118e-6e75-3aa7-f61e-1766d3600757@intel.com> Date: Tue, 10 Nov 2020 12:44:55 +0000 MIME-Version: 1.0 In-Reply-To: <0ed1c11c-095b-4f98-9074-a82e3abba900@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header d... X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/9/2020 5:44 PM, Ferruh Yigit wrote: > On 11/9/2020 9:49 AM, Zhang, Qi Z wrote: >> >> >>> -----Original Message----- >>> From: dev On Behalf Of Guo, Jia >>> Sent: Monday, November 9, 2020 2:24 PM >>> To: Prateek Agarwal >>> Cc: dev@dpdk.org >>> Subject: Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern >>> "C". Library headers work directly in cpp code. Linking errors thrown due to the >>> absence of this change in i40e pmd header does not help in resolving the >>> problem. I needed this header d... >>> >>> Hi, Agarwal >>> >>>> -----Original Message----- >>>> From: Prateek Agarwal >>>> Sent: Saturday, November 7, 2020 5:01 PM >>>> To: Guo, Jia >>>> Cc: dev@dpdk.org; Prateek Agarwal >>>> Subject: [PATCH] Made i40 header CPP compatible using extern "C". >>>> Library headers work directly in cpp code. Linking errors thrown due >>>> to the absence of this change in i40e pmd header does not help in >>>> resolving the problem. I needed this header directly to use... >>>> >>> >>> Obviously that is not you want to merge the title and the commit log. Please >>> separate it and update one new version. >> >> >> Fixed the format during merge as below >> >> net/i40e: add extern "C" for cpp compile >> >> Add extern "C" in rte_pmd_i40e.h when be compiled with cpp. >> >> Applied to dpdk-next-net-intel. >> > > Hi Prateek, > > In the git history, we have your name as: > "Prateek Agarwal " > > We are trying to keep authors unique in the git history, as much as possible, > will be OK to continue with the one in the git history? Using the one in the git history, thanks.