From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D61A445967;
	Thu, 12 Sep 2024 06:14:20 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6D28C40657;
	Thu, 12 Sep 2024 06:14:20 +0200 (CEST)
Received: from lf-1-20.ptr.blmpb.com (lf-1-20.ptr.blmpb.com [103.149.242.20])
 by mails.dpdk.org (Postfix) with ESMTP id ACD2B40654
 for <dev@dpdk.org>; Thu, 12 Sep 2024 06:14:18 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 s=feishu2403070942; d=yunsilicon.com; t=1726114451; h=from:subject:
 mime-version:from:date:message-id:subject:to:cc:reply-to:content-type:
 mime-version:in-reply-to:message-id;
 bh=yT9006YQmBvhmFkBziHnjTEbiWeqjYEAa/ZIaJuWLCg=;
 b=cfP7JTxqNogSZ4W0gmrD1ByFyfzUmOFUBa9mBJGDMMfCgoq/V/VgApbbUSniEU1k1l4rmg
 SCNNwe6K9ug9LSx+XHBgZENmra44VilD/bybClGZ1EEQTHUApEee63hLFtETZ4JqRveSMS
 b7s1tC6F3mm9YZIiz2tY9BP95cSpPDj313sU6gLQ1qA1hQcwchmcYFqlpLfuAcqpyv3xD1
 cVccEcm6LIA4EFIDVpxqICfRsE8mqh5bknyJdN2acs1L/GAFrAEcYU28/zkuchyv5QoUYN
 rwox0p4/ghQ+Q8wzlZcUwLPw07S8ImLCz/SlcfNJQQ4vlzxftWHfxCtkwNRvVQ==
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>
From: "WanRenyong" <wanry@yunsilicon.com>
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240910205058.25bf5f8c@hermes.local>
References: <20240911020740.3950704-6-wanry@yunsilicon.com>
 <20240910205058.25bf5f8c@hermes.local>
To: "Stephen Hemminger" <stephen@networkplumber.org>
Date: Thu, 12 Sep 2024 12:14:08 +0800
Message-Id: <8cf9b5e8-cab4-45e6-b959-1d87f8a8ea99@yunsilicon.com>
X-Original-From: WanRenyong <wanry@yunsilicon.com>
User-Agent: Mozilla Thunderbird
Received: from [127.0.0.1] ([222.64.242.227]) by smtp.feishu.cn with ESMTPS;
 Thu, 12 Sep 2024 12:14:09 +0800
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PATCH v2 05/19] net/xsc: add ioctl command interface
Mime-Version: 1.0
X-Lms-Return-Path: <lba+266e26a92+a6b57a+dpdk.org+wanry@yunsilicon.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2024/9/11 11:50, Stephen Hemminger wrote:
> On Wed, 11 Sep 2024 10:07:26 +0800
> "WanRenyong" <wanry@yunsilicon.com> wrote:
>
>> +#define XSC_IOCTL_CHECK_FIELD	0x01234567
>> +
>> +#define XSC_IOCTL_MAGIC	0x1b
>> +#define XSC_IOCTL_CMDQ \
>> +	_IOWR(XSC_IOCTL_MAGIC, 1, struct xsc_ioctl_hdr)
>> +#define XSC_IOCTL_DRV_GET \
>> +	_IOR(XSC_IOCTL_MAGIC, 2, struct xsc_ioctl_hdr)
>> +#define XSC_IOCTL_CMDQ_RAW \
>> +	_IOWR(XSC_IOCTL_MAGIC, 5, struct xsc_ioctl_hdr)
>> +
>> +enum xsc_ioctl_opcode {
>> +	XSC_IOCTL_GET_HW_INFO			=3D 0x100,
>> +};
>> +
>> +enum xsc_ioctl_opmod {
>> +	XSC_IOCTL_OP_GET_LOCAL,
>> +};
>> +
>> +struct xsc_ioctl_attr {
>> +	uint16_t opcode; /* ioctl cmd */
>> +	uint16_t length; /* data length */
>> +	uint32_t error;  /* ioctl error info */
>> +	uint8_t data[0]; /* specific table info */
> Do not use zero length array (ZLA). Instead use variable length array (VL=
A)

will fix it in next version.

>
>> +};
>> +
> Does this device driver depend on some upstr
Yes, it depends on linux kernel driver of the device.

Hello, Stephen,

Thanks for your review,=C2=A0 please see above.

--=20
Thanks,
WanRenyong