From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01815A0C57; Mon, 1 Nov 2021 14:57:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCC6140E28; Mon, 1 Nov 2021 14:57:24 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 663E140DF6 for ; Mon, 1 Nov 2021 14:57:22 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10154"; a="211783000" X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="211783000" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 06:57:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="467310855" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 01 Nov 2021 06:57:21 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 1 Nov 2021 06:57:21 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 1 Nov 2021 06:57:21 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 1 Nov 2021 06:57:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RuCL/8X1SVReklLc3kfmbZrVeFgRd/QgcGnXHONvGfr1jOSGXH/jRqbJ7BgmWFp2hQckjd6wlg7CdC+0wnaNE9FWsrHZFzB9JH64BTX7yrs0Uu5MedNhEjvERCKSbyv4Oh6R3ZA6qcdoukON2zFsPmSCrpybdEwhsN0N72oD/OinfL0wDyGQlQSCoKQB+vd+3JY4d6zA09a0mAvqU7DgKJU1G38oiRrjO1dPzEtpTFh0j9NgNiNI4GT75B0z/NhmRs9y+e7wzGfvjyw6/pgTDPUjXHfRMAYF2Pyy/GfvR/g1bWkNKGLGIKIt6QE9zxXZjL08zv6Cv1Pn5+hzQtaciw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ERPcRTmkYyKa4Y1h2wKysLeIeMF3hx+NympT8ctxscQ=; b=nuOSGjLK2Lw19+6SrAtbenGoOKBeMPp9y9FKudp4OMOm/f0Q4/78MbXzRt5sH+M3zcEBnuuwufhUdWDgGnKhAVK3r+987Q2eYnAfdw+qrtnTWTAvlBhocpEAeTlwkC6Vaq1evuVNlYcM9ifuN2L1PLgtvpdHOzJBtmlS/NCoZTcugwBvtqau5m2PXqhqnNo7LNA+wEn9H9bqRXIHUq0Mg8Xo9POsmCb7C/NOqZP2UeVEbxDSJJKpRQlFvvjYymHYbYOXek/fvolt3oj3KzI9bhA3D4mH4eGaf8y9vHfups6xUD4ClZH787ReVvw1nPiDgrOOHe8OFf0XhG+HBB92ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ERPcRTmkYyKa4Y1h2wKysLeIeMF3hx+NympT8ctxscQ=; b=ZXszPTlc255BxdG39KK+l0ZjUj+WOCrsoTR86yIETsgW9fi/WlBnCA6FMQpS3EWtWWSvTaBZ3yLzGS9JSeHs9YCvYPBRavgb7GakyI/xZx9tAtR7l3fcfPDp8pDlp8Cu7Pmoj7zfyMG4aOY7Qj9+BabZbl36OsuDRFcJX7kq71o= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5093.namprd11.prod.outlook.com (2603:10b6:510:3e::23) by PH0PR11MB4968.namprd11.prod.outlook.com (2603:10b6:510:39::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Mon, 1 Nov 2021 13:57:19 +0000 Received: from PH0PR11MB5093.namprd11.prod.outlook.com ([fe80::a80e:d881:3c58:9730]) by PH0PR11MB5093.namprd11.prod.outlook.com ([fe80::a80e:d881:3c58:9730%3]) with mapi id 15.20.4649.019; Mon, 1 Nov 2021 13:57:19 +0000 Message-ID: <8d028579-2652-0a45-aaaf-6b0599b062fd@intel.com> Date: Mon, 1 Nov 2021 13:57:14 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.2.1 Content-Language: en-US To: "Xia, Chenbo" , "dev@dpdk.org" References: From: "Burakov, Anatoly" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DBBPR09CA0045.eurprd09.prod.outlook.com (2603:10a6:10:d4::33) To PH0PR11MB5093.namprd11.prod.outlook.com (2603:10b6:510:3e::23) MIME-Version: 1.0 Received: from [192.168.1.10] (212.17.34.161) by DBBPR09CA0045.eurprd09.prod.outlook.com (2603:10a6:10:d4::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.13 via Frontend Transport; Mon, 1 Nov 2021 13:57:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: be74dd35-9612-4094-65d4-08d99d3f8553 X-MS-TrafficTypeDiagnostic: PH0PR11MB4968: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k6bmf3AQryDmq4m31rMDrmrTqTcXMqv2GHVOxBwat3SLqDxka/yAq02or6/WpIJ12rsWCWE4jLAEl4THlhe3SjSM+lXmGr5yhRwVuIjXq15CBudDkuHyCvROv9zgHFiOhsN7e9VQ97Kc1MSg7yfdjB8U2a1tTxcWqVEjdcH8DoC8T4y0v7aTM18WcSUhu2Hn1fw3Qp8G8zV/4nh/8JZNq6g4BNy+rPyGvr+hoXV6WLkLS7gSrAauSTOYD6l8+qWQyTOCXa5G3LP7xYLiUFdjpW5eeYD3ZMggyiC24LOC3Eg2i0jWwp5w54adHGtvWxiHN+HrNibzJ3VCHzwbv+EH2pKlqWbOQgykQUYrlWy+6ISiR8GsqaoNg32+jIK2UA5bMuSyii3nvx2PcykAeqCrj+QLZHVRJOajVVc4adt4G2B/PVIXW58pxqhMX4IP6I431uF5ozk+lZDS6TQnz2cXkAcWb/BKAN8TkacZQl4YFt4ox87RtJsHR39UFt6h4xWjNFLwvlgZE2wS64KkpPQxjPKRF4h12PP0n8LvcD8O2VhopMsDxMVvDOUf1ij93Xtzain89rSOTfVQqjuIeEsi7t/VdkPxlFYOACdelEaQ+bhgy3Bp0utfBi5+/Veu8Ht40XH8tdmsTyHoiTYLhDsOo3hooWAz80WolZlRjx4l7iHRI0u8GsG31Mdu5fS/frHDw69zdMNpwXvFlA2+nDDiJ+XiAqO4HrE+EFJAMEMAlbw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5093.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(316002)(5660300002)(31696002)(86362001)(2906002)(956004)(508600001)(82960400001)(26005)(83380400001)(110136005)(186003)(16576012)(36756003)(6486002)(2616005)(38100700002)(8936002)(8676002)(31686004)(66946007)(66476007)(53546011)(66556008)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlBGMUJ3M3M1Z0VaTXJFY1RSWDMwdTBqc3NpSlBFQ0svTkV4Ykh4a0M2NUkw?= =?utf-8?B?ZkhSMnhmUHJWeTFXaTUrNU1HVTBjRHlPWjVJbzd3bGprUE9UQ2NDV3NWYm04?= =?utf-8?B?ZEk5SVYrdFdmdElpeS9ic1dqb0RqMEFheVBMb2QxR3JPTWRVNkJaT1FjMmRQ?= =?utf-8?B?alNoNTNJRGJCaDVQdjlnRGZtV05DbEdON1NYTjBCVm1GTDVHc3JUWFlGK3hN?= =?utf-8?B?cjdvVlJ4UWNNTVgrQlFOMFg0RThyUEVUcmQ4cEFjV3V4UkpIWVplY1RLcmpG?= =?utf-8?B?RXAxODhXbTllUXlNODRRSTlFbnpMbVlZZnlkVENPSkdrYS9YdEhQTXRaVUJu?= =?utf-8?B?UmloUE9RdDVBMkMycW1jR3d2dElCM0o5ZlRnTHBTUmJKMXdXZWFRVHVGQmVz?= =?utf-8?B?Wi9JUzg4R0FxMGptTFdqa0JVMDU5aTdicFNXOUdtVXduR1JlSGF6RW1DcmZw?= =?utf-8?B?Q0JLTlk4aDAvT2w5eFF3YVZzR3U0VVVQbFRnMzZTNmlwRVdUS1FRZHJaVGpG?= =?utf-8?B?RDI5WkJ2aFRwMVRGVG0ya2VDYkxHSENEc3BocXJKMnF3L1MxdGdHL3NONHgw?= =?utf-8?B?dFREcTRmK2EzYlQwM0ZsL1VCcCtCZ2pDY25HanIzeVYvRzRJM1V5VThrZ2VX?= =?utf-8?B?TCtwSkFZZElvV1dWbGw0d0FYcVhUVzVvS3A1TGNmWllPLy9rN3ZYZ0RaUXo2?= =?utf-8?B?SUtDSVBvMThuQmI3U05LOWlwVEh5M1FralQ1N3F1VHA4N25CMDU0YktlbUw0?= =?utf-8?B?YnlPV3dORmJRQmppam85elhvU2xDUDhBMk53VGpXTGpibExPSU15NUtzUWRN?= =?utf-8?B?SkppVHE3MnZKVzZUUitNMnh3elhpbnc5M1g5cHk1MnM5UWJQUHplckZhbGFH?= =?utf-8?B?V01GMEh2a3UwUlVZU2ZBb2NkUm1aZWM1c3ZMWjdhaDNVSEhXVWVyM2lPOUxO?= =?utf-8?B?bkJ1VGpVLzd2TWVjckhsUTFuTFdjVjNLeGZJQmtyazNjN2g1UXRuTGQvZWs0?= =?utf-8?B?b3ZFS2toVHNzUEIxcTlkeU53Q2VQL2F1amJJbUdwMnF1REcwT2pYYVFVcXp5?= =?utf-8?B?OTB2YmNTd1VyN0l5c3Jia3ZOdE16TjZ2L2lXM3UrUGYrR1dWOENITGlobVZF?= =?utf-8?B?RjlmYmpuYTljY1U1RzVCNDZ3VG9VVFZySXM4RDdoVkJUbW8yQlNmaU1zbGY2?= =?utf-8?B?dEkxeXhsMm00dXZETnlweGczbmNjSzYxKzVob29ORitxSnVxVmNqTkVRZGlD?= =?utf-8?B?T2pVbmw2L3VFM0tJekxtdDRzQlBlUDhUbHRlWi8zeGpCL1VYMGsybExFUklr?= =?utf-8?B?TDN2dW5TT0hPYnJQTng4d1FVOGlWSTg4MWh1WHNPaXhORWp5THBTSjd3T01E?= =?utf-8?B?K1R0bzhjd2d0OFYwcmZUS0hQWjZHc205TkpTREthSUlOT3o3ZlFkVXcvaER1?= =?utf-8?B?NlgvV2FIc2RmOHg2RksyQmpLK3h5c3ozOXBzMUhKd25qY2wwWElhOWRKQ01T?= =?utf-8?B?OEthUjM1MGNNaVNSOThZcy9nWjZSZDdGRUdwMFRlNW1EM0pkR25vNjY1blcw?= =?utf-8?B?M0JRQzJYZCtnamlZS28yMkNsRHlXWFpkYk9RWDJXS3VrL2VMTkRtS3RteHVJ?= =?utf-8?B?VGFCdGlDUUxUcGE0Z3UrYTFlYmMweVRneFo4YmhMTUMydzl1SWtwUEd2b0xY?= =?utf-8?B?ai9oMUhOMmJKbU80VG5uVUwwaXYwdEI2ZVZtN09CVW8wTWFhWDBXWWtJQVda?= =?utf-8?B?L1F4MXZ5ZHNNUnNiSVBYRHhQQ1M2Y1Y2Q1NvL2hIUUUwWE5JR1Z6UlZzNndB?= =?utf-8?B?akNSQmlpN2RBbVZML1JPY2c0aHJZUUNaZVNFZkt2cTNhQ0tlOExUalNwTkxI?= =?utf-8?B?dHJxSFl5U2hFUmphdThNbFNvR0lIdys4Sm5raGh3NzRyakphRkxYTitLeFd5?= =?utf-8?B?V0wvZTUraGpFanBCNXU0NlBoQVhEa3B2amNxR2grdzV2clJwa2h3YTdDNVFy?= =?utf-8?B?OGhMb3dFU3pndEhndC96UFlkS2x5cEo1Vy9sdUpFN0JBMC9VQkNsUS90aWd5?= =?utf-8?B?aFhMc0tmblhsTHJ5SnFWQmNHYnlhcG9nY0RzOFJWMUIwSTBOK0o0L1R2TFJO?= =?utf-8?B?SWQ1Zk5oN3RIenlRcXFqcmdkRjlxSGF4Z29kSDBRdWRha24yRUZpdTMxeU9M?= =?utf-8?B?TzBPUjZVZERKdGhkZ244MzBVSEllcS9Jd1lwaU1xcHFhVGlRQTEzeXhrQmNX?= =?utf-8?B?ZFNwb255eGlCc0JzaFVpMmxRcUh3PT0=?= X-MS-Exchange-CrossTenant-Network-Message-Id: be74dd35-9612-4094-65d4-08d99d3f8553 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5093.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2021 13:57:19.8366 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UEyv3PgJWpsBQV9uG+WR8am21OcuirmtZU2WpOH+OZycVgn2Zw1+vQ0pKqGrXXjPrI2W14fFWMc/+eJ+8HU0lKMhC16ZOiq2W4pvbKk+Q6o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4968 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 1/4] vfio: drop fallback Linux implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01-Nov-21 6:27 AM, Xia, Chenbo wrote: > Hi Anatoly, > >> -----Original Message----- >> From: dev On Behalf Of Anatoly Burakov >> Sent: Thursday, October 28, 2021 10:15 PM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH v3 1/4] vfio: drop fallback Linux implementation >> >> Currently, VFIO support for Linux is compiled unconditionally, and >> supported kernel versions start with 4.4, so VFIO is assumed to always >> be enabled. There is no way of disabling VFIO support at compile time >> anyway, so just drop the "VFIO not available" fallback code altogether. >> >> Signed-off-by: Anatoly Burakov >> --- >> lib/eal/linux/eal_vfio.c | 110 --------------------------------------- >> 1 file changed, 110 deletions(-) >> > > If we make the 'kernel >= 4.4' assumption, should other 'VFIO_PRESENT' in eal > and drivers be deleted as well? It seems strange to me as eal_vfio already > assumes it supports vfio but drivers and other eal components still have the > check. We still need those checks because those drivers are also compiled on FreeBSD etc. - so we're not removing the VFIO check, we're just removing the fallback implementation for Linux that was, at one point, possible, but now isn't. > > Thanks, > Chenbo > -- Thanks, Anatoly