From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id A32305599 for ; Wed, 23 Nov 2016 16:26:29 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 23 Nov 2016 07:26:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,538,1473145200"; d="scan'208";a="1063305961" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga001.jf.intel.com with ESMTP; 23 Nov 2016 07:26:27 -0800 To: Andrew Rybchenko , dev@dpdk.org References: <1479740470-6723-1-git-send-email-arybchenko@solarflare.com> <1479740470-6723-32-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: <8d244f7f-59e1-bbe8-9df4-45bff3e3e5cc@intel.com> Date: Wed, 23 Nov 2016 15:26:27 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <1479740470-6723-32-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 31/56] net/sfc: implement dummy callback to get device information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2016 15:26:30 -0000 On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: > Just a stub to be filled in when corresponding functionality is > implemented. What about merging this stub with real implementation? Or perhaps replace with code that adds dummy .dev_configure? > > Reviewed-by: Andy Moreton > Signed-off-by: Andrew Rybchenko > --- > drivers/net/sfc/efx/sfc_ethdev.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/sfc/efx/sfc_ethdev.c b/drivers/net/sfc/efx/sfc_ethdev.c > index ff20a13..0deff07 100644 > --- a/drivers/net/sfc/efx/sfc_ethdev.c > +++ b/drivers/net/sfc/efx/sfc_ethdev.c > @@ -37,9 +37,16 @@ > #include "sfc_kvargs.h" > > > +static void > +sfc_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > +{ > + struct sfc_adapter *sa = dev->data->dev_private; > + > + sfc_log_init(sa, "entry"); > +} > + > static const struct eth_dev_ops sfc_eth_dev_ops = { > - /* Just dummy init to avoid build-time warning */ > - .dev_configure = NULL, > + .dev_infos_get = sfc_dev_infos_get, > }; > > static int >