From: "Hunt, David" <david.hunt@intel.com>
To: "Abdullah Ömer Yamaç" <omer.yamac@ceng.metu.edu.tr>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v3] examples/distributor: update dynamic configuration
Date: Fri, 2 Sep 2022 10:12:12 +0100 [thread overview]
Message-ID: <8d2d8a00-15ba-29ff-b261-69c3930dcd14@intel.com> (raw)
In-Reply-To: <20220901140951.291068-1-omer.yamac@ceng.metu.edu.tr>
On 01/09/2022 15:09, omer.yamac at ceng.metu.edu.tr (Abdullah Ömer
Yamaç) wrote:
> In this patch,
> * It is possible to switch the running mode of the distributor
> using the command line argument.
> * With "-c" parameter, you can run RX and Distributor
> on the same core.
> * Without "-c" parameter, you can run RX and Distributor
> on the different core.
> * Consecutive termination of the lcores fixed.
> The termination order was wrong, and you couldn't terminate the
> application while traffic was capturing. The current order is
> RX -> Distributor -> TX -> Workers
> * When "-c" parameter is active, the wasted distributor core is
> also deactivated in the main function.
>
> Signed-off-by: Abdullah ?mer Yama? <omer.yamac at ceng.metu.edu.tr>
>
> ---
> Cc: david.hunt at intel.com
> ---
LGTM
Reviewed-by: David Hunt <david.hunt@intel.com>
next prev parent reply other threads:[~2022-09-02 9:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 21:13 [PATCH] " Abdullah Ömer Yamaç
2022-06-28 19:54 ` [PATCH v2] " Abdullah Ömer Yamaç
2022-09-01 10:58 ` Hunt, David
2022-09-02 5:20 ` Omer Yamac
2022-09-02 8:37 ` Hunt, David
2022-09-01 14:09 ` [PATCH v3] " Abdullah Ömer Yamaç
2022-09-02 9:12 ` Hunt, David [this message]
2022-10-31 15:03 ` Thomas Monjalon
2022-11-24 20:05 ` [PATCH v4] examples/distributor: remove dead code and renaming Rx,Tx Abdullah Ömer Yamaç
2022-11-24 20:17 ` [PATCH v5] " Abdullah Ömer Yamaç
2022-11-24 20:22 ` [PATCH v6] " Abdullah Ömer Yamaç
2022-11-24 20:31 ` [PATCH v7] " Abdullah Ömer Yamaç
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d2d8a00-15ba-29ff-b261-69c3930dcd14@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=omer.yamac@ceng.metu.edu.tr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).