From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 495E3A0540; Fri, 12 Aug 2022 00:21:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3584F406A2; Fri, 12 Aug 2022 00:21:27 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id DF5B940697 for ; Fri, 12 Aug 2022 00:21:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660256486; x=1691792486; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=k9Pxvt+dZ1q9DOR2dtB3Jk6AmjIE3/W5OHv6Wz9NnVQ=; b=ipKG5bfWkSboNBtz2j4+k9NrqI5zqUlEIuiAjrTXR/Wv3w/XrDde1/5E Kjyr+dWb5G7l//vSr2tJQQqRcn0ZmgQ9vKE6mpul9Q09jK/IGqqlPwqiz mmNDrf+fO6O5xW5ZIac02yvcGJ/KjX80eyMcpXqT4rJG1cAXTLIvw3+pS /rxZJr3y+HRHh9R8B5b34gmBsWgF3S1yEfALP7ae8fSOPom19bJno73vV 8wOznd8WtetI9ZX7BjeN0RYuIhDanXQPkRxND+n0SjskDu7xZEksySvys ty2FjfBsm0jPjUmCBVNrPtjqeGFM91XgezhF5YYQzAXjACaLIYiJbHA8u g==; IronPort-HdrOrdr: A9a23:V6jW7KmRMLLw3l8PbqR6rccPHdTpDfPLimdD5ihNYBxZY6Wkfp +V7ZYmPE7P+VUssS8b+exoWJPwJE819fZOkPYs1MSZLXTbUQqTXedfBOTZskXd8kHFh59gPO JbAthD4b7LfC1HZKTBkXCF+r8bqbHrnM/H5Ja7vhBQpENRGt9dBm9Ce3Sm+yZNNXN77PQCZe ahD4Z81kGdkSN9VLXJOpBDZYP+TpDw5d/biBg9bSIP2U2rt3eF+bT6Gx+X0lM3VC5O+64r9S zgnxbi7quunvmnwluEvlWjoKh+qZ/E8J9uFcaMgs8aJnHFjRupXp1oX/mnsCouqO+ixV42mJ 3nogsmPe5093TNF1vF7SfF6k3F6nID+nXiwViXjT/KptH4fiszD457iYdQYnLimgIdleA59J gO83OStpJRAx+Ftj/6/cL0WxZjkVfxiWY+kMYI5kYvEbc2Wft0l8gy7UlVGJAPEGbR84Y8Ct RjC8na+bJ/bU6aVXbEpWNiqebcH0jbJi32AHTqh/bllgS/xBtCvg8lLY0k7zk9HasGOtp5D7 +uCNUuqFlMJvVmJJ6VSt1xB/dfMVa9Ni4kAFjiVWgPK5t3TU4li6SHq4ndt9vaMqDgiqFCwa j8bA== X-IronPort-AV: E=McAfee;i="6400,9594,10436"; a="278421898" X-IronPort-AV: E=Sophos;i="5.93,231,1654585200"; d="scan'208,217";a="278421898" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2022 15:21:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,231,1654585200"; d="scan'208,217";a="708786082" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga002.fm.intel.com with ESMTP; 11 Aug 2022 15:21:24 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 11 Aug 2022 15:21:23 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 11 Aug 2022 15:21:23 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 11 Aug 2022 15:21:23 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Thu, 11 Aug 2022 15:21:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PX8O/SBlwlhn3GYMrP4jy86oXkxecH0rgpCy+0E3Sl0Us9g+eHOS/RNN1AT/4YIBbuNtVTsZiI9vZuSl+qJwzSopnpRUc2UxLp0mMRRUfF6TfNtSsN+HHN643mOOzXacVZFoHwlJ3TpI6Mmx5Fn1TcNpvwtnkoxoCfeoiLTgP/XGDagHwzDb+lr26p+ZZkF1h4u/vq+ZQKU6F2Ehes2MT8rUbB3J6f8ABsPRRzzxJ9RX4YwKNu1VI2q4/j2BP3gGJI3N1Cpg2GUYvg44eMyRCwm0CL2364qS6tGoWVymPSDHtyaUR59dzNhCyRUfpFziK9d9aTJiJHcKdyPDAkLQTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pqph4USVtrQQ4fxyky5tjJWqhe5tNRHsGxj91YnB/9I=; b=MVMB/SiPOU2n07CfYrSqzo8ae1PjdOeXCkevSxoQSNyP4iTpJnbTK9pOX2+XM6ZmuCKwHpzmDoz3mDM0Pg5FEcT1OemDjxSOi2mabONPq8At+/SXWA4nfFfJ/adTa4n0RUtHqRuXCAA449A8vHjGRsqMjLjNd+GI1et4fXKhDryH0EiFsmC413lBRXl4ES+v8CdFs2z1XxnKDgBlqvRw0BjGdxMSv8yYEZVKChUK6m66eLIJ+h0kkPf22TBfpNdfB6EDcy+mn6LSkzzxYzP8o9CGtxTcScAoMk6pA0r89t03ScqUJJ13riSXsK5hf8slLqLx09nWvnxqaRp5P7x3HA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW5PR11MB5858.namprd11.prod.outlook.com (2603:10b6:303:193::20) by DM6PR11MB3497.namprd11.prod.outlook.com (2603:10b6:5:6e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16; Thu, 11 Aug 2022 22:21:17 +0000 Received: from MW5PR11MB5858.namprd11.prod.outlook.com ([fe80::9f7:4b13:97b2:af8d]) by MW5PR11MB5858.namprd11.prod.outlook.com ([fe80::9f7:4b13:97b2:af8d%4]) with mapi id 15.20.5504.023; Thu, 11 Aug 2022 22:21:17 +0000 Content-Type: multipart/alternative; boundary="------------Spfhgc9V07FjrOZ0cHzYBikk" Message-ID: <8d41fdbd-b14f-41d0-0ff1-cdae455a08e3@intel.com> Date: Thu, 11 Aug 2022 15:21:14 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [dpdk-kmods] windows/netuio: fix bar parsing Content-Language: en-US To: Dmitry Kozlyuk CC: , , , , , References: <20220802191058.1779-1-pallavi.kadam@intel.com> <20220807000113.4f773581@sovereign> <20220809121548.00a18082@sovereign> From: "Kadam, Pallavi" In-Reply-To: <20220809121548.00a18082@sovereign> X-ClientProxiedBy: BY3PR05CA0051.namprd05.prod.outlook.com (2603:10b6:a03:39b::26) To MW5PR11MB5858.namprd11.prod.outlook.com (2603:10b6:303:193::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cbfdde34-294d-4d0b-6fb7-08da7be7cf61 X-MS-TrafficTypeDiagnostic: DM6PR11MB3497:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FvB7bnaxO9bz7cMeAJTUfuhF80b6XTRmdUTts8NiTj11TdvFdCcbfuvnyZg5aBeYVa9NF4uwrsvJM1A1f++cngTjADpM+2rmfzparse2idNlY6jOD77FNY1/+FLr5qadeX+znXSksc5EzUN++VjVonrmdq7zrZ8CBvVGUEpYdMVxQC1hv9+tMe3mAOU1Fb3A1cvAmLBGblCTWPvzocrvHGUfYjDn9wDtOgE6P0LwjEnx8NSOqNAxH/ey4cEB2LRP4GVgsbp51rMlbeEVAUAtqPErMaGjz1nKzFPLJPkQvg52XfaC/LbhsWOmQZDhcnOARIutPG8sMre69ZGktwFTNtCBosX7snK3qiRIfNy5t1+N3xMr/3gsHWN9Z7raEy6fBlFYkFTHW1+ru//qlHlxCO0Ag6/NCZsMGp2PBu7VkXDzysa3QM7Ba1FaC5M7LGCvYl+WbyipygP0T+CPRtdJdHIVU5MkLlNCxUbd1RsjAzI+LhVP/hfwvXBrEQibR68/EONw28kylJ+IkSMUIRBvoW01XkJayev11rNlr2TWDXVarV5umtMvcXGOvpt0ve3en2/cTrCuWnOxvH5WPNuC3yvrZKxroBpOSYsHUm2m0jHEXLMc+Iv6B6uDVGKgJgiYPC+axENtt5LM5a0MdmbmLq2S8ZzYdkOWdd/Y950LncItciCbIIT264lmzA06OYlXr6X1TiroCgtLdYk3LCq7sd4iVEqxYSw2xef70eM+bv1ckDZEmYS/OsdB350r3Kqx41TPPf4Iw4EJ/hpuePK5VvbMzgc/FfDktzwBx/wfMQ6FmuAQrF1bYyBpdV4fTR17 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5858.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(366004)(136003)(376002)(396003)(346002)(8936002)(38100700002)(82960400001)(6916009)(6486002)(2616005)(478600001)(31696002)(41300700001)(66946007)(8676002)(4326008)(66556008)(66476007)(26005)(2906002)(6512007)(86362001)(5660300002)(6506007)(186003)(53546011)(36756003)(6666004)(31686004)(33964004)(316002)(107886003)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkpEM3o0Q1R6aHMwdndQQ2p4UHFPbGxLa2tQdEQ5MWFRWGRvU24vUXBMSWFk?= =?utf-8?B?Qk9EWVNKN0RBazdMcStQTlZMSkpHSlhXbld5TWZSa0xlZ1J6NTI3QTNQZGhW?= =?utf-8?B?SzMyZ01PM2t3QW9zOW5PVktDRFhIczY2Y1VLc0VBMmc3cXRxc2R3UVl2OHF1?= =?utf-8?B?UEFLRjlPa0tBTm9wOXFveStOWUZ4dVFtOStoaHgvUVBxREZ0bFhybW9STzh1?= =?utf-8?B?SW5Bc0V2b0hYaHdNbk1zNFEyMnNNMngwR29xVHBKVDhHeVhjQU9uYUZTcGRo?= =?utf-8?B?K01KVlRJK3g5Ym8vSDBzSk9oNll2STFORlpzTm9pb01taUhRZ3lOQlZyYmdR?= =?utf-8?B?ZVY3d052NjNpU0UzalB5V0x5UHdBNnUwbmVHVUVHeG96bkJkcSt2b1NKcDVT?= =?utf-8?B?cXlYa3BLYTVjQkMrRlVjZEQyYUxXS2NrUUhLU2orQzZBYVh4UzBZalVmUm40?= =?utf-8?B?cE9lOE9hc2F3TDkwYURtMjVhYzk5UWx2Uk1DclhQREJYTndPU1pVV3o4TzVY?= =?utf-8?B?bkpRVXNoelN1OHU0Y3F0Mk1rTHVlTGJFKzZNZEdIWktXM0RZTEZEVDY4ekFW?= =?utf-8?B?Vlp4d0RyOXBqYzYya1lZVkxSNnZBN3VBYmw5SU1FbzdxRlo4TnlRak05bkpG?= =?utf-8?B?QTBiaytrMCtPQ2tLdnppU0xoaXNOMXAwQmJIWkUvcXF6ZGhrMVJzSCtTWHNO?= =?utf-8?B?YTZsbnhDbEV6OW9ISHpXeldCdVZkcDI1VDBNbk52SXJUclZMakVmTG1jRmdS?= =?utf-8?B?QjhHcDVOUGZlYTRIRHZRMnhjWHlMdVgyM1R6WGw4VFB0MVRETkd6dG5LSFdm?= =?utf-8?B?aWE1eGhzd2lBbVpWUEpXUlVZZ25MNENlUGREeUoyRkp4aGYrZnVXeWNCV1dX?= =?utf-8?B?RDVBQjI5WURGY1ViRE5BZjljUi9RVVlVM0gwTUFKc0xKeXFhUSt5MVJ3VS9O?= =?utf-8?B?bVRlSmgvS3JHVVhySU9XZHZFRTBZUExPNHJaMVBsYVdRTFVLdHg3UVZpK0Z3?= =?utf-8?B?WjhRcFJQS3l1VWJYODVKbmdMWHBnZ3paOWYvZGRjd3BoeE1pSm1VM2N3bm80?= =?utf-8?B?NUQwZU03RVJZYk82SmQ0RUUyM2w3eFZMQkZqbDB1WFIrRnNvbG00Nk9vVjYy?= =?utf-8?B?cmtvZnV0MlBWNzFnbXRiUk1MaDQ1anVzVG9YOXdYWjY2RUpob2IrT1BrK3FZ?= =?utf-8?B?YkFEVWI5ZmtmdUNMejNmbW1nZWRRYVRZcUZGQ1JlV25tdWhrYmJtZjZMZnZu?= =?utf-8?B?a2NpNDZpcGNsQWF4VUVNSlV3Vzc0T1FBVjBmQkhSaW54OTh6QU5PWElQQ0Ji?= =?utf-8?B?YVFwdjNrTWx2U2lYSGxQVk1ZMnczNDlpa01NVmV6WWhKYy8xNmVIRHJFdzRV?= =?utf-8?B?Yjk1ei9hZ2xWZE9Id2xKWWNlbnhrMXdsNGgzdHhzbmN0Y3p1ck9iQ1krS042?= =?utf-8?B?V0Z5T0Fxb2lTQ1pxbTViTTFwM3R6KzZlZFRXS0RzcExDSGdEUTFxWEpOdXJw?= =?utf-8?B?ZXdLS1Nqc0FlQ1FWeU9wb2kxcDZIWEZBOUFxSTZlWDFFb3Y0WmxiREsvbHlm?= =?utf-8?B?bXphenpoWkNPNC8xYmhmUWw5MlV5a2thaFdDMkZUbWV4R3Ruc0xFSmhja01i?= =?utf-8?B?ck82emloUE43b1krcGtYQVF0WUhpb3pNQ3pLUCtZOTA4N0crS0JhY1g1QWht?= =?utf-8?B?cWUzQkd5bCtWdEcxWE9Td0dsUmJaOVBiRTVhRkFCazZzU21tL2lvbzBqOUpM?= =?utf-8?B?WTJCTUNxWlNqRDl6ckZmR1FEZ3RDSWVKTldPL1c4dllhTlk3dmhvZG81UGt6?= =?utf-8?B?MTJ1L3FTMjgySjhNUk1wMHMzZkNRVk5KeEFwdTQ4OEc1VmgvRnBQTStkeHJE?= =?utf-8?B?NThEalRIQUpxUFU4RHRHbmZlc0x5UEwyYzdXTlNXcEswWEV5V1pEQkE0QWxm?= =?utf-8?B?b3pOUDZnRmZTYm92NlpYWDlseG9Zbm8zSkhoc2VzL1FhYTdHdDllVjFlMyt0?= =?utf-8?B?cXovYm5WZmsxNUFXYmNrR0lOUnZzZ2ZrMGdBNm05cU1xTW9MT2lKZVVwWEJ6?= =?utf-8?B?L1FkY1pkdXB6RXBLTFlvS3g0dnZiR1NKYUxNRlRpN1BSczJoVDJVbTVRaXFF?= =?utf-8?B?RzI0TXdNREZ6T00zUVNTUThaLzZIQytWdVJCQUU3VUJ2bmgrVE0vZ3hWL0tO?= =?utf-8?B?NVE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: cbfdde34-294d-4d0b-6fb7-08da7be7cf61 X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5858.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2022 22:21:17.4996 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C+YKVXvTrtVsB7ZsPJt54gfM0tK+iFFgTBV9B8BPaq8h2W20s6laslCnuC/j41+oS94RbULcVyHRJ/0+YqMWYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3497 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------Spfhgc9V07FjrOZ0cHzYBikk Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 8/9/2022 2:15 AM, Dmitry Kozlyuk wrote: > 2022-08-08 17:33 (UTC-0700), Kadam, Pallavi: > [...] >>> Hi Pallavi, >>> >>> In the first place, it was wrong to always test `prev_bar & PCI_TYPE_64BIT` >>> because only the first BAR slot of a 64-bit BAR contains flags. >>> The current code has a state to track (curr_bar, prev_bar), >>> and the fix is complicating it even more without solving the root cause. >>> I suggest a simpler fix (not tested!) >>> that eliminates both the incorrectness and the state to maintain: >> Thank you. This change works for us. >> >> Please let me know if you would like to submit this change as a new patch or if I should include it as a v2 of this same patch. > Please send v2. > You can include my Signed-off-by. > You might also update the commit message and capitalize "BAR" in the title. Thanks, Dmitry. Have sent v2. --------------Spfhgc9V07FjrOZ0cHzYBikk Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit


On 8/9/2022 2:15 AM, Dmitry Kozlyuk wrote:
2022-08-08 17:33 (UTC-0700), Kadam, Pallavi:
[...]

Hi Pallavi,

In the first place, it was wrong to always test `prev_bar & PCI_TYPE_64BIT`
because only the first BAR slot of a 64-bit BAR contains flags.
The current code has a state to track (curr_bar, prev_bar),
and the fix is complicating it even more without solving the root cause.
I suggest a simpler fix (not tested!)
that eliminates both the incorrectness and the state to maintain:  

Thank you. This change works for us.

Please let me know if you would like to submit this change as a new patch or if I should include it as a v2 of this same patch.

Please send v2.
You can include my Signed-off-by.
You might also update the commit message and capitalize "BAR" in the title.
Thanks, Dmitry. Have sent v2.

    

  


--------------Spfhgc9V07FjrOZ0cHzYBikk--