From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id C9A7D1E33 for ; Thu, 25 Jan 2018 09:22:25 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id r71so13074746wmd.1 for ; Thu, 25 Jan 2018 00:22:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=q5HsJtPrpY6Kp/gEJi2SHLFSDk74zSi1dQSWWQR1qmk=; b=DsnK918LyCWyCgc0z2MZqwlf0jm05kNue0tNlQZhVl46KDLbRzuiQlOEBxjRy4027Z BwJMT7IfrQ9p3v+malOuB6DnRocyto5QDy9DQ5PYC6RH/mhL3LQnDcvgH4iniVST8g8B YiFRB7JfbrtTngV1iIQXBTdFVnyW0w+JtlsdW4Kapzmo7feGllnSzVUHbG7Xd6GZWu/2 +a3n5xF3bKP70E565ZyXnN3wlGDmtvwRAZ5NAzXhOPuSKZatFKWIQKeZEuVh1/I5VhEW AFO6N25D0ew1RN9jT2tVC+Bdo8lqslw3n4uF6iDVroa1fUIHhV/lRTRUQ8bO3qEWAMhk JuDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=q5HsJtPrpY6Kp/gEJi2SHLFSDk74zSi1dQSWWQR1qmk=; b=HsCCrDuF0aGHVr6dyrNt8waud/5iPHoODvxPrZlV0rXJBRZj7k2O1KVDtAvhsnWC7o CTwU7Aaoch0pm8YZRLYQ8cm0zAAstj+x38ViuU47N0kL2GwOZfsD8JgCt0xQ9wt7tsYH drhfX+DpVKTKXH1pwG4dXfqHpktuHE0usTRcVK7TT3VNl7fE6kaLdzOGZr0+ezQsRw6G foUC1NTvHujRoJo5+DQmsJWfx/70JvyoMvsi5DZibQ6SMMg0MArcx8HYyfhcJXX7qU4s Xg0wz1PJMrtkDWHLODBpfcCcI3TGt9YrvCpSKrG+eyeiNGzhAx5/awSpFTFHuluGRPpU UfdQ== X-Gm-Message-State: AKwxytfbTq+xPmlDbQnTwd9xj1IZ7BIULCQiU630f2QgiOik4b8WeMGY HY5DwJfwGEKUrmbA2ZSwp0/SeZIe7A== X-Google-Smtp-Source: AH8x2257a5R/h4Z9muqhI9wyPOnEZr5FNXXL1XoqVVWiq22dOtz7xj3Kpdwp/ZIP7X5+bmxgi06N8w== X-Received: by 10.28.65.133 with SMTP id o127mr6619114wma.130.1516868545421; Thu, 25 Jan 2018 00:22:25 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id t14sm779193wmc.23.2018.01.25.00.22.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jan 2018 00:22:24 -0800 (PST) From: Nelio Laranjeiro To: Adrien Mazarguil Cc: dev@dpdk.org, Shahaf Shuler , Yongseok Koh , stable@dpdk.org Date: Thu, 25 Jan 2018 09:22:19 +0100 Message-Id: <8d4931d99cd295d8779aefa21900a4e2779e7000.1516868517.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH] net/mlx5: fix reception of multiple mac addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 08:22:25 -0000 When promiscuous is disabled, adding/removing a mac address is ignored causing the packet to not be received or still being received corresponding to the add or remove request. Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") Cc: stable@dpdk.org Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c index a5e78ec8d..a1cb987cb 100644 --- a/drivers/net/mlx5/mlx5_mac.c +++ b/drivers/net/mlx5/mlx5_mac.c @@ -95,7 +95,7 @@ mlx5_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index) { assert(index < MLX5_MAX_MAC_ADDRESSES); memset(&dev->data->mac_addrs[index], 0, sizeof(struct ether_addr)); - if (!dev->data->promiscuous && !dev->data->all_multicast) + if (!dev->data->promiscuous) mlx5_traffic_restart(dev); } @@ -134,7 +134,7 @@ mlx5_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac, return EADDRINUSE; } dev->data->mac_addrs[index] = *mac; - if (!dev->data->promiscuous && !dev->data->all_multicast) + if (!dev->data->promiscuous) mlx5_traffic_restart(dev); return ret; } -- 2.11.0