From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10064.outbound.protection.outlook.com [40.107.1.64]) by dpdk.org (Postfix) with ESMTP id AB2A31BBBA for ; Thu, 12 Apr 2018 10:53:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=sBgu3q9Up/lIGhHnsfkPH81N12JF+cJh9R0zY1o9DNI=; b=V1CBRO3VUuzJuIFH8ibDIq2m14VcZvrpua+QJgUK1cE3yLWemG0vYLGBh4BDd5cBNZ6nX82F6mbO16fRJUdBnuhpywLKF6zsoyUXxkAxvdpfw9z6oKx7spL+QMzJCeunhLOxoLmlWvyThDvXe5YpbhgJMaDrWgwguQwhikaEqcE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [10.232.14.39] (14.142.187.166) by DB6PR0402MB2775.eurprd04.prod.outlook.com (2603:10a6:4:96::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.9; Thu, 12 Apr 2018 08:53:06 +0000 To: Thomas Monjalon , dev@dpdk.org Cc: Ajit Khaparde , Jerin Jacob , Shijith Thotton , Santosh Shukla , Rahul Lakkireddy , John Daley , Wenzhuo Lu , Konstantin Ananyev , Beilei Xing , Qi Zhang , Jingjing Wu , Adrien Mazarguil , Nelio Laranjeiro , Yongseok Koh , Shahaf Shuler , Tomasz Duszynski , Jianbo Liu , Alejandro Lucero , Hemant Agrawal , Harish Patil , Rasesh Mody , Andrew Rybchenko , Shrikrishna Khare , Maxime Coquelin , Allain Legacy , Bruce Richardson , Gaetan Rivet , Olivier Matz References: <2759953.P7QpFFSjiU@xps> From: Shreyansh Jain Message-ID: <8d60cdac-dad0-bd6b-f515-8166589fb099@nxp.com> Date: Thu, 12 Apr 2018 14:38:16 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <2759953.P7QpFFSjiU@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0103.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::19) To DB6PR0402MB2775.eurprd04.prod.outlook.com (2603:10a6:4:96::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB6PR0402MB2775; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2775; 3:lPIURVwQ68UR0wIOGst3AuhsOLuqIVpgb0xh7Wh4wBgfkhWJee2PJhwNhDfCI+eI6ErcEAGEdS8X9CHuVdV67ktmmlRmCsF2HftKbYBVN2qsp1b0A5btZG8TWNjX5SM2nktFuqcCKUQ12CUwmjKj0gsT3C4+qKkW/EMa+963jOF6n6xW203XKOuyQnvq8m3IjwCm54m4TMYoQ6la0++Us+Ca+Ycyt24p+FDt9mV2k5llOQmEDVQ/eMAg2nAT/Fvd; 25:gAK9cOYQWd323m/ApSpUpNv/Pivjto3UUHOHWmHp6fH8Vx6B61xyMkEH9FYHTHO2KwAv44QYuedh5uS9zDGVotd6va6Juvs86iEjwl2DU/nWNULGzhwEXv7CVX1khW9VpjUf8SecK6yFtqQYs5aTwrxmxLy7R1r2eD2cXBuG4x60bvInjkSt+Uci8g3jb5SeJcKqmm2c1SZibhIZUJmPH1y+jipn7AuDaN4SVHDlSzzYekwaliCvpRqzzHvcuQpQ2cSvoIEGxQMK25Q+VVtKeX8lFRGOUKmAWQvlibll0T3cBXkxkAPwopVWyvBOWOJ+QeQujTB9P663yR9zd8LcHA==; 31:N1K5Eyo1GVlKPqf2PdxiVh30MrU5qcq8cPJU9wSF7zBUujM2+YgNsyq8c5fbvEk+3AuKmLBvxoRKAxtFN2MMjkr+mfNKL5DJRvdbrr1WtWbVO381HWeTARaezrVGZ+AfWJkYa3GXG+y3xYSlBX11mQPCrp7pZ3gGzOBAkSqImGXadv6myK0yWcinDEP9H8PtBTthtX5LAqVc9EeuKKmpSKFMKoXF7Agp8VK9pAyEvJ0= X-MS-TrafficTypeDiagnostic: DB6PR0402MB2775: X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2775; 20:mI6Vk05Axm0lYjB0Y6Kj75AOxyW3fudZUbxVvfLk/wPV+s8X4y93eqB7FgX4NbB3Q6BmqLTQi5uFh0nfCuB4JFM3wMoUvNeRACglIm4fryYbAg+PLXBuuiQx5QQokierzUAApt6ScwJAS7UVDVaFGHunEKY2eZDta8OR9eTHk5d+BJHd6h8/T10Ka9mmjHPOiK9TtcM3tSKvAgIwBRpA/Uw9QXWkPdq+823nNafSRoNMWWJLSpLdlJr2Myek9bYGMq0XK8KmjqZ4gAKoOVnmPxpCc9EJNFNqXhzcuEpo/0K1GNRNkFrURzfWuXYSfCGJAf3kcl1X944p/kB02JpS6hLxk7OSjVbMuhq5lLdvJyB9YvSSvR7NUoFR6hdEV6I+0JBi7uZKoZDTQrnuGHeyq6ZEcIihfW3FpC6ezzOYAWLrTVYWBQJ0NOAYQ5eD4ZzPANPrb94WotDTtSGM0rU5yd3zomkHBYLkZ7e3w08nv9c+GEBSFJvDtDlDbGNJ3/Yd; 4:uWrNYbOy2gaKO6zC+T6WmN48SD0q4d4FgIQKunk4cuYRqy3MkKHgn/gkPozH8Z1VnmRVF2a7HKqR/OGFUSE+z3jz5Iiu75tjmGWbcsSrwbq+TVptML7j0KujaYnKlolB9soVtu6igHPGUyJz4650ahosHC0mQLO5oLFXJm6YV03ZBBLnlU6zD9vKijL+w3W3UygV07yo4ea1VO4Mr0xKN62Vayhnmu0vJa/PANbbVs/y9/YOosbENaUKA9yUGloIDEUeiFheoPkGIn6IjrQ4XSALQFMF/d+BIZ/wPJVoncC4zOuX1vSil5AOcJhkn4La X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231221)(944501327)(52105095)(93006095)(93001095)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:DB6PR0402MB2775; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0402MB2775; X-Forefront-PRVS: 06400060E1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(39860400002)(396003)(39380400002)(366004)(376002)(346002)(199004)(189003)(2486003)(478600001)(68736007)(23676004)(54906003)(53376002)(186003)(2906002)(6246003)(52116002)(97736004)(5660300001)(53936002)(86362001)(966005)(486006)(76176011)(36756003)(52146003)(5009440100003)(39060400002)(67846002)(4326008)(44832011)(106356001)(230700001)(31686004)(16576012)(58126008)(316002)(31696002)(26005)(305945005)(77096007)(25786009)(3846002)(65956001)(65806001)(59450400001)(47776003)(66066001)(386003)(6666003)(6116002)(8676002)(8936002)(229853002)(55236004)(11346002)(956004)(446003)(81156014)(65826007)(105586002)(81166006)(6306002)(64126003)(6486002)(7736002)(7416002)(476003)(561944003)(16526019)(50466002)(2616005)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0402MB2775; H:[10.232.14.39]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA0MDJNQjI3NzU7MjM6eGkxK3ZnV0kvaDNlNitURnI5T0YzblR2?= =?utf-8?B?eHBDdmJYYm9HVnNRcXhVMEYrZ2FNdi8va2NvVTZjSkxqWjhjc3k5bTdYaG5i?= =?utf-8?B?VWZGc1F0WGkxbTZWWlFaS25WNytRdkYwbGN5N3BKcndKU3ZLbFl0eCtoNUpC?= =?utf-8?B?c1ZYR3FJTHBKZnN6OEpZeXRBemduWmYrUlUxZGw4NWFwZ3JEbThCbTdVR1Br?= =?utf-8?B?MDBCakpGV1N0R0xIcktnTytUdit4YXJzcTlyNFA4akJvYVlZUldVNmU4TE9w?= =?utf-8?B?UGVUNFp5RktOQmd4RlhubEVyVGdSeVpwSjZRSytRUG9PdVpid1h6KytEMlJk?= =?utf-8?B?OE5YaHFTeE14aDVmKzY2VG1VQmJnYVFpTmYwczE1bkt2ZUMrUXI2MUxqeHY3?= =?utf-8?B?MHpUb0kzeGlXWEhXMUl5cTM5NnQ4TjU0WWxxNXNNRVlRSy9oL2lmZHRXRzJE?= =?utf-8?B?aVVraHMrR0NyRTNhWS9EcTd1YlI0OURpZGxZZFJMRlN2NjdZZlkxSGptSDRn?= =?utf-8?B?all1M21uWFdKOGxHSGk5K1hPMEhsQS9iR25kWk1LVEVoekJxa3dLZUcwdllS?= =?utf-8?B?MVUybkpXMHBDNUEwTU0rOExQbW53ZzJCLzVJeC9pTUVwT0dUT1FNamdpOTJH?= =?utf-8?B?eEpWZkZDWVduTjBaQ0pqQlFlandtNHVMR2RQRU9TTS9jclc0akFZQUtrR2Vk?= =?utf-8?B?MGxxTHdoQXVUMGFmeEgySjdqVG0vZ0lpZVFUZDQ5N3pxWlVKUzNOUldTb2sz?= =?utf-8?B?c2k2bW13YzliUTlGZEtjNmdBYnhwUlRjR1Fhak8zYkhyZXZXaVlpYlNxaW1r?= =?utf-8?B?V01lWll2bGNPbTJTVHJSZEdlbmNFMVdEVTZqNDMvcjZFclkyVjFtZklaWFdP?= =?utf-8?B?WS9nWHJ1YkorU0Fmd1Y3azVnaEhUSjlvaW9lK1FUMWNhWC9yMG9aa1NEejZ2?= =?utf-8?B?WlBucVJzTGpZSS96b1JDR3JyQ3N2UCs0eDNqa05QS2ROS3RsSUpuV3crYk9s?= =?utf-8?B?R3ljcEMvL0htVHlCWDUyb21MYnpSSDg0cVpNVDJTNGk3REZaMm9NYkxoSlI2?= =?utf-8?B?YllLSXR5NitGZlpuMHFUQ1F4aFUyMElTNnRIbk45aFhlWFRpY1RtaEhhYmp6?= =?utf-8?B?aXMzNFgyRVRicS9Zd1FuN3V6b2RyM3RNN090Q0xGRmxsU3UxNjJTZi8yM3NS?= =?utf-8?B?WFJ4dW90aWdDVHdwMGl0TjU5K2w4ZW1ZU0lESVZrZHlrNUpTYUJwdWN1RSs1?= =?utf-8?B?VGFDOEVrQTRXUWNsek8ybTlFd2JSenFubHdNT0c4VDkyazJiTU5rMklGNTdJ?= =?utf-8?B?eC9GdWtyd0xmSGk1NS9lbHlMTkd6UXV5UWVTK2I5dkx0dUd3TkNSNWs4WTFE?= =?utf-8?B?by9qbldRZnFPWjYzR1ZLWHpGMEdXQ2wweXhZS2JpaUNuUjhIUW9Rc09XemNy?= =?utf-8?B?Umx2WWlPMW0vV0J4eCtUcWszUGtvWFdETmpOWG5reE0zTi9nRlNPMW5FY1RL?= =?utf-8?B?YSttK2xNNld0VjhOaEdPSEZKZXBuV3lHMlNNNS9xd1hJMzFTYmF3aU9YSVlF?= =?utf-8?B?MVRVQkNRcFdnTkZsNktTc3UxOFdWc0NsKzU3OTBRNUhXYmFQbllydlN5dG1C?= =?utf-8?B?SjVpbHNTOGVzUkN0aWN1T080N09JeXR0T1V2cjl4WGZIc2dLdWs4dHNQb0xl?= =?utf-8?B?SVFRRkc5Ylc2eWw3dDIvSTRVRGFZVjJnMWRvSFVqc1FjcUJ0RGhzT2l5OElq?= =?utf-8?B?VktOOUJscnBmMUN1RVozQVl3dVcvQVQrdm82ZjF0ZGFiVVdlNEJmYUlBMllW?= =?utf-8?B?eXZlaEVsbjRNZVdOZWx4SzgzZ2s3eHJLellGR2VxQlQzYVp4UEo5WXgxZzlp?= =?utf-8?B?ZjFPWWUrR0xOTlhISnNaY29JSXM3OE9YdXowdHVLd1JTaFBrN09YRXhIWE1l?= =?utf-8?B?bmhkQ0JLbEZlTTlGSlhwelVPeVQvSjlxRVYrRGN6VlRBaVdpN0FnWTRsVWVp?= =?utf-8?B?L3FGZGJZTVhrV3QyMGFTbmFoZnQ4dm1pUFhoN0w0SjVzTUxReG5USFdtcjdE?= =?utf-8?B?RVU3VENMRlJqbFhYZ0wwck1xVWd2Vk5wR3lLT0VXakVNWTZoNUp2ZmlvcWUw?= =?utf-8?B?bVNJSHBDcmZFVXVPaWZ3RFFiWE9YWU5OOEtHTHIwd3hCS0FZYTk5Ujl5NXFT?= =?utf-8?B?MmFidWlXVkl3K0REcnZZMGIvcE0rNzcwMUlwTFhtWjJXTTlRTVFKMGVESUto?= =?utf-8?Q?S350gbm8jkWO5+p5+Z91?= X-Microsoft-Antispam-Message-Info: enwH/qVBZOsyhjrWNJr1IJ2nKx9VENca3yJH+SW7MjaMRj+XxuVUHBeAKrh5bFr7ATdjWqC6ktTJEuH99i+Vpt4Mu98M7FHE9QLzTmQboEZAH2lV/Bgm0nzMhLyOua0o8Ej6ndLzXiKVPdMTOKaAGfKZ7RZ4cnWtG6g/3eTlxg6fckLa02G1TuCm+ijKQTuL X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2775; 6:aEuAlJxGF+0E4DkMmw+tvRI013sP2Jc03hp635EqRr4U8cdVf3zMF60kfvt4EvnvlrC9Bu4y0wgUn2VVupnGCCXpQiv9VbYvhhByyllTC7G2sP8VKt/uRfym1s5YY/yzXj724u517JxNrfD7wRzQMNu1bNeyvlpWZb2QB9epDnCeuBKV88B2n8rHCsATj5H16WkAyajw0QNGh1cy2BDj704zv6nbgTt3oA+MG5Clyk6rIjWFEkFgUKhzTpbqVKSGqTC/4ENee1QGAatFIxeHD38LMZDeS81aSQ0WmWjneRo1YhvSe3YLWw+kJesEhtZq1I++gANdcEEMk4kVELPs3uxtnbaDl9P2dgcLcx79vtYYN0hl4VtNLhNSMjiKvCw26RgmAl4qB3dKtgx0nP1AcyKQ8PC2+iDOWi/fovwDalBw3CaL8cZT7HqeeWa9AINWkJpOK/HaioDeIuHMSJSSpA==; 5:5KJJkmTxEIHhRxQLQcl7G/bpiuNKb1Rtswy6pqxcYWnJNUSX4+UCOT06xJFcj3vAGkeZfmE/d8o0uBBU3/cdSIIKzVuYXoFGWooAq2jZL+2RIraPDvF2dLYpP1eElnJ64b2h3BBM2CtzUkAKEhKfssca46QzgHIkTSofQ7vtaaI=; 24:bzR6+tHGdHipAHYGzXH3YSHFbJHuDwQOZXkCLGPgb+u74C4BuwsQQf8IyRvxa+CY0iNp0ExtcUhcX/50JNrj7CovqR3RHfWTvP3eioN5ZdU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2775; 7:JahERAJJIgQqxDhv/z+rGOlMqmf9imAqUME9FIqke999QKEsVYqJ1VeFQdYh1krTpUp8HKbdc6vDSri4qSKCGXYbXizn/wvqA0tF0TLhl96uaTL4vuBbBQVeJV98yCVQU0q7TXyvkfYFMQrkwvOdXcYr01N3LPS6SvHZUYZoTMKCiyr+m6M3toI2wuMxh7gy+GHLsAqTLfFDRWV7C0r/ScZlVH0rqQMFHKsi3NU70oUPxsJ0uE3JGCXhA2rCFsxu X-MS-Office365-Filtering-Correlation-Id: 46593087-f5b7-4422-cf1b-08d5a052d257 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2018 08:53:06.1870 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 46593087-f5b7-4422-cf1b-08d5a052d257 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2775 Subject: Re: [dpdk-dev] Survey for final decision about per-port offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 08:53:14 -0000 On Friday 30 March 2018 07:17 PM, Thomas Monjalon wrote: > There are some discussions about a specific part of the offload API: > "To enable per-port offload, the offload should be set on both > device configuration and queue setup." > > It means the application must repeat the port offload flags > in rte_eth_conf.[rt]xmode.offloads and rte_eth_[rt]xconf.offloads, > when calling respectively rte_eth_dev_configure() and > rte_eth_[rt]x_queue_setup for each queue. > > The PMD must check if there is mismatch, i.e. a port offload not > repeated in queue setup. > There is a proposal to do this check at ethdev level: > http://dpdk.org/ml/archives/dev/2018-March/094023.html > > It was also proposed to relax the API and allow "forgetting" port > offloads in queue offloads: > http://dpdk.org/ml/archives/dev/2018-March/092978.html > > It would mean the offloads applied to a queue result of OR operation: > rte_eth_conf.[rt]xmode.offloads | rte_eth_[rt]xconf.offloads > With respect to DPAA and DPAA2 PMDs: > 1/ Do you agree with above API change? Yes > > > If we agree with this change, we need to update the documentation > and remove the checks in PMDs. > Note: no matter what is decided here, 18.05-rc1 should have all PMDs > switched to the API which was defined in 17.11. > Given that API is new and not yet adopted by the applications, > the sonner it is fixed, the better. > > 2/ Should we do this change in 18.05-rc2? Yes > > > At the same time, we want to make clear that an offload enabled at > port level, cannot be disabled at queue level. > > 3/ Do you agree with above statement (to be added in the doc)? Yes > > > There is the same kind of confusion in the offload capabilities: > rte_eth_dev_info.[rt]x_offload_capa > rte_eth_dev_info.[rt]x_queue_offload_capa > The queue capabilities must be a subset of port capabilities, > i.e. every queue capabilities must be reported as port capabilities. > But the port capabilities should be reported at queue level > only if it can be applied to a specific queue. > > 4/ Do you agree with above statement (to be added in the doc)? Yes > > > Please give your opinion on questions 1, 2, 3 and 4. > Answering by yes/no may be sufficient in most cases :) > Thank you > >